You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "flycash (GitHub)" <gi...@apache.org> on 2020/01/14 16:08:40 UTC

[GitHub] [dubbo-go] flycash opened pull request #325: Ftr: TracingFilter

<!--  Thanks for sending a pull request! 
-->

**What this PR does**:

Implementing tracing filter by using opentracing API.

**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #321 

**Special notes for your reviewer**:

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note

```

[ Full content available at: https://github.com/apache/dubbo-go/pull/325 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #325: Ftr: TracingFilter

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/325?src=pr&el=h1) Report
> Merging [#325](https://codecov.io/gh/apache/dubbo-go/pull/325?src=pr&el=desc) into [feature/tracing](https://codecov.io/gh/apache/dubbo-go/commit/cabd56a95cd775ebd976c2b29c5ff95260986d61?src=pr&el=desc) will **increase** coverage by `0.57%`.
> The diff coverage is `70.37%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/325/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/325?src=pr&el=tree)

```diff
@@                 Coverage Diff                 @@
##           feature/tracing     #325      +/-   ##
===================================================
+ Coverage            65.79%   66.37%   +0.57%     
===================================================
  Files                  113      115       +2     
  Lines                 7268     7295      +27     
===================================================
+ Hits                  4782     4842      +60     
+ Misses                2009     1973      -36     
- Partials               477      480       +3
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/325?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/context.go](https://codecov.io/gh/apache/dubbo-go/pull/325/diff?src=pr&el=tree#diff-Y29tbW9uL2NvbnRleHQuZ28=) | `0% <0%> (ø)` | |
| [filter/filter\_impl/tracing\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/325/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3RyYWNpbmdfZmlsdGVyLmdv) | `82.6% <82.6%> (ø)` | |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/325/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `62.31% <0%> (-10.15%)` | :arrow_down: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/325/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `47.93% <0%> (-1.55%)` | :arrow_down: |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/325/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `50.5% <0%> (-1.02%)` | :arrow_down: |
| [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/325/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `70.73% <0%> (+2.43%)` | :arrow_up: |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/325/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `75.67% <0%> (+5.4%)` | :arrow_up: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/325/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `60.69% <0%> (+10.4%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/dubbo-go/pull/325/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/325?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/325?src=pr&el=footer). Last update [cabd56a...0c19b52](https://codecov.io/gh/apache/dubbo-go/pull/325?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/325 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] pantianying commented on pull request #325: Ftr: TracingFilter

Posted by "pantianying (GitHub)" <gi...@apache.org>.
Should there be a separator in the middle？

[ Full content available at: https://github.com/apache/dubbo-go/pull/325 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #325: Ftr: TracingFilter

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/325?src=pr&el=h1) Report
> Merging [#325](https://codecov.io/gh/apache/dubbo-go/pull/325?src=pr&el=desc) into [feature/tracing](https://codecov.io/gh/apache/dubbo-go/commit/cabd56a95cd775ebd976c2b29c5ff95260986d61?src=pr&el=desc) will **increase** coverage by `0.57%`.
> The diff coverage is `70.37%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/325/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/325?src=pr&el=tree)

```diff
@@                 Coverage Diff                 @@
##           feature/tracing     #325      +/-   ##
===================================================
+ Coverage            65.79%   66.37%   +0.57%     
===================================================
  Files                  113      115       +2     
  Lines                 7268     7295      +27     
===================================================
+ Hits                  4782     4842      +60     
+ Misses                2009     1973      -36     
- Partials               477      480       +3
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/325?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/context.go](https://codecov.io/gh/apache/dubbo-go/pull/325/diff?src=pr&el=tree#diff-Y29tbW9uL2NvbnRleHQuZ28=) | `0% <0%> (ø)` | |
| [filter/filter\_impl/tracing\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/325/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3RyYWNpbmdfZmlsdGVyLmdv) | `82.6% <82.6%> (ø)` | |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/325/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `62.31% <0%> (-10.15%)` | :arrow_down: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/325/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `47.93% <0%> (-1.55%)` | :arrow_down: |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/325/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `50.5% <0%> (-1.02%)` | :arrow_down: |
| [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/325/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `70.73% <0%> (+2.43%)` | :arrow_up: |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/325/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `75.67% <0%> (+5.4%)` | :arrow_up: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/325/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `60.69% <0%> (+10.4%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/dubbo-go/pull/325/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/325?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/325?src=pr&el=footer). Last update [cabd56a...5216fb1](https://codecov.io/gh/apache/dubbo-go/pull/325?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/325 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] flycash closed pull request #325: Ftr: TracingFilter

Posted by "flycash (GitHub)" <gi...@apache.org>.
[ pull request closed by flycash ]

[ Full content available at: https://github.com/apache/dubbo-go/pull/325 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] flycash commented on pull request #325: Ftr: TracingFilter

Posted by "flycash (GitHub)" <gi...@apache.org>.
Yes, I added it.

[ Full content available at: https://github.com/apache/dubbo-go/pull/325 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org