You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "b0c1 (via GitHub)" <gi...@apache.org> on 2023/05/15 10:44:15 UTC

[GitHub] [fineract] b0c1 opened a new pull request, #3181: Fineract modularization - stage 0

b0c1 opened a new pull request, #3181:
URL: https://github.com/apache/fineract/pull/3181

   - [x] Create fineract-core module - used to common cross module classes and interfaces
   - [x] Create fineract-investor module for build
   - [x] Modify tenant liquibase loader to using module based liquibase processing
   - [x] Sample liquibase into the fineract-investor module
   - [x] Move NewCommandSourceHandler and dependencies to the fineract-core
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [fineract] galovics merged pull request #3181: Fineract modularization - stage 0

Posted by "galovics (via GitHub)" <gi...@apache.org>.
galovics merged PR #3181:
URL: https://github.com/apache/fineract/pull/3181


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [fineract] galovics commented on pull request #3181: Fineract modularization - stage 0

Posted by "galovics (via GitHub)" <gi...@apache.org>.
galovics commented on PR #3181:
URL: https://github.com/apache/fineract/pull/3181#issuecomment-1547853001

   @vidakovic yeah there was the need. This is still an intermediate step. If we are finally getting rid of the json parsing, we can still do it. It adds no overhead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [fineract] vidakovic commented on pull request #3181: Fineract modularization - stage 0

Posted by "vidakovic (via GitHub)" <gi...@apache.org>.
vidakovic commented on PR #3181:
URL: https://github.com/apache/fineract/pull/3181#issuecomment-1547764656

   Just out of curiosity: was there an immediate need to create this core module? Personally, I would have waited a bit to get all that manual JSON parsing stuff (or at least as much as possible) out of the way first... was out of the loop lately, so might have missed the discussions... just curious.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org