You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cayenne.apache.org by "John Huss (JIRA)" <ji...@apache.org> on 2013/08/16 23:15:48 UTC

[jira] [Updated] (CAY-1847) Make ConverterFactory extensible and injected via DI

     [ https://issues.apache.org/jira/browse/CAY-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Huss updated CAY-1847:
---------------------------

    Attachment: CAY-1847-Make-ConverterFactory-extensible.patch

Here is patch for review.  I decided not to do dependency injection since this code does not require a cayenne stack, but is really general purpose java beans stuff.

I ended up changing more than I had originally thought.  I added generic typing to Converter to make it more clear what the contract is for it.  

I added conversions for Date and Timestamp, but only from long (milliseconds) and not really from strings since the date format is perhaps debatable.  

I also added a generic converter that works for most typical value classes, including Joda in some cases (depending on string formatting, etc).  But there is still a need for specific Joda converters.
                
> Make ConverterFactory extensible and injected via DI
> ----------------------------------------------------
>
>                 Key: CAY-1847
>                 URL: https://issues.apache.org/jira/browse/CAY-1847
>             Project: Cayenne
>          Issue Type: Bug
>          Components: Core Library
>    Affects Versions: 3.2M2
>            Reporter: John Huss
>            Assignee: John Huss
>            Priority: Minor
>         Attachments: CAY-1847-Make-ConverterFactory-extensible.patch
>
>
> Make org.apache.cayenne.reflect.ConverterFactory extensible and injected via DI.
> In my app I'm looking to add support for Joda time classes and need to be able to extend this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira