[GitHub] [superset] craig-rueda commented on pull request #17757: feat: Authorizing guest access to embedded dashboards

[GitBox <gi...@apache.org>]

craig-rueda commented on pull request #17757:
URL: https://github.com/apache/superset/pull/17757#issuecomment-1018787336


   Overall code looks good - I think you just need a few more tests to make sure a few more areas are covered (security logic test coverage should be kept high generally). One other thing that might become an issue down the road is token size. From what I understand, there's a `resources` key that is embedded in tokens. If this list gets too big, the JWT itself will be too big to pass in as a header.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org