You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Kelvin Ye (JIRA)" <ji...@apache.org> on 2007/06/13 05:31:26 UTC
[jira] Created: (HARMONY-4138) [classlib][luni] Remove unnecessary
protected constructor for ServerSocket
[classlib][luni] Remove unnecessary protected constructor for ServerSocket
--------------------------------------------------------------------------
Key: HARMONY-4138
URL: https://issues.apache.org/jira/browse/HARMONY-4138
Project: Harmony
Issue Type: Bug
Components: Classlib
Environment: Linux and Windows
Reporter: Kelvin Ye
The following protected constructor for ServerSocket is never used.
protected ServerSocket(SocketImpl impl) {
this.impl = impl;
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-4138) [classlib][luni] Remove unnecessary
protected constructor for ServerSocket
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oliver Deakin closed HARMONY-4138.
----------------------------------
Resolution: Duplicate
Assignee: Oliver Deakin
Closing as a duplicate. Please continue any further work on this bug under the original issue HARMONY-3809.
> [classlib][luni] Remove unnecessary protected constructor for ServerSocket
> --------------------------------------------------------------------------
>
> Key: HARMONY-4138
> URL: https://issues.apache.org/jira/browse/HARMONY-4138
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: Linux and Windows
> Reporter: Kelvin Ye
> Assignee: Oliver Deakin
> Attachments: harmony-4138.diff
>
>
> The following protected constructor for ServerSocket is never used.
> protected ServerSocket(SocketImpl impl) {
> this.impl = impl;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4138) [classlib][luni] Remove unnecessary
protected constructor for ServerSocket
Posted by "Kelvin Ye (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kelvin Ye updated HARMONY-4138:
-------------------------------
Attachment: harmony-4138.diff
Would you please try the patch? Thanks very much!
> [classlib][luni] Remove unnecessary protected constructor for ServerSocket
> --------------------------------------------------------------------------
>
> Key: HARMONY-4138
> URL: https://issues.apache.org/jira/browse/HARMONY-4138
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: Linux and Windows
> Reporter: Kelvin Ye
> Attachments: harmony-4138.diff
>
>
> The following protected constructor for ServerSocket is never used.
> protected ServerSocket(SocketImpl impl) {
> this.impl = impl;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4138) [classlib][luni] Remove
unnecessary protected constructor for ServerSocket
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504173 ]
Oliver Deakin commented on HARMONY-4138:
----------------------------------------
Hi Kelvin - when I apply this patch and try to rebuild I get a compilation failure:
[javac] 1. ERROR in C:\harmony\svn-checkouts\classlib-clean\modules\nio\src\main\java\org\apache\harmony\nio\internal\ServerSocketChannelImpl.java
[javac] (at line 223)
[javac] super(impl);
[javac] ^^^^^^^^^^^
[javac] The constructor ServerSocket(SocketImpl) is undefined
[javac] ----------
[javac] 1 problem (1 error)
It appears that ServerSocketChannelImpl is using this constructor, so I don't think this is a valid bug. Do you agree?
> [classlib][luni] Remove unnecessary protected constructor for ServerSocket
> --------------------------------------------------------------------------
>
> Key: HARMONY-4138
> URL: https://issues.apache.org/jira/browse/HARMONY-4138
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: Linux and Windows
> Reporter: Kelvin Ye
> Attachments: harmony-4138.diff
>
>
> The following protected constructor for ServerSocket is never used.
> protected ServerSocket(SocketImpl impl) {
> this.impl = impl;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4138) [classlib][luni] Remove
unnecessary protected constructor for ServerSocket
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504183 ]
Oliver Deakin commented on HARMONY-4138:
----------------------------------------
Thanks Mikhail. Kelvin, if you are interested in pursuing this fix I will be happy to take a look at any further patches you supply.
> [classlib][luni] Remove unnecessary protected constructor for ServerSocket
> --------------------------------------------------------------------------
>
> Key: HARMONY-4138
> URL: https://issues.apache.org/jira/browse/HARMONY-4138
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: Linux and Windows
> Reporter: Kelvin Ye
> Attachments: harmony-4138.diff
>
>
> The following protected constructor for ServerSocket is never used.
> protected ServerSocket(SocketImpl impl) {
> this.impl = impl;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4138) [classlib][luni] Remove
unnecessary protected constructor for ServerSocket
Posted by "Mikhail Markov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504181 ]
Mikhail Markov commented on HARMONY-4138:
-----------------------------------------
This JIRA actually duplicates HARMONY-3809.
Although this constructor could not be removed immediately, it make sense to re-work the code to make it removed in the future as JAPI complains about it.
> [classlib][luni] Remove unnecessary protected constructor for ServerSocket
> --------------------------------------------------------------------------
>
> Key: HARMONY-4138
> URL: https://issues.apache.org/jira/browse/HARMONY-4138
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: Linux and Windows
> Reporter: Kelvin Ye
> Attachments: harmony-4138.diff
>
>
> The following protected constructor for ServerSocket is never used.
> protected ServerSocket(SocketImpl impl) {
> this.impl = impl;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4138) [classlib][luni] Remove
unnecessary protected constructor for ServerSocket
Posted by "Kelvin Ye (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504524 ]
Kelvin Ye commented on HARMONY-4138:
------------------------------------
OK. Thanks very much!
> [classlib][luni] Remove unnecessary protected constructor for ServerSocket
> --------------------------------------------------------------------------
>
> Key: HARMONY-4138
> URL: https://issues.apache.org/jira/browse/HARMONY-4138
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: Linux and Windows
> Reporter: Kelvin Ye
> Assignee: Oliver Deakin
> Attachments: harmony-4138.diff
>
>
> The following protected constructor for ServerSocket is never used.
> protected ServerSocket(SocketImpl impl) {
> this.impl = impl;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.