You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/09/16 16:44:00 UTC

[jira] [Work logged] (COMPRESS-614) Use FileTime for time fields in SevenZipArchiveEntry

     [ https://issues.apache.org/jira/browse/COMPRESS-614?focusedWorklogId=809589&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-809589 ]

ASF GitHub Bot logged work on COMPRESS-614:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Sep/22 16:43
            Start Date: 16/Sep/22 16:43
    Worklog Time Spent: 10m 
      Work Description: codecov-commenter commented on PR #256:
URL: https://github.com/apache/commons-compress/pull/256#issuecomment-1249574174

   # [Codecov](https://codecov.io/gh/apache/commons-compress/pull/256?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#256](https://codecov.io/gh/apache/commons-compress/pull/256?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (69d5de0) into [master](https://codecov.io/gh/apache/commons-compress/commit/e3f549320eb384d0a85208ae0ce1f760f9148f1d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e3f5493) will **decrease** coverage by `0.00%`.
   > The diff coverage is `77.90%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #256      +/-   ##
   ============================================
   - Coverage     80.05%   80.05%   -0.01%     
   - Complexity     6620     6645      +25     
   ============================================
     Files           339      340       +1     
     Lines         25416    25461      +45     
     Branches       4199     4202       +3     
   ============================================
   + Hits          20346    20382      +36     
   - Misses         3471     3480       +9     
     Partials       1599     1599              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/commons-compress/pull/256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../compress/archivers/sevenz/SevenZArchiveEntry.java](https://codecov.io/gh/apache/commons-compress/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29tcHJlc3MvYXJjaGl2ZXJzL3NldmVuei9TZXZlblpBcmNoaXZlRW50cnkuamF2YQ==) | `75.00% <53.84%> (-6.82%)` | :arrow_down: |
   | [...che/commons/compress/archivers/zip/X000A\_NTFS.java](https://codecov.io/gh/apache/commons-compress/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29tcHJlc3MvYXJjaGl2ZXJzL3ppcC9YMDAwQV9OVEZTLmphdmE=) | `66.66% <79.16%> (+5.79%)` | :arrow_up: |
   | [...ns/compress/archivers/sevenz/SevenZOutputFile.java](https://codecov.io/gh/apache/commons-compress/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29tcHJlc3MvYXJjaGl2ZXJzL3NldmVuei9TZXZlblpPdXRwdXRGaWxlLmphdmE=) | `96.94% <87.50%> (+0.49%)` | :arrow_up: |
   | [...ommons/compress/archivers/tar/TarArchiveEntry.java](https://codecov.io/gh/apache/commons-compress/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29tcHJlc3MvYXJjaGl2ZXJzL3Rhci9UYXJBcmNoaXZlRW50cnkuamF2YQ==) | `71.71% <100.00%> (ø)` | |
   | [...a/org/apache/commons/compress/utils/TimeUtils.java](https://codecov.io/gh/apache/commons-compress/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29tcHJlc3MvdXRpbHMvVGltZVV0aWxzLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [.../commons/compress/compressors/bzip2/BlockSort.java](https://codecov.io/gh/apache/commons-compress/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29tcHJlc3MvY29tcHJlc3NvcnMvYnppcDIvQmxvY2tTb3J0LmphdmE=) | `84.27% <0.00%> (-0.47%)` | :arrow_down: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   




Issue Time Tracking
-------------------

    Worklog Id:     (was: 809589)
    Time Spent: 3h 10m  (was: 3h)

> Use FileTime for time fields in SevenZipArchiveEntry
> ----------------------------------------------------
>
>                 Key: COMPRESS-614
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-614
>             Project: Commons Compress
>          Issue Type: Improvement
>          Components: Archivers
>    Affects Versions: 1.21
>            Reporter: Andre Brait
>            Priority: Major
>              Labels: 7zip
>          Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> Instead of java.util.Date, which caps precision in milliseconds, let's move on to using FileTime.
> We can keep backwards compatibility through the getters and setters for modification, access and creation dates.
> If you're ok with it, I'll send a PR for this.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)