You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "puridach-w (via GitHub)" <gi...@apache.org> on 2024/01/23 06:50:56 UTC
[PR] Feat: Keep searching result [superset]
puridach-w opened a new pull request, #26755:
URL: https://github.com/apache/superset/pull/26755
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
The feature change involves retaining search filter results across SQL Lab tabs by integrating search text into the Redux state.
Under the previous system, users would encounter the resetting of their search results each time they switched to a different SQL Lab tab and back. This process required users to repeatedly enter their search filters, resulting in a disrupted workflow.
This enhancement directly tackles this inconvenience. Upon rendering SQL Lab, it now utilizes the search text stored in Redux state as the filter value. This ensures that no matter how many tabs a user switches between, the search filter results remain persistent, no longer disappearing upon tab switching.
### BEFORE SCREENSHOTS OR ANIMATED GIF
https://github.com/apache/superset/assets/76474644/79a9d872-87c3-49d9-9e9e-01b958c4f86c
### AFTER SCREENSHOTS OR ANIMATED GIF
https://github.com/apache/superset/assets/76474644/e091d7a6-132f-4951-a3dd-98557a7e3d2f
### TESTING INSTRUCTIONS
- Navigate to the SQLLab page
- Execute Query
- Apply a filter on the resulting output table using the search box
- Navigate to other SQL editor tab
- Return to the initial SQL editor tab
- Notice that the previously input search text and filter results are still visible
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Keep searching result [superset]
Posted by "puridach-w (via GitHub)" <gi...@apache.org>.
puridach-w closed pull request #26755: feat: Keep searching result
URL: https://github.com/apache/superset/pull/26755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Feat: Keep searching result [superset]
Posted by "puridach-w (via GitHub)" <gi...@apache.org>.
puridach-w commented on PR #26755:
URL: https://github.com/apache/superset/pull/26755#issuecomment-1910232778
Could you clarify more? I'm not quite sure what you're meaning or what the next steps should be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Feat: Keep searching result [superset]
Posted by "puridach-w (via GitHub)" <gi...@apache.org>.
puridach-w commented on PR #26755:
URL: https://github.com/apache/superset/pull/26755#issuecomment-1907351633
Video: https://github.com/apache/superset/assets/76474644/780415d6-a42f-4187-81de-02a5c8d89a75
Actually, after switching back to the original tab, it automatically fetches the result table, as shown in the provided video.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Feat: Keep searching result [superset]
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on PR #26755:
URL: https://github.com/apache/superset/pull/26755#issuecomment-1910723330
cc @gaurav7261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Feat: Keep searching result [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #26755:
URL: https://github.com/apache/superset/pull/26755#issuecomment-1906516805
Hi @puridach-w. Thank you for PR. I'm not sure why the table is re-rendered when you switch tabs but that could be a problem for this feature given that it won't be intuitive for users that the results will be filtered after you run the query again. @justinpark probably has more context why the tabs need to be re-rendered. If the tab was not re-rendered, then maintaining the search state would totally make sense (actually that's what I would expect when switching tabs).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Feat: Keep searching result [superset]
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on PR #26755:
URL: https://github.com/apache/superset/pull/26755#issuecomment-1915503868
> Could you clarify more? I'm not quite sure what you're meaning or what the next steps should be.
This issue wasn't intended and will be fixed (without your PR) once this [PR](https://github.com/apache/superset/pull/26156) is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Feat: Keep searching result [superset]
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on PR #26755:
URL: https://github.com/apache/superset/pull/26755#issuecomment-1908820870
@puridach-w Thank you for highlighting this issue. As @michael-s-molina has pointed out, the result state should remain constant while switching tabs, making an additional search term state storage unnecessary. I previously drafted a [PR](https://github.com/apache/superset/pull/26156) (which was reverted because of regression issues) that should address this concern without requiring extra redux logic. I'll provide updates on this PR later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Keep searching result [superset]
Posted by "puridach-w (via GitHub)" <gi...@apache.org>.
puridach-w commented on PR #26755:
URL: https://github.com/apache/superset/pull/26755#issuecomment-1993494059
> > Could you clarify more? I'm not quite sure what you're meaning or what the next steps should be.
>
> This issue wasn't intended and will be fixed (without your PR) once this [PR](https://github.com/apache/superset/pull/26156) is merged.
I've noticed that the issue was resolved following the merge of the PR you mentioned, so I'll close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org