You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "sk0x50 (via GitHub)" <gi...@apache.org> on 2023/09/12 13:47:38 UTC
[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2546: IGNITE-20041 Asynchronous writeIntent cleanup on write intent resolution
sk0x50 commented on code in PR #2546:
URL: https://github.com/apache/ignite-3/pull/2546#discussion_r1323073704
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/StorageUpdateHandler.java:
##########
@@ -307,11 +308,45 @@ private void handleTransactionCleanup(Set<RowId> pendingRowIds, boolean commit,
* @param commitTimestamp Commit timestamp.
* @param onApplication On application callback.
*/
- private void handleTransactionCommit(Set<RowId> pendingRowIds, HybridTimestamp commitTimestamp, Runnable onApplication) {
+ private void handleTransactionCommit(UUID txId, Set<RowId> pendingRowIds, HybridTimestamp commitTimestamp, Runnable onApplication) {
+
+ assert commitTimestamp != null : "Commit timestamp is null";
+
storage.runConsistently(locker -> {
- pendingRowIds.forEach(locker::lock);
+ // Please note: `pendingRowIds` might not contain the complete set of rows that were changed by this transaction:
Review Comment:
Special thanks for the comments! :heart_on_fire:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org