Re: [PR] feat(ddl_client): add failure logs when backup or restore commands failed [incubator-pegasus]

["empiredan (via GitHub)" <gi...@apache.org>]

empiredan commented on code in PR #1701:
URL: https://github.com/apache/incubator-pegasus/pull/1701#discussion_r1409043761


##########
src/client/replication_ddl_client.cpp:
##########
@@ -1350,6 +1354,8 @@ dsn::error_code replication_ddl_client::query_restore(int32_t restore_app_id, bo
     } else if (response.err == ERR_APP_DROPPED) {
         std::cout << "restore failed, because some partition's data is damaged on cold backup media"
                   << std::endl;
+    } else {

Review Comment:
   Is it necessary to print some error message here ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org