You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2016/06/02 22:20:52 UTC
Review Request 48189: remove sqlf, sql fabric,
gemfirexd from geode-core
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48189/
-----------------------------------------------------------
Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
Bugs: GEODE-1464
https://issues.apache.org/jira/browse/GEODE-1464
Repository: geode
Description
-------
removed internal Delta (only used by sqlf)
removed sqlfDisconnectListener
removed getStringForSQLF
removed sqlfabric.sys-disk-dir system property
removed unInitializedMembers and deferredVolunteerForPrimary
removed sqlf serialization code
removed GemFireUtilLauncher
removed afterValueOverflow
removed preferObject, eager deserialize, and KeyWithRegionContext
removed unused sqlf methods in PartitionedRegion
removed memberUnInitialized
removed sqlf from DiskEntry
removed setCallbackArgument from EntryOperationImpl
removed distributeUpdatedProfileOnHubCreation
removed getEntriesInTxForSqlFabric
removed withRoutingObjects and hasRoutingObjects
removed resetBucketAdvisorParents
rebalance no longer calls GemFireCacheImpl.getInstance comments
removed sqlf log messages
removed sqlf OffHeapIdentifiers
removed SqlfSerializationException from sanctionedSerializables
removed static helper methods from DiskWriteAttributesImpl
removed contextObject from EntryEventImpl
remove serializeCallbackArg from WrappedCallbackArgument since it was always true
removed getLeaderRegionName and getColocatedRegionName
removed newPutEntryEvent
removed clearLocalPrimaries
removed call to non-existent OSProcess$NativeOSCalls
removed putDML
removed getClassesToSerializers
simplified cleanUpOnImcompleteOp
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/IndexUpdater.java facbdf2cecd699361c3cc7782a38ab21d436637e
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionMessage.java bb36b8023b050f17e2d8e742875c736bcabf7755
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java 552dbe3e2aeda91a6dbce7d0f27e07c038f683cc
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ReplyProcessor21.java e5e8cbfb9ab734d93fea991b1d6715b9a7b31a9e
geode-core/src/main/java/com/gemstone/gemfire/internal/DSCODE.java 8d91c6b7e616e42f0c92da07492c2ade4d8e3e6f
geode-core/src/main/java/com/gemstone/gemfire/internal/DSFIDFactory.java bd78f5ae78953fab616f2ada870aa1aa920d56f3
geode-core/src/main/java/com/gemstone/gemfire/internal/DataSerializableFixedID.java 7427f9009dfb732971970a518a2a27adc81c62cd
geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireUtilLauncher.java fa19049a8f2e1af70250a7c18abe3d4fa8d27a26
geode-core/src/main/java/com/gemstone/gemfire/internal/InternalDataSerializer.java bff592b5ac8dc98f7bcd716910ae4c776fadb358
geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java 515b27dcf0ff38ea5f1024f7ba8b7262172c203a
geode-core/src/main/java/com/gemstone/gemfire/internal/Version.java 258eaf0e683da7ce4025f5cf388574935dcc3bc4
geode-core/src/main/java/com/gemstone/gemfire/internal/VersionedDataStream.java a2711ffee9e7575edeff8cd921a3168883ce9ec8
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractDiskRegionEntry.java b65b7addc4d572b262b0a0a8a99ee4a79ac0390f
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java 25cc818603e5a4f1a0a10f57a2861afb0599bd81
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java 0cbec19408198a5d4fc7f975b43ad4075e29a580
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketAdvisor.java c241c6b7760e0cde59facd7f708c716f563eb2a9
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java e2482bb5592546d280c6f3fb73f7775e9a174afd
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheDistributionAdvisor.java 4a34771388da63a648c6d7763fc39334aa716b38
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerLauncher.java d4c19ce6e0d464e90fd62935e00e7a7be72ce659
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CachedDeserializableFactory.java 84e44d84807ae05440edd664d1a4b0ab79bf9ea0
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationHelper.java 72edc1076c5480a665bba39af21ee87da7635372
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DestroyOperation.java e26719076eb0c49ae364da951f72fef7bf136a42
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java 54ecb0434298ab6af2af8724a33048732735fc7d
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskInitFile.java 7e2333e779db4a46d0fe1f88d7ae61c7831fde5a
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskRegion.java c1d2f038992680e94cc5605ade0ae11bb3796531
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskWriteAttributesImpl.java 914c8781ed979be5903b0818750a88dfe2073451
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistTXState.java cafdb805e97fa1e9c5a35e7efe663f1059a6d429
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistTXStateOnCoordinator.java 33bec1c27d574ee963d488123d8b0ab08b9548ea
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedCacheOperation.java 6a7b4f2f7192613b5f90d46274a0875d7483d074
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedPutAllOperation.java b6aa1b644784639973d3232b6e354937d7bd4ac7
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegion.java cc86e2c9381091e33bd877e42fe4a39677644922
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegionFunctionStreamingMessage.java e51bedd4fc621a416a1a2df8b86c876f33b15bfe
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRemoveAllOperation.java 1d216ce63948d8276295de0559307cfb05c2c01c
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryBits.java f95af608efee479aad2038a501c5dae1183bec63
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java 68c8117b45b2319eca861205a1e9e69602738edf
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryOperationImpl.java d539366476014243dbd77ff825b6e8b0eb93cf5f
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 76a27298fba3f6c2b4c6d1d3fdfdfde6216e0797
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GridAdvisor.java fd350a0fffd17637a7484690e545689bf8dcbefd
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InitialImageOperation.java b43ba2d510275eeb78530e1b81cb62321c2338cf
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InternalRegionArguments.java f7d46feac4a1f4880c6bd1f91b7aaa5b4ddb5f66
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InvalidateOperation.java 6e1d91e426dc6a78da1cc936bb9cef08f3206a06
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/KeyInfo.java 30f30fcb237f7e5bd665e0c329fc39771a959af1
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/KeyWithRegionContext.java b28a551a6703e9a27fe169eacc39185c0addda74
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ListOfDeltas.java 6592863f286cf66bfd634957343b16833568b03b
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java cc5ac59e9390542f593becd37e332d7b63c350d5
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/Oplog.java 96f616b4a2471bdf4e10d8b3cbcf52df59f58bc0
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PRHARedundancyProvider.java 6fe39b1e651b1d435ef95f329bd3558d0dbee1e1
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionAttributesImpl.java d1e2bd0ad27cb46c3c9c23bfd0584bfb0feaa013
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java ea207aea40aad944abd8fce572faed73e03f82e4
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegionDataStore.java bda68e38fb6bd4f5f2b286ee23d85f4b8b3a4b26
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ProxyRegionMap.java 74c134b90134ded2a19c02440bb756754c3a019d
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/QueuedOperation.java 2d5a69866825da65f77f3203adf69e29dc074c78
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionEntry.java 09aef2a02ae851573a9358f1f62c129dee1a3b00
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionMap.java a7c26073dbbc236e000dffd56024a32e957cb991
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteContainsKeyValueMessage.java acf87238a826760b5802516e3986bf26de9f9167
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteDestroyMessage.java f7109bb9b453beb78d4ac7510b3e7b9628a350f6
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteFetchEntryMessage.java 685f0a5ee6c7adeec16a275b0ebb9af217ee4db3
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteFetchVersionMessage.java 12e4de6114ef1bb5f3327f65747b78d838b15f37
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteGetMessage.java b565a2cdc89f23b854fd2690f7265284dfd214dd
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteInvalidateMessage.java c4ed1ccefa78de7e02531d1656171a05e224e7e0
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutAllMessage.java ff09af9a7fa3b48cc673a64f505265ab3e8154ae
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutMessage.java 27f2bb96424bb588b53080f3a29860910d865cec
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteRemoveAllMessage.java 01e8d9e2341b300bd34d09e4fdcdf2a9bb19e330
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/SearchLoadAndWriteProcessor.java 6642ec61b66f1b5cec22704a3610351dba47909b
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEntry.java 2906ff6e03efb0d491ef1d8abe97dec2ae99f24a
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEntryState.java b6686d42a6ec1fd8a0797a17cc007bf006fb3a99
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRegionLockRequestImpl.java 29af5cc96334648a8a26b619d33da72ff3b82a74
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRegionState.java 116edf71e81f95150975f94f709186e427655b84
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXState.java e610991d12ddbe317f6894b71c27c84e09fc78ba
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXStateInterface.java 3fa935129ed1daefcbd163d34dc90962e4230894
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateAttributesProcessor.java 866eaffce1d20dc88e39f04cf4dd3154ebe78db2
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateEntryVersionOperation.java fce4deea5515bb6e6e9972648d09d15acaec77e8
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateOperation.java 730d6d772c85e945050c627831f640d1e1b93ddc
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ValidatingDiskRegion.java 54133cc478a206bc30d7606cd0dfd52e9f7549d8
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/WrappedCallbackArgument.java 99a5cebbf7189f22119f3eff2e7ce279d979f8cb
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/delta/Delta.java aeabbd8474ef211d03343058f8ff8e05496b72b4
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/AbstractExecution.java ff736be3bcbee7e03d62dc2ddd6795e1c39cfb46
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/FunctionStreamingResultCollector.java 3874ad90f8c92602406e318ce9a43b58fc7bc635
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalExecution.java d3fd2f27ecaadc7fe1495365b4ec7e42aedea88f
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalFunctionService.java 8af841d0ade52fa6c58c277bb74a2cc87ea14b72
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalRegionFunctionContext.java 22349256f46487ffb25780a82c8778f9d97418b3
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/MemberFunctionExecutor.java ac628a0ff429303f8ab31ee9028605bf95e1b765
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/MultiRegionFunctionExecutor.java 192916997f3ffd1639d7f47880476dfd1c9923ea
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/RegionFunctionContextImpl.java 175e863c2a575626716bbc638749356c49be02a8
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/ServerFunctionExecutor.java 9c06bf67b0cdbab53e26de11034cd12b644966e8
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/ContainsKeyValueMessage.java 4a9c684a49e6e7715d0d583977ab317aa94c9a60
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/DestroyMessage.java c706a3c7d5c14377587aaa6b336ba08c2382f34f
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchBulkEntriesMessage.java ea47e91a53ded0ed03781e8ff83b7e7bd8146fb4
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessage.java d27e33e32a113bbead7340c54d8e27c8d6fb3339
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntryMessage.java ae363ba53eebad4911f6b2685f804bae2eca2899
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchKeysMessage.java d7c7d71f4aa50584dc39a0ebeea563dccdd40dc8
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/GetMessage.java 3fef79004cbca788fcd6b9368c8b193043210f02
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/InvalidateMessage.java 60508c170afe4fa83a8c46c22706e852bcade1c4
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PREntriesIterator.java ec2a8dbf18801ed567172c1a0ec3a3daeb08bf5d
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PRUpdateEntryVersionMessage.java e1766dc036e864d5ec77aeb32b09ab4537e70f48
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessage.java 626efefc1921cac2919c56ed415707a426b5ea50
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PutAllPRMessage.java 8aaf587a7f72ca60bb2e4a754592ecf8991e5608
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PutMessage.java a6a39dc902027040e4aa49359915f04c9273bff7
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RegionAdvisor.java 03df3fb122f981864e583b9d698ac2f2a9cdede8
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RemoteFetchKeysMessage.java ac95e03830ae386cbce04bf9cdc0091568a90e67
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RemoveAllPRMessage.java fb46e0c85a3785dc7aae251f1ecf04edd0f89e54
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/rebalance/PartitionedRegionLoadModel.java 1cfa4a4927b33540efb3f5b952975e0052daeb76
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/GatewayReceiverCommand.java 448be9247cdf9b36ec75899c999f631eec48db0e
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tx/DistTxEntryEvent.java 6e7c21cbd9546cd812ba131aca0a4686bd98bb08
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySender.java 713023ff42cc91295c7767716d111211fdd367c6
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java 2ef5e19a7ea22f84fb1a7b29e5cbe224aaaaf847
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventCallbackArgument.java f6f8d885ff85450346553d49cbb71a9d2f4c6479
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventImpl.java 09d68f547c816747a5a4692ed389afe470982fe3
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java 46ff2636dda03d58d7401b196a75e89094de6171
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/RegionAttributesCreation.java 4dfe6aee4c707fc14b6a4cec1f994db690e3b319
geode-core/src/main/java/com/gemstone/gemfire/internal/i18n/LocalizedStrings.java d3d232ee71390ddc424b4e78a5f907ea974d7e4b
geode-core/src/main/java/com/gemstone/gemfire/internal/logging/LoggingThreadGroup.java 48c0eac3b0862a835dbf30cf3a872f37a9b07017
geode-core/src/main/java/com/gemstone/gemfire/internal/logging/ManagerLogWriter.java 28419fc2eaa17d0836c4c2bb1c295d1f6e80b1ce
geode-core/src/main/java/com/gemstone/gemfire/internal/logging/PureLogWriter.java 3279bf622b51bed1a36438da39df241d8eb55770
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapHelper.java 0f33d5a7d91d2ae16f6864b55054386b56bd80ca
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImpl.java 571c2d1a9aa1f7fe1ece1fb46e1b691d18de72e7
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/annotations/OffHeapIdentifier.java e275467a67fd51aeee637b65f79f360783562bd5
geode-core/src/main/java/com/gemstone/gemfire/internal/shared/NativeCalls.java f0fc27aac1c7613142fd6a3394860921cf9fbef3
geode-core/src/main/java/com/gemstone/gemfire/internal/util/ArrayUtils.java 4f15b17dfe9d38f6de878e42cac043ad1e5101aa
geode-core/src/main/java/com/gemstone/gemfire/internal/util/concurrent/CustomEntryConcurrentHashMap.java 144c7a3a4d9e840889a9ddcac5821f9e3e1caf60
geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java e11233770d8fc812706cc29b2e288e6305a2fe7b
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 3a06c1c13745f6d6477ff61176d5986ae29d01d6
geode-core/src/test/java/com/gemstone/gemfire/disttx/DistributedTransactionDUnitTest.java 33306d8c7241c061038fc130cbbcec377b34d906
geode-core/src/test/java/com/gemstone/gemfire/internal/BackwardCompatibilitySerializationDUnitTest.java 07f87a3fbccaeab722c8d19ea9803387dc0b6da4
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRCustomPartitioningDUnitTest.java 12a143d9ad362e93457d364c302d062e2c23d4f7
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessageJUnitTest.java e08a26808f13124940faffa994a511562a64729b
geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedDataSerializables.txt d2204a0f5a7673a909a48dc7f846377d0ce88d4d
geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedSerializables.txt 89305acea1887fcf2edba17b91362bbfc53c5703
Diff: https://reviews.apache.org/r/48189/diff/
Testing
-------
precheckin
Thanks,
Darrel Schneider
Re: Review Request 48189: remove sqlf, sql fabric,
gemfirexd from geode-core
Posted by Sai Boorlagadda <sb...@pivotal.io>.
> On June 6, 2016, 5:25 p.m., Sai Boorlagadda wrote:
> > Ship It!
Reviewed pages 5 & 6
- Sai
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48189/#review136315
-----------------------------------------------------------
On June 2, 2016, 10:20 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48189/
> -----------------------------------------------------------
>
> (Updated June 2, 2016, 10:20 p.m.)
>
>
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
>
>
> Bugs: GEODE-1464
> https://issues.apache.org/jira/browse/GEODE-1464
>
>
> Repository: geode
>
>
> Description
> -------
>
> removed internal Delta (only used by sqlf)
> removed sqlfDisconnectListener
> removed getStringForSQLF
> removed sqlfabric.sys-disk-dir system property
> removed unInitializedMembers and deferredVolunteerForPrimary
> removed sqlf serialization code
> removed GemFireUtilLauncher
> removed afterValueOverflow
> removed preferObject, eager deserialize, and KeyWithRegionContext
> removed unused sqlf methods in PartitionedRegion
> removed memberUnInitialized
> removed sqlf from DiskEntry
> removed setCallbackArgument from EntryOperationImpl
> removed distributeUpdatedProfileOnHubCreation
> removed getEntriesInTxForSqlFabric
> removed withRoutingObjects and hasRoutingObjects
> removed resetBucketAdvisorParents
> rebalance no longer calls GemFireCacheImpl.getInstance comments
> removed sqlf log messages
> removed sqlf OffHeapIdentifiers
> removed SqlfSerializationException from sanctionedSerializables
> removed static helper methods from DiskWriteAttributesImpl
> removed contextObject from EntryEventImpl
> remove serializeCallbackArg from WrappedCallbackArgument since it was always true
> removed getLeaderRegionName and getColocatedRegionName
> removed newPutEntryEvent
> removed clearLocalPrimaries
> removed call to non-existent OSProcess$NativeOSCalls
> removed putDML
> removed getClassesToSerializers
> simplified cleanUpOnImcompleteOp
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/IndexUpdater.java facbdf2cecd699361c3cc7782a38ab21d436637e
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionMessage.java bb36b8023b050f17e2d8e742875c736bcabf7755
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java 552dbe3e2aeda91a6dbce7d0f27e07c038f683cc
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ReplyProcessor21.java e5e8cbfb9ab734d93fea991b1d6715b9a7b31a9e
> geode-core/src/main/java/com/gemstone/gemfire/internal/DSCODE.java 8d91c6b7e616e42f0c92da07492c2ade4d8e3e6f
> geode-core/src/main/java/com/gemstone/gemfire/internal/DSFIDFactory.java bd78f5ae78953fab616f2ada870aa1aa920d56f3
> geode-core/src/main/java/com/gemstone/gemfire/internal/DataSerializableFixedID.java 7427f9009dfb732971970a518a2a27adc81c62cd
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireUtilLauncher.java fa19049a8f2e1af70250a7c18abe3d4fa8d27a26
> geode-core/src/main/java/com/gemstone/gemfire/internal/InternalDataSerializer.java bff592b5ac8dc98f7bcd716910ae4c776fadb358
> geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java 515b27dcf0ff38ea5f1024f7ba8b7262172c203a
> geode-core/src/main/java/com/gemstone/gemfire/internal/Version.java 258eaf0e683da7ce4025f5cf388574935dcc3bc4
> geode-core/src/main/java/com/gemstone/gemfire/internal/VersionedDataStream.java a2711ffee9e7575edeff8cd921a3168883ce9ec8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractDiskRegionEntry.java b65b7addc4d572b262b0a0a8a99ee4a79ac0390f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java 25cc818603e5a4f1a0a10f57a2861afb0599bd81
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java 0cbec19408198a5d4fc7f975b43ad4075e29a580
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketAdvisor.java c241c6b7760e0cde59facd7f708c716f563eb2a9
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java e2482bb5592546d280c6f3fb73f7775e9a174afd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheDistributionAdvisor.java 4a34771388da63a648c6d7763fc39334aa716b38
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerLauncher.java d4c19ce6e0d464e90fd62935e00e7a7be72ce659
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CachedDeserializableFactory.java 84e44d84807ae05440edd664d1a4b0ab79bf9ea0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationHelper.java 72edc1076c5480a665bba39af21ee87da7635372
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DestroyOperation.java e26719076eb0c49ae364da951f72fef7bf136a42
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java 54ecb0434298ab6af2af8724a33048732735fc7d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskInitFile.java 7e2333e779db4a46d0fe1f88d7ae61c7831fde5a
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskRegion.java c1d2f038992680e94cc5605ade0ae11bb3796531
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskWriteAttributesImpl.java 914c8781ed979be5903b0818750a88dfe2073451
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistTXState.java cafdb805e97fa1e9c5a35e7efe663f1059a6d429
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistTXStateOnCoordinator.java 33bec1c27d574ee963d488123d8b0ab08b9548ea
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedCacheOperation.java 6a7b4f2f7192613b5f90d46274a0875d7483d074
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedPutAllOperation.java b6aa1b644784639973d3232b6e354937d7bd4ac7
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegion.java cc86e2c9381091e33bd877e42fe4a39677644922
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegionFunctionStreamingMessage.java e51bedd4fc621a416a1a2df8b86c876f33b15bfe
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRemoveAllOperation.java 1d216ce63948d8276295de0559307cfb05c2c01c
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryBits.java f95af608efee479aad2038a501c5dae1183bec63
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java 68c8117b45b2319eca861205a1e9e69602738edf
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryOperationImpl.java d539366476014243dbd77ff825b6e8b0eb93cf5f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 76a27298fba3f6c2b4c6d1d3fdfdfde6216e0797
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GridAdvisor.java fd350a0fffd17637a7484690e545689bf8dcbefd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InitialImageOperation.java b43ba2d510275eeb78530e1b81cb62321c2338cf
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InternalRegionArguments.java f7d46feac4a1f4880c6bd1f91b7aaa5b4ddb5f66
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InvalidateOperation.java 6e1d91e426dc6a78da1cc936bb9cef08f3206a06
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/KeyInfo.java 30f30fcb237f7e5bd665e0c329fc39771a959af1
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/KeyWithRegionContext.java b28a551a6703e9a27fe169eacc39185c0addda74
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ListOfDeltas.java 6592863f286cf66bfd634957343b16833568b03b
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java cc5ac59e9390542f593becd37e332d7b63c350d5
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/Oplog.java 96f616b4a2471bdf4e10d8b3cbcf52df59f58bc0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PRHARedundancyProvider.java 6fe39b1e651b1d435ef95f329bd3558d0dbee1e1
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionAttributesImpl.java d1e2bd0ad27cb46c3c9c23bfd0584bfb0feaa013
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java ea207aea40aad944abd8fce572faed73e03f82e4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegionDataStore.java bda68e38fb6bd4f5f2b286ee23d85f4b8b3a4b26
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ProxyRegionMap.java 74c134b90134ded2a19c02440bb756754c3a019d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/QueuedOperation.java 2d5a69866825da65f77f3203adf69e29dc074c78
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionEntry.java 09aef2a02ae851573a9358f1f62c129dee1a3b00
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionMap.java a7c26073dbbc236e000dffd56024a32e957cb991
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteContainsKeyValueMessage.java acf87238a826760b5802516e3986bf26de9f9167
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteDestroyMessage.java f7109bb9b453beb78d4ac7510b3e7b9628a350f6
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteFetchEntryMessage.java 685f0a5ee6c7adeec16a275b0ebb9af217ee4db3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteFetchVersionMessage.java 12e4de6114ef1bb5f3327f65747b78d838b15f37
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteGetMessage.java b565a2cdc89f23b854fd2690f7265284dfd214dd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteInvalidateMessage.java c4ed1ccefa78de7e02531d1656171a05e224e7e0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutAllMessage.java ff09af9a7fa3b48cc673a64f505265ab3e8154ae
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutMessage.java 27f2bb96424bb588b53080f3a29860910d865cec
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteRemoveAllMessage.java 01e8d9e2341b300bd34d09e4fdcdf2a9bb19e330
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/SearchLoadAndWriteProcessor.java 6642ec61b66f1b5cec22704a3610351dba47909b
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEntry.java 2906ff6e03efb0d491ef1d8abe97dec2ae99f24a
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEntryState.java b6686d42a6ec1fd8a0797a17cc007bf006fb3a99
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRegionLockRequestImpl.java 29af5cc96334648a8a26b619d33da72ff3b82a74
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRegionState.java 116edf71e81f95150975f94f709186e427655b84
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXState.java e610991d12ddbe317f6894b71c27c84e09fc78ba
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXStateInterface.java 3fa935129ed1daefcbd163d34dc90962e4230894
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateAttributesProcessor.java 866eaffce1d20dc88e39f04cf4dd3154ebe78db2
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateEntryVersionOperation.java fce4deea5515bb6e6e9972648d09d15acaec77e8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateOperation.java 730d6d772c85e945050c627831f640d1e1b93ddc
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ValidatingDiskRegion.java 54133cc478a206bc30d7606cd0dfd52e9f7549d8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/WrappedCallbackArgument.java 99a5cebbf7189f22119f3eff2e7ce279d979f8cb
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/delta/Delta.java aeabbd8474ef211d03343058f8ff8e05496b72b4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/AbstractExecution.java ff736be3bcbee7e03d62dc2ddd6795e1c39cfb46
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/FunctionStreamingResultCollector.java 3874ad90f8c92602406e318ce9a43b58fc7bc635
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalExecution.java d3fd2f27ecaadc7fe1495365b4ec7e42aedea88f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalFunctionService.java 8af841d0ade52fa6c58c277bb74a2cc87ea14b72
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalRegionFunctionContext.java 22349256f46487ffb25780a82c8778f9d97418b3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/MemberFunctionExecutor.java ac628a0ff429303f8ab31ee9028605bf95e1b765
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/MultiRegionFunctionExecutor.java 192916997f3ffd1639d7f47880476dfd1c9923ea
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/RegionFunctionContextImpl.java 175e863c2a575626716bbc638749356c49be02a8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/ServerFunctionExecutor.java 9c06bf67b0cdbab53e26de11034cd12b644966e8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/ContainsKeyValueMessage.java 4a9c684a49e6e7715d0d583977ab317aa94c9a60
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/DestroyMessage.java c706a3c7d5c14377587aaa6b336ba08c2382f34f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchBulkEntriesMessage.java ea47e91a53ded0ed03781e8ff83b7e7bd8146fb4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessage.java d27e33e32a113bbead7340c54d8e27c8d6fb3339
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntryMessage.java ae363ba53eebad4911f6b2685f804bae2eca2899
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchKeysMessage.java d7c7d71f4aa50584dc39a0ebeea563dccdd40dc8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/GetMessage.java 3fef79004cbca788fcd6b9368c8b193043210f02
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/InvalidateMessage.java 60508c170afe4fa83a8c46c22706e852bcade1c4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PREntriesIterator.java ec2a8dbf18801ed567172c1a0ec3a3daeb08bf5d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PRUpdateEntryVersionMessage.java e1766dc036e864d5ec77aeb32b09ab4537e70f48
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessage.java 626efefc1921cac2919c56ed415707a426b5ea50
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PutAllPRMessage.java 8aaf587a7f72ca60bb2e4a754592ecf8991e5608
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PutMessage.java a6a39dc902027040e4aa49359915f04c9273bff7
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RegionAdvisor.java 03df3fb122f981864e583b9d698ac2f2a9cdede8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RemoteFetchKeysMessage.java ac95e03830ae386cbce04bf9cdc0091568a90e67
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RemoveAllPRMessage.java fb46e0c85a3785dc7aae251f1ecf04edd0f89e54
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/rebalance/PartitionedRegionLoadModel.java 1cfa4a4927b33540efb3f5b952975e0052daeb76
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/GatewayReceiverCommand.java 448be9247cdf9b36ec75899c999f631eec48db0e
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tx/DistTxEntryEvent.java 6e7c21cbd9546cd812ba131aca0a4686bd98bb08
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySender.java 713023ff42cc91295c7767716d111211fdd367c6
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java 2ef5e19a7ea22f84fb1a7b29e5cbe224aaaaf847
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventCallbackArgument.java f6f8d885ff85450346553d49cbb71a9d2f4c6479
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventImpl.java 09d68f547c816747a5a4692ed389afe470982fe3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java 46ff2636dda03d58d7401b196a75e89094de6171
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/RegionAttributesCreation.java 4dfe6aee4c707fc14b6a4cec1f994db690e3b319
> geode-core/src/main/java/com/gemstone/gemfire/internal/i18n/LocalizedStrings.java d3d232ee71390ddc424b4e78a5f907ea974d7e4b
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/LoggingThreadGroup.java 48c0eac3b0862a835dbf30cf3a872f37a9b07017
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/ManagerLogWriter.java 28419fc2eaa17d0836c4c2bb1c295d1f6e80b1ce
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/PureLogWriter.java 3279bf622b51bed1a36438da39df241d8eb55770
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapHelper.java 0f33d5a7d91d2ae16f6864b55054386b56bd80ca
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImpl.java 571c2d1a9aa1f7fe1ece1fb46e1b691d18de72e7
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/annotations/OffHeapIdentifier.java e275467a67fd51aeee637b65f79f360783562bd5
> geode-core/src/main/java/com/gemstone/gemfire/internal/shared/NativeCalls.java f0fc27aac1c7613142fd6a3394860921cf9fbef3
> geode-core/src/main/java/com/gemstone/gemfire/internal/util/ArrayUtils.java 4f15b17dfe9d38f6de878e42cac043ad1e5101aa
> geode-core/src/main/java/com/gemstone/gemfire/internal/util/concurrent/CustomEntryConcurrentHashMap.java 144c7a3a4d9e840889a9ddcac5821f9e3e1caf60
> geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java e11233770d8fc812706cc29b2e288e6305a2fe7b
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 3a06c1c13745f6d6477ff61176d5986ae29d01d6
> geode-core/src/test/java/com/gemstone/gemfire/disttx/DistributedTransactionDUnitTest.java 33306d8c7241c061038fc130cbbcec377b34d906
> geode-core/src/test/java/com/gemstone/gemfire/internal/BackwardCompatibilitySerializationDUnitTest.java 07f87a3fbccaeab722c8d19ea9803387dc0b6da4
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRCustomPartitioningDUnitTest.java 12a143d9ad362e93457d364c302d062e2c23d4f7
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessageJUnitTest.java e08a26808f13124940faffa994a511562a64729b
> geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedDataSerializables.txt d2204a0f5a7673a909a48dc7f846377d0ce88d4d
> geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedSerializables.txt 89305acea1887fcf2edba17b91362bbfc53c5703
>
> Diff: https://reviews.apache.org/r/48189/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 48189: remove sqlf, sql fabric,
gemfirexd from geode-core
Posted by Sai Boorlagadda <sb...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48189/#review136315
-----------------------------------------------------------
Ship it!
Ship It!
- Sai Boorlagadda
On June 2, 2016, 10:20 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48189/
> -----------------------------------------------------------
>
> (Updated June 2, 2016, 10:20 p.m.)
>
>
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
>
>
> Bugs: GEODE-1464
> https://issues.apache.org/jira/browse/GEODE-1464
>
>
> Repository: geode
>
>
> Description
> -------
>
> removed internal Delta (only used by sqlf)
> removed sqlfDisconnectListener
> removed getStringForSQLF
> removed sqlfabric.sys-disk-dir system property
> removed unInitializedMembers and deferredVolunteerForPrimary
> removed sqlf serialization code
> removed GemFireUtilLauncher
> removed afterValueOverflow
> removed preferObject, eager deserialize, and KeyWithRegionContext
> removed unused sqlf methods in PartitionedRegion
> removed memberUnInitialized
> removed sqlf from DiskEntry
> removed setCallbackArgument from EntryOperationImpl
> removed distributeUpdatedProfileOnHubCreation
> removed getEntriesInTxForSqlFabric
> removed withRoutingObjects and hasRoutingObjects
> removed resetBucketAdvisorParents
> rebalance no longer calls GemFireCacheImpl.getInstance comments
> removed sqlf log messages
> removed sqlf OffHeapIdentifiers
> removed SqlfSerializationException from sanctionedSerializables
> removed static helper methods from DiskWriteAttributesImpl
> removed contextObject from EntryEventImpl
> remove serializeCallbackArg from WrappedCallbackArgument since it was always true
> removed getLeaderRegionName and getColocatedRegionName
> removed newPutEntryEvent
> removed clearLocalPrimaries
> removed call to non-existent OSProcess$NativeOSCalls
> removed putDML
> removed getClassesToSerializers
> simplified cleanUpOnImcompleteOp
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/IndexUpdater.java facbdf2cecd699361c3cc7782a38ab21d436637e
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionMessage.java bb36b8023b050f17e2d8e742875c736bcabf7755
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java 552dbe3e2aeda91a6dbce7d0f27e07c038f683cc
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ReplyProcessor21.java e5e8cbfb9ab734d93fea991b1d6715b9a7b31a9e
> geode-core/src/main/java/com/gemstone/gemfire/internal/DSCODE.java 8d91c6b7e616e42f0c92da07492c2ade4d8e3e6f
> geode-core/src/main/java/com/gemstone/gemfire/internal/DSFIDFactory.java bd78f5ae78953fab616f2ada870aa1aa920d56f3
> geode-core/src/main/java/com/gemstone/gemfire/internal/DataSerializableFixedID.java 7427f9009dfb732971970a518a2a27adc81c62cd
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireUtilLauncher.java fa19049a8f2e1af70250a7c18abe3d4fa8d27a26
> geode-core/src/main/java/com/gemstone/gemfire/internal/InternalDataSerializer.java bff592b5ac8dc98f7bcd716910ae4c776fadb358
> geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java 515b27dcf0ff38ea5f1024f7ba8b7262172c203a
> geode-core/src/main/java/com/gemstone/gemfire/internal/Version.java 258eaf0e683da7ce4025f5cf388574935dcc3bc4
> geode-core/src/main/java/com/gemstone/gemfire/internal/VersionedDataStream.java a2711ffee9e7575edeff8cd921a3168883ce9ec8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractDiskRegionEntry.java b65b7addc4d572b262b0a0a8a99ee4a79ac0390f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java 25cc818603e5a4f1a0a10f57a2861afb0599bd81
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java 0cbec19408198a5d4fc7f975b43ad4075e29a580
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketAdvisor.java c241c6b7760e0cde59facd7f708c716f563eb2a9
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java e2482bb5592546d280c6f3fb73f7775e9a174afd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheDistributionAdvisor.java 4a34771388da63a648c6d7763fc39334aa716b38
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerLauncher.java d4c19ce6e0d464e90fd62935e00e7a7be72ce659
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CachedDeserializableFactory.java 84e44d84807ae05440edd664d1a4b0ab79bf9ea0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationHelper.java 72edc1076c5480a665bba39af21ee87da7635372
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DestroyOperation.java e26719076eb0c49ae364da951f72fef7bf136a42
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java 54ecb0434298ab6af2af8724a33048732735fc7d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskInitFile.java 7e2333e779db4a46d0fe1f88d7ae61c7831fde5a
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskRegion.java c1d2f038992680e94cc5605ade0ae11bb3796531
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskWriteAttributesImpl.java 914c8781ed979be5903b0818750a88dfe2073451
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistTXState.java cafdb805e97fa1e9c5a35e7efe663f1059a6d429
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistTXStateOnCoordinator.java 33bec1c27d574ee963d488123d8b0ab08b9548ea
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedCacheOperation.java 6a7b4f2f7192613b5f90d46274a0875d7483d074
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedPutAllOperation.java b6aa1b644784639973d3232b6e354937d7bd4ac7
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegion.java cc86e2c9381091e33bd877e42fe4a39677644922
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegionFunctionStreamingMessage.java e51bedd4fc621a416a1a2df8b86c876f33b15bfe
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRemoveAllOperation.java 1d216ce63948d8276295de0559307cfb05c2c01c
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryBits.java f95af608efee479aad2038a501c5dae1183bec63
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java 68c8117b45b2319eca861205a1e9e69602738edf
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryOperationImpl.java d539366476014243dbd77ff825b6e8b0eb93cf5f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 76a27298fba3f6c2b4c6d1d3fdfdfde6216e0797
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GridAdvisor.java fd350a0fffd17637a7484690e545689bf8dcbefd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InitialImageOperation.java b43ba2d510275eeb78530e1b81cb62321c2338cf
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InternalRegionArguments.java f7d46feac4a1f4880c6bd1f91b7aaa5b4ddb5f66
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InvalidateOperation.java 6e1d91e426dc6a78da1cc936bb9cef08f3206a06
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/KeyInfo.java 30f30fcb237f7e5bd665e0c329fc39771a959af1
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/KeyWithRegionContext.java b28a551a6703e9a27fe169eacc39185c0addda74
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ListOfDeltas.java 6592863f286cf66bfd634957343b16833568b03b
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java cc5ac59e9390542f593becd37e332d7b63c350d5
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/Oplog.java 96f616b4a2471bdf4e10d8b3cbcf52df59f58bc0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PRHARedundancyProvider.java 6fe39b1e651b1d435ef95f329bd3558d0dbee1e1
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionAttributesImpl.java d1e2bd0ad27cb46c3c9c23bfd0584bfb0feaa013
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java ea207aea40aad944abd8fce572faed73e03f82e4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegionDataStore.java bda68e38fb6bd4f5f2b286ee23d85f4b8b3a4b26
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ProxyRegionMap.java 74c134b90134ded2a19c02440bb756754c3a019d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/QueuedOperation.java 2d5a69866825da65f77f3203adf69e29dc074c78
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionEntry.java 09aef2a02ae851573a9358f1f62c129dee1a3b00
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionMap.java a7c26073dbbc236e000dffd56024a32e957cb991
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteContainsKeyValueMessage.java acf87238a826760b5802516e3986bf26de9f9167
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteDestroyMessage.java f7109bb9b453beb78d4ac7510b3e7b9628a350f6
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteFetchEntryMessage.java 685f0a5ee6c7adeec16a275b0ebb9af217ee4db3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteFetchVersionMessage.java 12e4de6114ef1bb5f3327f65747b78d838b15f37
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteGetMessage.java b565a2cdc89f23b854fd2690f7265284dfd214dd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteInvalidateMessage.java c4ed1ccefa78de7e02531d1656171a05e224e7e0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutAllMessage.java ff09af9a7fa3b48cc673a64f505265ab3e8154ae
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutMessage.java 27f2bb96424bb588b53080f3a29860910d865cec
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteRemoveAllMessage.java 01e8d9e2341b300bd34d09e4fdcdf2a9bb19e330
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/SearchLoadAndWriteProcessor.java 6642ec61b66f1b5cec22704a3610351dba47909b
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEntry.java 2906ff6e03efb0d491ef1d8abe97dec2ae99f24a
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEntryState.java b6686d42a6ec1fd8a0797a17cc007bf006fb3a99
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRegionLockRequestImpl.java 29af5cc96334648a8a26b619d33da72ff3b82a74
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRegionState.java 116edf71e81f95150975f94f709186e427655b84
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXState.java e610991d12ddbe317f6894b71c27c84e09fc78ba
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXStateInterface.java 3fa935129ed1daefcbd163d34dc90962e4230894
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateAttributesProcessor.java 866eaffce1d20dc88e39f04cf4dd3154ebe78db2
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateEntryVersionOperation.java fce4deea5515bb6e6e9972648d09d15acaec77e8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateOperation.java 730d6d772c85e945050c627831f640d1e1b93ddc
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ValidatingDiskRegion.java 54133cc478a206bc30d7606cd0dfd52e9f7549d8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/WrappedCallbackArgument.java 99a5cebbf7189f22119f3eff2e7ce279d979f8cb
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/delta/Delta.java aeabbd8474ef211d03343058f8ff8e05496b72b4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/AbstractExecution.java ff736be3bcbee7e03d62dc2ddd6795e1c39cfb46
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/FunctionStreamingResultCollector.java 3874ad90f8c92602406e318ce9a43b58fc7bc635
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalExecution.java d3fd2f27ecaadc7fe1495365b4ec7e42aedea88f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalFunctionService.java 8af841d0ade52fa6c58c277bb74a2cc87ea14b72
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalRegionFunctionContext.java 22349256f46487ffb25780a82c8778f9d97418b3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/MemberFunctionExecutor.java ac628a0ff429303f8ab31ee9028605bf95e1b765
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/MultiRegionFunctionExecutor.java 192916997f3ffd1639d7f47880476dfd1c9923ea
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/RegionFunctionContextImpl.java 175e863c2a575626716bbc638749356c49be02a8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/ServerFunctionExecutor.java 9c06bf67b0cdbab53e26de11034cd12b644966e8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/ContainsKeyValueMessage.java 4a9c684a49e6e7715d0d583977ab317aa94c9a60
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/DestroyMessage.java c706a3c7d5c14377587aaa6b336ba08c2382f34f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchBulkEntriesMessage.java ea47e91a53ded0ed03781e8ff83b7e7bd8146fb4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessage.java d27e33e32a113bbead7340c54d8e27c8d6fb3339
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntryMessage.java ae363ba53eebad4911f6b2685f804bae2eca2899
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchKeysMessage.java d7c7d71f4aa50584dc39a0ebeea563dccdd40dc8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/GetMessage.java 3fef79004cbca788fcd6b9368c8b193043210f02
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/InvalidateMessage.java 60508c170afe4fa83a8c46c22706e852bcade1c4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PREntriesIterator.java ec2a8dbf18801ed567172c1a0ec3a3daeb08bf5d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PRUpdateEntryVersionMessage.java e1766dc036e864d5ec77aeb32b09ab4537e70f48
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessage.java 626efefc1921cac2919c56ed415707a426b5ea50
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PutAllPRMessage.java 8aaf587a7f72ca60bb2e4a754592ecf8991e5608
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PutMessage.java a6a39dc902027040e4aa49359915f04c9273bff7
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RegionAdvisor.java 03df3fb122f981864e583b9d698ac2f2a9cdede8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RemoteFetchKeysMessage.java ac95e03830ae386cbce04bf9cdc0091568a90e67
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RemoveAllPRMessage.java fb46e0c85a3785dc7aae251f1ecf04edd0f89e54
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/rebalance/PartitionedRegionLoadModel.java 1cfa4a4927b33540efb3f5b952975e0052daeb76
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/GatewayReceiverCommand.java 448be9247cdf9b36ec75899c999f631eec48db0e
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tx/DistTxEntryEvent.java 6e7c21cbd9546cd812ba131aca0a4686bd98bb08
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySender.java 713023ff42cc91295c7767716d111211fdd367c6
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java 2ef5e19a7ea22f84fb1a7b29e5cbe224aaaaf847
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventCallbackArgument.java f6f8d885ff85450346553d49cbb71a9d2f4c6479
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventImpl.java 09d68f547c816747a5a4692ed389afe470982fe3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java 46ff2636dda03d58d7401b196a75e89094de6171
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/RegionAttributesCreation.java 4dfe6aee4c707fc14b6a4cec1f994db690e3b319
> geode-core/src/main/java/com/gemstone/gemfire/internal/i18n/LocalizedStrings.java d3d232ee71390ddc424b4e78a5f907ea974d7e4b
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/LoggingThreadGroup.java 48c0eac3b0862a835dbf30cf3a872f37a9b07017
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/ManagerLogWriter.java 28419fc2eaa17d0836c4c2bb1c295d1f6e80b1ce
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/PureLogWriter.java 3279bf622b51bed1a36438da39df241d8eb55770
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapHelper.java 0f33d5a7d91d2ae16f6864b55054386b56bd80ca
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImpl.java 571c2d1a9aa1f7fe1ece1fb46e1b691d18de72e7
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/annotations/OffHeapIdentifier.java e275467a67fd51aeee637b65f79f360783562bd5
> geode-core/src/main/java/com/gemstone/gemfire/internal/shared/NativeCalls.java f0fc27aac1c7613142fd6a3394860921cf9fbef3
> geode-core/src/main/java/com/gemstone/gemfire/internal/util/ArrayUtils.java 4f15b17dfe9d38f6de878e42cac043ad1e5101aa
> geode-core/src/main/java/com/gemstone/gemfire/internal/util/concurrent/CustomEntryConcurrentHashMap.java 144c7a3a4d9e840889a9ddcac5821f9e3e1caf60
> geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java e11233770d8fc812706cc29b2e288e6305a2fe7b
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 3a06c1c13745f6d6477ff61176d5986ae29d01d6
> geode-core/src/test/java/com/gemstone/gemfire/disttx/DistributedTransactionDUnitTest.java 33306d8c7241c061038fc130cbbcec377b34d906
> geode-core/src/test/java/com/gemstone/gemfire/internal/BackwardCompatibilitySerializationDUnitTest.java 07f87a3fbccaeab722c8d19ea9803387dc0b6da4
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRCustomPartitioningDUnitTest.java 12a143d9ad362e93457d364c302d062e2c23d4f7
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessageJUnitTest.java e08a26808f13124940faffa994a511562a64729b
> geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedDataSerializables.txt d2204a0f5a7673a909a48dc7f846377d0ce88d4d
> geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedSerializables.txt 89305acea1887fcf2edba17b91362bbfc53c5703
>
> Diff: https://reviews.apache.org/r/48189/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 48189: remove sqlf, sql fabric,
gemfirexd from geode-core
Posted by Sai Boorlagadda <sb...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48189/#review136309
-----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PREntriesIterator.java (line 25)
<https://reviews.apache.org/r/48189/#comment201338>
Alteast one 'the' can be removed or both as in "This interface provides bucket ID..."
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java (line 570)
<https://reviews.apache.org/r/48189/#comment201334>
The statement prQ.shadowPRWaitForBucketRecovery does not need to be wrapped with "{" & "}"?
- Sai Boorlagadda
On June 2, 2016, 10:20 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48189/
> -----------------------------------------------------------
>
> (Updated June 2, 2016, 10:20 p.m.)
>
>
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
>
>
> Bugs: GEODE-1464
> https://issues.apache.org/jira/browse/GEODE-1464
>
>
> Repository: geode
>
>
> Description
> -------
>
> removed internal Delta (only used by sqlf)
> removed sqlfDisconnectListener
> removed getStringForSQLF
> removed sqlfabric.sys-disk-dir system property
> removed unInitializedMembers and deferredVolunteerForPrimary
> removed sqlf serialization code
> removed GemFireUtilLauncher
> removed afterValueOverflow
> removed preferObject, eager deserialize, and KeyWithRegionContext
> removed unused sqlf methods in PartitionedRegion
> removed memberUnInitialized
> removed sqlf from DiskEntry
> removed setCallbackArgument from EntryOperationImpl
> removed distributeUpdatedProfileOnHubCreation
> removed getEntriesInTxForSqlFabric
> removed withRoutingObjects and hasRoutingObjects
> removed resetBucketAdvisorParents
> rebalance no longer calls GemFireCacheImpl.getInstance comments
> removed sqlf log messages
> removed sqlf OffHeapIdentifiers
> removed SqlfSerializationException from sanctionedSerializables
> removed static helper methods from DiskWriteAttributesImpl
> removed contextObject from EntryEventImpl
> remove serializeCallbackArg from WrappedCallbackArgument since it was always true
> removed getLeaderRegionName and getColocatedRegionName
> removed newPutEntryEvent
> removed clearLocalPrimaries
> removed call to non-existent OSProcess$NativeOSCalls
> removed putDML
> removed getClassesToSerializers
> simplified cleanUpOnImcompleteOp
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/IndexUpdater.java facbdf2cecd699361c3cc7782a38ab21d436637e
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionMessage.java bb36b8023b050f17e2d8e742875c736bcabf7755
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java 552dbe3e2aeda91a6dbce7d0f27e07c038f683cc
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ReplyProcessor21.java e5e8cbfb9ab734d93fea991b1d6715b9a7b31a9e
> geode-core/src/main/java/com/gemstone/gemfire/internal/DSCODE.java 8d91c6b7e616e42f0c92da07492c2ade4d8e3e6f
> geode-core/src/main/java/com/gemstone/gemfire/internal/DSFIDFactory.java bd78f5ae78953fab616f2ada870aa1aa920d56f3
> geode-core/src/main/java/com/gemstone/gemfire/internal/DataSerializableFixedID.java 7427f9009dfb732971970a518a2a27adc81c62cd
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireUtilLauncher.java fa19049a8f2e1af70250a7c18abe3d4fa8d27a26
> geode-core/src/main/java/com/gemstone/gemfire/internal/InternalDataSerializer.java bff592b5ac8dc98f7bcd716910ae4c776fadb358
> geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java 515b27dcf0ff38ea5f1024f7ba8b7262172c203a
> geode-core/src/main/java/com/gemstone/gemfire/internal/Version.java 258eaf0e683da7ce4025f5cf388574935dcc3bc4
> geode-core/src/main/java/com/gemstone/gemfire/internal/VersionedDataStream.java a2711ffee9e7575edeff8cd921a3168883ce9ec8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractDiskRegionEntry.java b65b7addc4d572b262b0a0a8a99ee4a79ac0390f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java 25cc818603e5a4f1a0a10f57a2861afb0599bd81
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java 0cbec19408198a5d4fc7f975b43ad4075e29a580
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketAdvisor.java c241c6b7760e0cde59facd7f708c716f563eb2a9
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java e2482bb5592546d280c6f3fb73f7775e9a174afd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheDistributionAdvisor.java 4a34771388da63a648c6d7763fc39334aa716b38
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerLauncher.java d4c19ce6e0d464e90fd62935e00e7a7be72ce659
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CachedDeserializableFactory.java 84e44d84807ae05440edd664d1a4b0ab79bf9ea0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationHelper.java 72edc1076c5480a665bba39af21ee87da7635372
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DestroyOperation.java e26719076eb0c49ae364da951f72fef7bf136a42
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java 54ecb0434298ab6af2af8724a33048732735fc7d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskInitFile.java 7e2333e779db4a46d0fe1f88d7ae61c7831fde5a
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskRegion.java c1d2f038992680e94cc5605ade0ae11bb3796531
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskWriteAttributesImpl.java 914c8781ed979be5903b0818750a88dfe2073451
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistTXState.java cafdb805e97fa1e9c5a35e7efe663f1059a6d429
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistTXStateOnCoordinator.java 33bec1c27d574ee963d488123d8b0ab08b9548ea
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedCacheOperation.java 6a7b4f2f7192613b5f90d46274a0875d7483d074
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedPutAllOperation.java b6aa1b644784639973d3232b6e354937d7bd4ac7
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegion.java cc86e2c9381091e33bd877e42fe4a39677644922
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegionFunctionStreamingMessage.java e51bedd4fc621a416a1a2df8b86c876f33b15bfe
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRemoveAllOperation.java 1d216ce63948d8276295de0559307cfb05c2c01c
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryBits.java f95af608efee479aad2038a501c5dae1183bec63
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java 68c8117b45b2319eca861205a1e9e69602738edf
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryOperationImpl.java d539366476014243dbd77ff825b6e8b0eb93cf5f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 76a27298fba3f6c2b4c6d1d3fdfdfde6216e0797
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GridAdvisor.java fd350a0fffd17637a7484690e545689bf8dcbefd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InitialImageOperation.java b43ba2d510275eeb78530e1b81cb62321c2338cf
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InternalRegionArguments.java f7d46feac4a1f4880c6bd1f91b7aaa5b4ddb5f66
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InvalidateOperation.java 6e1d91e426dc6a78da1cc936bb9cef08f3206a06
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/KeyInfo.java 30f30fcb237f7e5bd665e0c329fc39771a959af1
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/KeyWithRegionContext.java b28a551a6703e9a27fe169eacc39185c0addda74
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ListOfDeltas.java 6592863f286cf66bfd634957343b16833568b03b
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java cc5ac59e9390542f593becd37e332d7b63c350d5
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/Oplog.java 96f616b4a2471bdf4e10d8b3cbcf52df59f58bc0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PRHARedundancyProvider.java 6fe39b1e651b1d435ef95f329bd3558d0dbee1e1
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionAttributesImpl.java d1e2bd0ad27cb46c3c9c23bfd0584bfb0feaa013
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java ea207aea40aad944abd8fce572faed73e03f82e4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegionDataStore.java bda68e38fb6bd4f5f2b286ee23d85f4b8b3a4b26
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ProxyRegionMap.java 74c134b90134ded2a19c02440bb756754c3a019d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/QueuedOperation.java 2d5a69866825da65f77f3203adf69e29dc074c78
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionEntry.java 09aef2a02ae851573a9358f1f62c129dee1a3b00
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionMap.java a7c26073dbbc236e000dffd56024a32e957cb991
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteContainsKeyValueMessage.java acf87238a826760b5802516e3986bf26de9f9167
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteDestroyMessage.java f7109bb9b453beb78d4ac7510b3e7b9628a350f6
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteFetchEntryMessage.java 685f0a5ee6c7adeec16a275b0ebb9af217ee4db3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteFetchVersionMessage.java 12e4de6114ef1bb5f3327f65747b78d838b15f37
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteGetMessage.java b565a2cdc89f23b854fd2690f7265284dfd214dd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteInvalidateMessage.java c4ed1ccefa78de7e02531d1656171a05e224e7e0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutAllMessage.java ff09af9a7fa3b48cc673a64f505265ab3e8154ae
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutMessage.java 27f2bb96424bb588b53080f3a29860910d865cec
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteRemoveAllMessage.java 01e8d9e2341b300bd34d09e4fdcdf2a9bb19e330
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/SearchLoadAndWriteProcessor.java 6642ec61b66f1b5cec22704a3610351dba47909b
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEntry.java 2906ff6e03efb0d491ef1d8abe97dec2ae99f24a
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEntryState.java b6686d42a6ec1fd8a0797a17cc007bf006fb3a99
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRegionLockRequestImpl.java 29af5cc96334648a8a26b619d33da72ff3b82a74
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRegionState.java 116edf71e81f95150975f94f709186e427655b84
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXState.java e610991d12ddbe317f6894b71c27c84e09fc78ba
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXStateInterface.java 3fa935129ed1daefcbd163d34dc90962e4230894
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateAttributesProcessor.java 866eaffce1d20dc88e39f04cf4dd3154ebe78db2
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateEntryVersionOperation.java fce4deea5515bb6e6e9972648d09d15acaec77e8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateOperation.java 730d6d772c85e945050c627831f640d1e1b93ddc
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ValidatingDiskRegion.java 54133cc478a206bc30d7606cd0dfd52e9f7549d8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/WrappedCallbackArgument.java 99a5cebbf7189f22119f3eff2e7ce279d979f8cb
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/delta/Delta.java aeabbd8474ef211d03343058f8ff8e05496b72b4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/AbstractExecution.java ff736be3bcbee7e03d62dc2ddd6795e1c39cfb46
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/FunctionStreamingResultCollector.java 3874ad90f8c92602406e318ce9a43b58fc7bc635
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalExecution.java d3fd2f27ecaadc7fe1495365b4ec7e42aedea88f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalFunctionService.java 8af841d0ade52fa6c58c277bb74a2cc87ea14b72
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalRegionFunctionContext.java 22349256f46487ffb25780a82c8778f9d97418b3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/MemberFunctionExecutor.java ac628a0ff429303f8ab31ee9028605bf95e1b765
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/MultiRegionFunctionExecutor.java 192916997f3ffd1639d7f47880476dfd1c9923ea
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/RegionFunctionContextImpl.java 175e863c2a575626716bbc638749356c49be02a8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/ServerFunctionExecutor.java 9c06bf67b0cdbab53e26de11034cd12b644966e8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/ContainsKeyValueMessage.java 4a9c684a49e6e7715d0d583977ab317aa94c9a60
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/DestroyMessage.java c706a3c7d5c14377587aaa6b336ba08c2382f34f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchBulkEntriesMessage.java ea47e91a53ded0ed03781e8ff83b7e7bd8146fb4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessage.java d27e33e32a113bbead7340c54d8e27c8d6fb3339
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntryMessage.java ae363ba53eebad4911f6b2685f804bae2eca2899
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchKeysMessage.java d7c7d71f4aa50584dc39a0ebeea563dccdd40dc8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/GetMessage.java 3fef79004cbca788fcd6b9368c8b193043210f02
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/InvalidateMessage.java 60508c170afe4fa83a8c46c22706e852bcade1c4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PREntriesIterator.java ec2a8dbf18801ed567172c1a0ec3a3daeb08bf5d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PRUpdateEntryVersionMessage.java e1766dc036e864d5ec77aeb32b09ab4537e70f48
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessage.java 626efefc1921cac2919c56ed415707a426b5ea50
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PutAllPRMessage.java 8aaf587a7f72ca60bb2e4a754592ecf8991e5608
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PutMessage.java a6a39dc902027040e4aa49359915f04c9273bff7
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RegionAdvisor.java 03df3fb122f981864e583b9d698ac2f2a9cdede8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RemoteFetchKeysMessage.java ac95e03830ae386cbce04bf9cdc0091568a90e67
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RemoveAllPRMessage.java fb46e0c85a3785dc7aae251f1ecf04edd0f89e54
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/rebalance/PartitionedRegionLoadModel.java 1cfa4a4927b33540efb3f5b952975e0052daeb76
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/GatewayReceiverCommand.java 448be9247cdf9b36ec75899c999f631eec48db0e
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tx/DistTxEntryEvent.java 6e7c21cbd9546cd812ba131aca0a4686bd98bb08
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySender.java 713023ff42cc91295c7767716d111211fdd367c6
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java 2ef5e19a7ea22f84fb1a7b29e5cbe224aaaaf847
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventCallbackArgument.java f6f8d885ff85450346553d49cbb71a9d2f4c6479
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventImpl.java 09d68f547c816747a5a4692ed389afe470982fe3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java 46ff2636dda03d58d7401b196a75e89094de6171
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/RegionAttributesCreation.java 4dfe6aee4c707fc14b6a4cec1f994db690e3b319
> geode-core/src/main/java/com/gemstone/gemfire/internal/i18n/LocalizedStrings.java d3d232ee71390ddc424b4e78a5f907ea974d7e4b
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/LoggingThreadGroup.java 48c0eac3b0862a835dbf30cf3a872f37a9b07017
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/ManagerLogWriter.java 28419fc2eaa17d0836c4c2bb1c295d1f6e80b1ce
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/PureLogWriter.java 3279bf622b51bed1a36438da39df241d8eb55770
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapHelper.java 0f33d5a7d91d2ae16f6864b55054386b56bd80ca
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImpl.java 571c2d1a9aa1f7fe1ece1fb46e1b691d18de72e7
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/annotations/OffHeapIdentifier.java e275467a67fd51aeee637b65f79f360783562bd5
> geode-core/src/main/java/com/gemstone/gemfire/internal/shared/NativeCalls.java f0fc27aac1c7613142fd6a3394860921cf9fbef3
> geode-core/src/main/java/com/gemstone/gemfire/internal/util/ArrayUtils.java 4f15b17dfe9d38f6de878e42cac043ad1e5101aa
> geode-core/src/main/java/com/gemstone/gemfire/internal/util/concurrent/CustomEntryConcurrentHashMap.java 144c7a3a4d9e840889a9ddcac5821f9e3e1caf60
> geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java e11233770d8fc812706cc29b2e288e6305a2fe7b
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 3a06c1c13745f6d6477ff61176d5986ae29d01d6
> geode-core/src/test/java/com/gemstone/gemfire/disttx/DistributedTransactionDUnitTest.java 33306d8c7241c061038fc130cbbcec377b34d906
> geode-core/src/test/java/com/gemstone/gemfire/internal/BackwardCompatibilitySerializationDUnitTest.java 07f87a3fbccaeab722c8d19ea9803387dc0b6da4
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRCustomPartitioningDUnitTest.java 12a143d9ad362e93457d364c302d062e2c23d4f7
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessageJUnitTest.java e08a26808f13124940faffa994a511562a64729b
> geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedDataSerializables.txt d2204a0f5a7673a909a48dc7f846377d0ce88d4d
> geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedSerializables.txt 89305acea1887fcf2edba17b91362bbfc53c5703
>
> Diff: https://reviews.apache.org/r/48189/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 48189: remove sqlf, sql fabric,
gemfirexd from geode-core
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48189/#review136322
-----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PREntriesIterator.java (line 25)
<https://reviews.apache.org/r/48189/#comment201340>
removed the extra the
- Darrel Schneider
On June 2, 2016, 3:20 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48189/
> -----------------------------------------------------------
>
> (Updated June 2, 2016, 3:20 p.m.)
>
>
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
>
>
> Bugs: GEODE-1464
> https://issues.apache.org/jira/browse/GEODE-1464
>
>
> Repository: geode
>
>
> Description
> -------
>
> removed internal Delta (only used by sqlf)
> removed sqlfDisconnectListener
> removed getStringForSQLF
> removed sqlfabric.sys-disk-dir system property
> removed unInitializedMembers and deferredVolunteerForPrimary
> removed sqlf serialization code
> removed GemFireUtilLauncher
> removed afterValueOverflow
> removed preferObject, eager deserialize, and KeyWithRegionContext
> removed unused sqlf methods in PartitionedRegion
> removed memberUnInitialized
> removed sqlf from DiskEntry
> removed setCallbackArgument from EntryOperationImpl
> removed distributeUpdatedProfileOnHubCreation
> removed getEntriesInTxForSqlFabric
> removed withRoutingObjects and hasRoutingObjects
> removed resetBucketAdvisorParents
> rebalance no longer calls GemFireCacheImpl.getInstance comments
> removed sqlf log messages
> removed sqlf OffHeapIdentifiers
> removed SqlfSerializationException from sanctionedSerializables
> removed static helper methods from DiskWriteAttributesImpl
> removed contextObject from EntryEventImpl
> remove serializeCallbackArg from WrappedCallbackArgument since it was always true
> removed getLeaderRegionName and getColocatedRegionName
> removed newPutEntryEvent
> removed clearLocalPrimaries
> removed call to non-existent OSProcess$NativeOSCalls
> removed putDML
> removed getClassesToSerializers
> simplified cleanUpOnImcompleteOp
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/IndexUpdater.java facbdf2cecd699361c3cc7782a38ab21d436637e
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionMessage.java bb36b8023b050f17e2d8e742875c736bcabf7755
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java 552dbe3e2aeda91a6dbce7d0f27e07c038f683cc
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ReplyProcessor21.java e5e8cbfb9ab734d93fea991b1d6715b9a7b31a9e
> geode-core/src/main/java/com/gemstone/gemfire/internal/DSCODE.java 8d91c6b7e616e42f0c92da07492c2ade4d8e3e6f
> geode-core/src/main/java/com/gemstone/gemfire/internal/DSFIDFactory.java bd78f5ae78953fab616f2ada870aa1aa920d56f3
> geode-core/src/main/java/com/gemstone/gemfire/internal/DataSerializableFixedID.java 7427f9009dfb732971970a518a2a27adc81c62cd
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireUtilLauncher.java fa19049a8f2e1af70250a7c18abe3d4fa8d27a26
> geode-core/src/main/java/com/gemstone/gemfire/internal/InternalDataSerializer.java bff592b5ac8dc98f7bcd716910ae4c776fadb358
> geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java 515b27dcf0ff38ea5f1024f7ba8b7262172c203a
> geode-core/src/main/java/com/gemstone/gemfire/internal/Version.java 258eaf0e683da7ce4025f5cf388574935dcc3bc4
> geode-core/src/main/java/com/gemstone/gemfire/internal/VersionedDataStream.java a2711ffee9e7575edeff8cd921a3168883ce9ec8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractDiskRegionEntry.java b65b7addc4d572b262b0a0a8a99ee4a79ac0390f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java 25cc818603e5a4f1a0a10f57a2861afb0599bd81
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java 0cbec19408198a5d4fc7f975b43ad4075e29a580
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketAdvisor.java c241c6b7760e0cde59facd7f708c716f563eb2a9
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java e2482bb5592546d280c6f3fb73f7775e9a174afd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheDistributionAdvisor.java 4a34771388da63a648c6d7763fc39334aa716b38
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerLauncher.java d4c19ce6e0d464e90fd62935e00e7a7be72ce659
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CachedDeserializableFactory.java 84e44d84807ae05440edd664d1a4b0ab79bf9ea0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationHelper.java 72edc1076c5480a665bba39af21ee87da7635372
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DestroyOperation.java e26719076eb0c49ae364da951f72fef7bf136a42
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java 54ecb0434298ab6af2af8724a33048732735fc7d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskInitFile.java 7e2333e779db4a46d0fe1f88d7ae61c7831fde5a
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskRegion.java c1d2f038992680e94cc5605ade0ae11bb3796531
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskWriteAttributesImpl.java 914c8781ed979be5903b0818750a88dfe2073451
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistTXState.java cafdb805e97fa1e9c5a35e7efe663f1059a6d429
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistTXStateOnCoordinator.java 33bec1c27d574ee963d488123d8b0ab08b9548ea
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedCacheOperation.java 6a7b4f2f7192613b5f90d46274a0875d7483d074
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedPutAllOperation.java b6aa1b644784639973d3232b6e354937d7bd4ac7
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegion.java cc86e2c9381091e33bd877e42fe4a39677644922
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegionFunctionStreamingMessage.java e51bedd4fc621a416a1a2df8b86c876f33b15bfe
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRemoveAllOperation.java 1d216ce63948d8276295de0559307cfb05c2c01c
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryBits.java f95af608efee479aad2038a501c5dae1183bec63
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java 68c8117b45b2319eca861205a1e9e69602738edf
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryOperationImpl.java d539366476014243dbd77ff825b6e8b0eb93cf5f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 76a27298fba3f6c2b4c6d1d3fdfdfde6216e0797
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GridAdvisor.java fd350a0fffd17637a7484690e545689bf8dcbefd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InitialImageOperation.java b43ba2d510275eeb78530e1b81cb62321c2338cf
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InternalRegionArguments.java f7d46feac4a1f4880c6bd1f91b7aaa5b4ddb5f66
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InvalidateOperation.java 6e1d91e426dc6a78da1cc936bb9cef08f3206a06
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/KeyInfo.java 30f30fcb237f7e5bd665e0c329fc39771a959af1
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/KeyWithRegionContext.java b28a551a6703e9a27fe169eacc39185c0addda74
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ListOfDeltas.java 6592863f286cf66bfd634957343b16833568b03b
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java cc5ac59e9390542f593becd37e332d7b63c350d5
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/Oplog.java 96f616b4a2471bdf4e10d8b3cbcf52df59f58bc0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PRHARedundancyProvider.java 6fe39b1e651b1d435ef95f329bd3558d0dbee1e1
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionAttributesImpl.java d1e2bd0ad27cb46c3c9c23bfd0584bfb0feaa013
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java ea207aea40aad944abd8fce572faed73e03f82e4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegionDataStore.java bda68e38fb6bd4f5f2b286ee23d85f4b8b3a4b26
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ProxyRegionMap.java 74c134b90134ded2a19c02440bb756754c3a019d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/QueuedOperation.java 2d5a69866825da65f77f3203adf69e29dc074c78
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionEntry.java 09aef2a02ae851573a9358f1f62c129dee1a3b00
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionMap.java a7c26073dbbc236e000dffd56024a32e957cb991
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteContainsKeyValueMessage.java acf87238a826760b5802516e3986bf26de9f9167
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteDestroyMessage.java f7109bb9b453beb78d4ac7510b3e7b9628a350f6
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteFetchEntryMessage.java 685f0a5ee6c7adeec16a275b0ebb9af217ee4db3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteFetchVersionMessage.java 12e4de6114ef1bb5f3327f65747b78d838b15f37
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteGetMessage.java b565a2cdc89f23b854fd2690f7265284dfd214dd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteInvalidateMessage.java c4ed1ccefa78de7e02531d1656171a05e224e7e0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutAllMessage.java ff09af9a7fa3b48cc673a64f505265ab3e8154ae
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutMessage.java 27f2bb96424bb588b53080f3a29860910d865cec
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteRemoveAllMessage.java 01e8d9e2341b300bd34d09e4fdcdf2a9bb19e330
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/SearchLoadAndWriteProcessor.java 6642ec61b66f1b5cec22704a3610351dba47909b
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEntry.java 2906ff6e03efb0d491ef1d8abe97dec2ae99f24a
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEntryState.java b6686d42a6ec1fd8a0797a17cc007bf006fb3a99
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRegionLockRequestImpl.java 29af5cc96334648a8a26b619d33da72ff3b82a74
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRegionState.java 116edf71e81f95150975f94f709186e427655b84
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXState.java e610991d12ddbe317f6894b71c27c84e09fc78ba
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXStateInterface.java 3fa935129ed1daefcbd163d34dc90962e4230894
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateAttributesProcessor.java 866eaffce1d20dc88e39f04cf4dd3154ebe78db2
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateEntryVersionOperation.java fce4deea5515bb6e6e9972648d09d15acaec77e8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateOperation.java 730d6d772c85e945050c627831f640d1e1b93ddc
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ValidatingDiskRegion.java 54133cc478a206bc30d7606cd0dfd52e9f7549d8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/WrappedCallbackArgument.java 99a5cebbf7189f22119f3eff2e7ce279d979f8cb
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/delta/Delta.java aeabbd8474ef211d03343058f8ff8e05496b72b4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/AbstractExecution.java ff736be3bcbee7e03d62dc2ddd6795e1c39cfb46
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/FunctionStreamingResultCollector.java 3874ad90f8c92602406e318ce9a43b58fc7bc635
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalExecution.java d3fd2f27ecaadc7fe1495365b4ec7e42aedea88f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalFunctionService.java 8af841d0ade52fa6c58c277bb74a2cc87ea14b72
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalRegionFunctionContext.java 22349256f46487ffb25780a82c8778f9d97418b3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/MemberFunctionExecutor.java ac628a0ff429303f8ab31ee9028605bf95e1b765
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/MultiRegionFunctionExecutor.java 192916997f3ffd1639d7f47880476dfd1c9923ea
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/RegionFunctionContextImpl.java 175e863c2a575626716bbc638749356c49be02a8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/ServerFunctionExecutor.java 9c06bf67b0cdbab53e26de11034cd12b644966e8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/ContainsKeyValueMessage.java 4a9c684a49e6e7715d0d583977ab317aa94c9a60
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/DestroyMessage.java c706a3c7d5c14377587aaa6b336ba08c2382f34f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchBulkEntriesMessage.java ea47e91a53ded0ed03781e8ff83b7e7bd8146fb4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessage.java d27e33e32a113bbead7340c54d8e27c8d6fb3339
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntryMessage.java ae363ba53eebad4911f6b2685f804bae2eca2899
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchKeysMessage.java d7c7d71f4aa50584dc39a0ebeea563dccdd40dc8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/GetMessage.java 3fef79004cbca788fcd6b9368c8b193043210f02
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/InvalidateMessage.java 60508c170afe4fa83a8c46c22706e852bcade1c4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PREntriesIterator.java ec2a8dbf18801ed567172c1a0ec3a3daeb08bf5d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PRUpdateEntryVersionMessage.java e1766dc036e864d5ec77aeb32b09ab4537e70f48
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessage.java 626efefc1921cac2919c56ed415707a426b5ea50
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PutAllPRMessage.java 8aaf587a7f72ca60bb2e4a754592ecf8991e5608
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PutMessage.java a6a39dc902027040e4aa49359915f04c9273bff7
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RegionAdvisor.java 03df3fb122f981864e583b9d698ac2f2a9cdede8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RemoteFetchKeysMessage.java ac95e03830ae386cbce04bf9cdc0091568a90e67
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RemoveAllPRMessage.java fb46e0c85a3785dc7aae251f1ecf04edd0f89e54
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/rebalance/PartitionedRegionLoadModel.java 1cfa4a4927b33540efb3f5b952975e0052daeb76
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/GatewayReceiverCommand.java 448be9247cdf9b36ec75899c999f631eec48db0e
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tx/DistTxEntryEvent.java 6e7c21cbd9546cd812ba131aca0a4686bd98bb08
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySender.java 713023ff42cc91295c7767716d111211fdd367c6
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java 2ef5e19a7ea22f84fb1a7b29e5cbe224aaaaf847
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventCallbackArgument.java f6f8d885ff85450346553d49cbb71a9d2f4c6479
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventImpl.java 09d68f547c816747a5a4692ed389afe470982fe3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java 46ff2636dda03d58d7401b196a75e89094de6171
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/RegionAttributesCreation.java 4dfe6aee4c707fc14b6a4cec1f994db690e3b319
> geode-core/src/main/java/com/gemstone/gemfire/internal/i18n/LocalizedStrings.java d3d232ee71390ddc424b4e78a5f907ea974d7e4b
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/LoggingThreadGroup.java 48c0eac3b0862a835dbf30cf3a872f37a9b07017
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/ManagerLogWriter.java 28419fc2eaa17d0836c4c2bb1c295d1f6e80b1ce
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/PureLogWriter.java 3279bf622b51bed1a36438da39df241d8eb55770
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapHelper.java 0f33d5a7d91d2ae16f6864b55054386b56bd80ca
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImpl.java 571c2d1a9aa1f7fe1ece1fb46e1b691d18de72e7
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/annotations/OffHeapIdentifier.java e275467a67fd51aeee637b65f79f360783562bd5
> geode-core/src/main/java/com/gemstone/gemfire/internal/shared/NativeCalls.java f0fc27aac1c7613142fd6a3394860921cf9fbef3
> geode-core/src/main/java/com/gemstone/gemfire/internal/util/ArrayUtils.java 4f15b17dfe9d38f6de878e42cac043ad1e5101aa
> geode-core/src/main/java/com/gemstone/gemfire/internal/util/concurrent/CustomEntryConcurrentHashMap.java 144c7a3a4d9e840889a9ddcac5821f9e3e1caf60
> geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java e11233770d8fc812706cc29b2e288e6305a2fe7b
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 3a06c1c13745f6d6477ff61176d5986ae29d01d6
> geode-core/src/test/java/com/gemstone/gemfire/disttx/DistributedTransactionDUnitTest.java 33306d8c7241c061038fc130cbbcec377b34d906
> geode-core/src/test/java/com/gemstone/gemfire/internal/BackwardCompatibilitySerializationDUnitTest.java 07f87a3fbccaeab722c8d19ea9803387dc0b6da4
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRCustomPartitioningDUnitTest.java 12a143d9ad362e93457d364c302d062e2c23d4f7
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessageJUnitTest.java e08a26808f13124940faffa994a511562a64729b
> geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedDataSerializables.txt d2204a0f5a7673a909a48dc7f846377d0ce88d4d
> geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedSerializables.txt 89305acea1887fcf2edba17b91362bbfc53c5703
>
> Diff: https://reviews.apache.org/r/48189/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 48189: remove sqlf, sql fabric,
gemfirexd from geode-core
Posted by Ken Howe <kh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48189/#review136370
-----------------------------------------------------------
Ship it!
Reviewed pages 1 & 2 of the diffs.
- Ken Howe
On June 2, 2016, 10:20 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48189/
> -----------------------------------------------------------
>
> (Updated June 2, 2016, 10:20 p.m.)
>
>
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
>
>
> Bugs: GEODE-1464
> https://issues.apache.org/jira/browse/GEODE-1464
>
>
> Repository: geode
>
>
> Description
> -------
>
> removed internal Delta (only used by sqlf)
> removed sqlfDisconnectListener
> removed getStringForSQLF
> removed sqlfabric.sys-disk-dir system property
> removed unInitializedMembers and deferredVolunteerForPrimary
> removed sqlf serialization code
> removed GemFireUtilLauncher
> removed afterValueOverflow
> removed preferObject, eager deserialize, and KeyWithRegionContext
> removed unused sqlf methods in PartitionedRegion
> removed memberUnInitialized
> removed sqlf from DiskEntry
> removed setCallbackArgument from EntryOperationImpl
> removed distributeUpdatedProfileOnHubCreation
> removed getEntriesInTxForSqlFabric
> removed withRoutingObjects and hasRoutingObjects
> removed resetBucketAdvisorParents
> rebalance no longer calls GemFireCacheImpl.getInstance comments
> removed sqlf log messages
> removed sqlf OffHeapIdentifiers
> removed SqlfSerializationException from sanctionedSerializables
> removed static helper methods from DiskWriteAttributesImpl
> removed contextObject from EntryEventImpl
> remove serializeCallbackArg from WrappedCallbackArgument since it was always true
> removed getLeaderRegionName and getColocatedRegionName
> removed newPutEntryEvent
> removed clearLocalPrimaries
> removed call to non-existent OSProcess$NativeOSCalls
> removed putDML
> removed getClassesToSerializers
> simplified cleanUpOnImcompleteOp
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/IndexUpdater.java facbdf2cecd699361c3cc7782a38ab21d436637e
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionMessage.java bb36b8023b050f17e2d8e742875c736bcabf7755
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java 552dbe3e2aeda91a6dbce7d0f27e07c038f683cc
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ReplyProcessor21.java e5e8cbfb9ab734d93fea991b1d6715b9a7b31a9e
> geode-core/src/main/java/com/gemstone/gemfire/internal/DSCODE.java 8d91c6b7e616e42f0c92da07492c2ade4d8e3e6f
> geode-core/src/main/java/com/gemstone/gemfire/internal/DSFIDFactory.java bd78f5ae78953fab616f2ada870aa1aa920d56f3
> geode-core/src/main/java/com/gemstone/gemfire/internal/DataSerializableFixedID.java 7427f9009dfb732971970a518a2a27adc81c62cd
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireUtilLauncher.java fa19049a8f2e1af70250a7c18abe3d4fa8d27a26
> geode-core/src/main/java/com/gemstone/gemfire/internal/InternalDataSerializer.java bff592b5ac8dc98f7bcd716910ae4c776fadb358
> geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java 515b27dcf0ff38ea5f1024f7ba8b7262172c203a
> geode-core/src/main/java/com/gemstone/gemfire/internal/Version.java 258eaf0e683da7ce4025f5cf388574935dcc3bc4
> geode-core/src/main/java/com/gemstone/gemfire/internal/VersionedDataStream.java a2711ffee9e7575edeff8cd921a3168883ce9ec8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractDiskRegionEntry.java b65b7addc4d572b262b0a0a8a99ee4a79ac0390f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java 25cc818603e5a4f1a0a10f57a2861afb0599bd81
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java 0cbec19408198a5d4fc7f975b43ad4075e29a580
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketAdvisor.java c241c6b7760e0cde59facd7f708c716f563eb2a9
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java e2482bb5592546d280c6f3fb73f7775e9a174afd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheDistributionAdvisor.java 4a34771388da63a648c6d7763fc39334aa716b38
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerLauncher.java d4c19ce6e0d464e90fd62935e00e7a7be72ce659
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CachedDeserializableFactory.java 84e44d84807ae05440edd664d1a4b0ab79bf9ea0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationHelper.java 72edc1076c5480a665bba39af21ee87da7635372
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DestroyOperation.java e26719076eb0c49ae364da951f72fef7bf136a42
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java 54ecb0434298ab6af2af8724a33048732735fc7d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskInitFile.java 7e2333e779db4a46d0fe1f88d7ae61c7831fde5a
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskRegion.java c1d2f038992680e94cc5605ade0ae11bb3796531
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskWriteAttributesImpl.java 914c8781ed979be5903b0818750a88dfe2073451
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistTXState.java cafdb805e97fa1e9c5a35e7efe663f1059a6d429
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistTXStateOnCoordinator.java 33bec1c27d574ee963d488123d8b0ab08b9548ea
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedCacheOperation.java 6a7b4f2f7192613b5f90d46274a0875d7483d074
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedPutAllOperation.java b6aa1b644784639973d3232b6e354937d7bd4ac7
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegion.java cc86e2c9381091e33bd877e42fe4a39677644922
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegionFunctionStreamingMessage.java e51bedd4fc621a416a1a2df8b86c876f33b15bfe
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRemoveAllOperation.java 1d216ce63948d8276295de0559307cfb05c2c01c
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryBits.java f95af608efee479aad2038a501c5dae1183bec63
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java 68c8117b45b2319eca861205a1e9e69602738edf
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryOperationImpl.java d539366476014243dbd77ff825b6e8b0eb93cf5f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 76a27298fba3f6c2b4c6d1d3fdfdfde6216e0797
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GridAdvisor.java fd350a0fffd17637a7484690e545689bf8dcbefd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InitialImageOperation.java b43ba2d510275eeb78530e1b81cb62321c2338cf
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InternalRegionArguments.java f7d46feac4a1f4880c6bd1f91b7aaa5b4ddb5f66
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InvalidateOperation.java 6e1d91e426dc6a78da1cc936bb9cef08f3206a06
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/KeyInfo.java 30f30fcb237f7e5bd665e0c329fc39771a959af1
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/KeyWithRegionContext.java b28a551a6703e9a27fe169eacc39185c0addda74
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ListOfDeltas.java 6592863f286cf66bfd634957343b16833568b03b
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java cc5ac59e9390542f593becd37e332d7b63c350d5
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/Oplog.java 96f616b4a2471bdf4e10d8b3cbcf52df59f58bc0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PRHARedundancyProvider.java 6fe39b1e651b1d435ef95f329bd3558d0dbee1e1
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionAttributesImpl.java d1e2bd0ad27cb46c3c9c23bfd0584bfb0feaa013
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java ea207aea40aad944abd8fce572faed73e03f82e4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegionDataStore.java bda68e38fb6bd4f5f2b286ee23d85f4b8b3a4b26
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ProxyRegionMap.java 74c134b90134ded2a19c02440bb756754c3a019d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/QueuedOperation.java 2d5a69866825da65f77f3203adf69e29dc074c78
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionEntry.java 09aef2a02ae851573a9358f1f62c129dee1a3b00
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionMap.java a7c26073dbbc236e000dffd56024a32e957cb991
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteContainsKeyValueMessage.java acf87238a826760b5802516e3986bf26de9f9167
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteDestroyMessage.java f7109bb9b453beb78d4ac7510b3e7b9628a350f6
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteFetchEntryMessage.java 685f0a5ee6c7adeec16a275b0ebb9af217ee4db3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteFetchVersionMessage.java 12e4de6114ef1bb5f3327f65747b78d838b15f37
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteGetMessage.java b565a2cdc89f23b854fd2690f7265284dfd214dd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteInvalidateMessage.java c4ed1ccefa78de7e02531d1656171a05e224e7e0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutAllMessage.java ff09af9a7fa3b48cc673a64f505265ab3e8154ae
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutMessage.java 27f2bb96424bb588b53080f3a29860910d865cec
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteRemoveAllMessage.java 01e8d9e2341b300bd34d09e4fdcdf2a9bb19e330
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/SearchLoadAndWriteProcessor.java 6642ec61b66f1b5cec22704a3610351dba47909b
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEntry.java 2906ff6e03efb0d491ef1d8abe97dec2ae99f24a
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEntryState.java b6686d42a6ec1fd8a0797a17cc007bf006fb3a99
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRegionLockRequestImpl.java 29af5cc96334648a8a26b619d33da72ff3b82a74
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRegionState.java 116edf71e81f95150975f94f709186e427655b84
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXState.java e610991d12ddbe317f6894b71c27c84e09fc78ba
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXStateInterface.java 3fa935129ed1daefcbd163d34dc90962e4230894
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateAttributesProcessor.java 866eaffce1d20dc88e39f04cf4dd3154ebe78db2
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateEntryVersionOperation.java fce4deea5515bb6e6e9972648d09d15acaec77e8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateOperation.java 730d6d772c85e945050c627831f640d1e1b93ddc
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ValidatingDiskRegion.java 54133cc478a206bc30d7606cd0dfd52e9f7549d8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/WrappedCallbackArgument.java 99a5cebbf7189f22119f3eff2e7ce279d979f8cb
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/delta/Delta.java aeabbd8474ef211d03343058f8ff8e05496b72b4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/AbstractExecution.java ff736be3bcbee7e03d62dc2ddd6795e1c39cfb46
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/FunctionStreamingResultCollector.java 3874ad90f8c92602406e318ce9a43b58fc7bc635
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalExecution.java d3fd2f27ecaadc7fe1495365b4ec7e42aedea88f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalFunctionService.java 8af841d0ade52fa6c58c277bb74a2cc87ea14b72
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalRegionFunctionContext.java 22349256f46487ffb25780a82c8778f9d97418b3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/MemberFunctionExecutor.java ac628a0ff429303f8ab31ee9028605bf95e1b765
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/MultiRegionFunctionExecutor.java 192916997f3ffd1639d7f47880476dfd1c9923ea
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/RegionFunctionContextImpl.java 175e863c2a575626716bbc638749356c49be02a8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/ServerFunctionExecutor.java 9c06bf67b0cdbab53e26de11034cd12b644966e8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/ContainsKeyValueMessage.java 4a9c684a49e6e7715d0d583977ab317aa94c9a60
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/DestroyMessage.java c706a3c7d5c14377587aaa6b336ba08c2382f34f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchBulkEntriesMessage.java ea47e91a53ded0ed03781e8ff83b7e7bd8146fb4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessage.java d27e33e32a113bbead7340c54d8e27c8d6fb3339
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntryMessage.java ae363ba53eebad4911f6b2685f804bae2eca2899
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchKeysMessage.java d7c7d71f4aa50584dc39a0ebeea563dccdd40dc8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/GetMessage.java 3fef79004cbca788fcd6b9368c8b193043210f02
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/InvalidateMessage.java 60508c170afe4fa83a8c46c22706e852bcade1c4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PREntriesIterator.java ec2a8dbf18801ed567172c1a0ec3a3daeb08bf5d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PRUpdateEntryVersionMessage.java e1766dc036e864d5ec77aeb32b09ab4537e70f48
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessage.java 626efefc1921cac2919c56ed415707a426b5ea50
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PutAllPRMessage.java 8aaf587a7f72ca60bb2e4a754592ecf8991e5608
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PutMessage.java a6a39dc902027040e4aa49359915f04c9273bff7
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RegionAdvisor.java 03df3fb122f981864e583b9d698ac2f2a9cdede8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RemoteFetchKeysMessage.java ac95e03830ae386cbce04bf9cdc0091568a90e67
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RemoveAllPRMessage.java fb46e0c85a3785dc7aae251f1ecf04edd0f89e54
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/rebalance/PartitionedRegionLoadModel.java 1cfa4a4927b33540efb3f5b952975e0052daeb76
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/GatewayReceiverCommand.java 448be9247cdf9b36ec75899c999f631eec48db0e
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tx/DistTxEntryEvent.java 6e7c21cbd9546cd812ba131aca0a4686bd98bb08
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySender.java 713023ff42cc91295c7767716d111211fdd367c6
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java 2ef5e19a7ea22f84fb1a7b29e5cbe224aaaaf847
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventCallbackArgument.java f6f8d885ff85450346553d49cbb71a9d2f4c6479
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventImpl.java 09d68f547c816747a5a4692ed389afe470982fe3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java 46ff2636dda03d58d7401b196a75e89094de6171
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/RegionAttributesCreation.java 4dfe6aee4c707fc14b6a4cec1f994db690e3b319
> geode-core/src/main/java/com/gemstone/gemfire/internal/i18n/LocalizedStrings.java d3d232ee71390ddc424b4e78a5f907ea974d7e4b
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/LoggingThreadGroup.java 48c0eac3b0862a835dbf30cf3a872f37a9b07017
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/ManagerLogWriter.java 28419fc2eaa17d0836c4c2bb1c295d1f6e80b1ce
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/PureLogWriter.java 3279bf622b51bed1a36438da39df241d8eb55770
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapHelper.java 0f33d5a7d91d2ae16f6864b55054386b56bd80ca
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImpl.java 571c2d1a9aa1f7fe1ece1fb46e1b691d18de72e7
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/annotations/OffHeapIdentifier.java e275467a67fd51aeee637b65f79f360783562bd5
> geode-core/src/main/java/com/gemstone/gemfire/internal/shared/NativeCalls.java f0fc27aac1c7613142fd6a3394860921cf9fbef3
> geode-core/src/main/java/com/gemstone/gemfire/internal/util/ArrayUtils.java 4f15b17dfe9d38f6de878e42cac043ad1e5101aa
> geode-core/src/main/java/com/gemstone/gemfire/internal/util/concurrent/CustomEntryConcurrentHashMap.java 144c7a3a4d9e840889a9ddcac5821f9e3e1caf60
> geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java e11233770d8fc812706cc29b2e288e6305a2fe7b
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 3a06c1c13745f6d6477ff61176d5986ae29d01d6
> geode-core/src/test/java/com/gemstone/gemfire/disttx/DistributedTransactionDUnitTest.java 33306d8c7241c061038fc130cbbcec377b34d906
> geode-core/src/test/java/com/gemstone/gemfire/internal/BackwardCompatibilitySerializationDUnitTest.java 07f87a3fbccaeab722c8d19ea9803387dc0b6da4
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRCustomPartitioningDUnitTest.java 12a143d9ad362e93457d364c302d062e2c23d4f7
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessageJUnitTest.java e08a26808f13124940faffa994a511562a64729b
> geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedDataSerializables.txt d2204a0f5a7673a909a48dc7f846377d0ce88d4d
> geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedSerializables.txt 89305acea1887fcf2edba17b91362bbfc53c5703
>
> Diff: https://reviews.apache.org/r/48189/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 48189: remove sqlf, sql fabric,
gemfirexd from geode-core
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48189/#review136325
-----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java (line 570)
<https://reviews.apache.org/r/48189/#comment201343>
removed unneeded indentation
- Darrel Schneider
On June 2, 2016, 3:20 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48189/
> -----------------------------------------------------------
>
> (Updated June 2, 2016, 3:20 p.m.)
>
>
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
>
>
> Bugs: GEODE-1464
> https://issues.apache.org/jira/browse/GEODE-1464
>
>
> Repository: geode
>
>
> Description
> -------
>
> removed internal Delta (only used by sqlf)
> removed sqlfDisconnectListener
> removed getStringForSQLF
> removed sqlfabric.sys-disk-dir system property
> removed unInitializedMembers and deferredVolunteerForPrimary
> removed sqlf serialization code
> removed GemFireUtilLauncher
> removed afterValueOverflow
> removed preferObject, eager deserialize, and KeyWithRegionContext
> removed unused sqlf methods in PartitionedRegion
> removed memberUnInitialized
> removed sqlf from DiskEntry
> removed setCallbackArgument from EntryOperationImpl
> removed distributeUpdatedProfileOnHubCreation
> removed getEntriesInTxForSqlFabric
> removed withRoutingObjects and hasRoutingObjects
> removed resetBucketAdvisorParents
> rebalance no longer calls GemFireCacheImpl.getInstance comments
> removed sqlf log messages
> removed sqlf OffHeapIdentifiers
> removed SqlfSerializationException from sanctionedSerializables
> removed static helper methods from DiskWriteAttributesImpl
> removed contextObject from EntryEventImpl
> remove serializeCallbackArg from WrappedCallbackArgument since it was always true
> removed getLeaderRegionName and getColocatedRegionName
> removed newPutEntryEvent
> removed clearLocalPrimaries
> removed call to non-existent OSProcess$NativeOSCalls
> removed putDML
> removed getClassesToSerializers
> simplified cleanUpOnImcompleteOp
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/IndexUpdater.java facbdf2cecd699361c3cc7782a38ab21d436637e
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionMessage.java bb36b8023b050f17e2d8e742875c736bcabf7755
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java 552dbe3e2aeda91a6dbce7d0f27e07c038f683cc
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ReplyProcessor21.java e5e8cbfb9ab734d93fea991b1d6715b9a7b31a9e
> geode-core/src/main/java/com/gemstone/gemfire/internal/DSCODE.java 8d91c6b7e616e42f0c92da07492c2ade4d8e3e6f
> geode-core/src/main/java/com/gemstone/gemfire/internal/DSFIDFactory.java bd78f5ae78953fab616f2ada870aa1aa920d56f3
> geode-core/src/main/java/com/gemstone/gemfire/internal/DataSerializableFixedID.java 7427f9009dfb732971970a518a2a27adc81c62cd
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireUtilLauncher.java fa19049a8f2e1af70250a7c18abe3d4fa8d27a26
> geode-core/src/main/java/com/gemstone/gemfire/internal/InternalDataSerializer.java bff592b5ac8dc98f7bcd716910ae4c776fadb358
> geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java 515b27dcf0ff38ea5f1024f7ba8b7262172c203a
> geode-core/src/main/java/com/gemstone/gemfire/internal/Version.java 258eaf0e683da7ce4025f5cf388574935dcc3bc4
> geode-core/src/main/java/com/gemstone/gemfire/internal/VersionedDataStream.java a2711ffee9e7575edeff8cd921a3168883ce9ec8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractDiskRegionEntry.java b65b7addc4d572b262b0a0a8a99ee4a79ac0390f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java 25cc818603e5a4f1a0a10f57a2861afb0599bd81
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java 0cbec19408198a5d4fc7f975b43ad4075e29a580
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketAdvisor.java c241c6b7760e0cde59facd7f708c716f563eb2a9
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java e2482bb5592546d280c6f3fb73f7775e9a174afd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheDistributionAdvisor.java 4a34771388da63a648c6d7763fc39334aa716b38
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerLauncher.java d4c19ce6e0d464e90fd62935e00e7a7be72ce659
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CachedDeserializableFactory.java 84e44d84807ae05440edd664d1a4b0ab79bf9ea0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationHelper.java 72edc1076c5480a665bba39af21ee87da7635372
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DestroyOperation.java e26719076eb0c49ae364da951f72fef7bf136a42
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java 54ecb0434298ab6af2af8724a33048732735fc7d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskInitFile.java 7e2333e779db4a46d0fe1f88d7ae61c7831fde5a
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskRegion.java c1d2f038992680e94cc5605ade0ae11bb3796531
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskWriteAttributesImpl.java 914c8781ed979be5903b0818750a88dfe2073451
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistTXState.java cafdb805e97fa1e9c5a35e7efe663f1059a6d429
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistTXStateOnCoordinator.java 33bec1c27d574ee963d488123d8b0ab08b9548ea
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedCacheOperation.java 6a7b4f2f7192613b5f90d46274a0875d7483d074
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedPutAllOperation.java b6aa1b644784639973d3232b6e354937d7bd4ac7
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegion.java cc86e2c9381091e33bd877e42fe4a39677644922
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegionFunctionStreamingMessage.java e51bedd4fc621a416a1a2df8b86c876f33b15bfe
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRemoveAllOperation.java 1d216ce63948d8276295de0559307cfb05c2c01c
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryBits.java f95af608efee479aad2038a501c5dae1183bec63
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java 68c8117b45b2319eca861205a1e9e69602738edf
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryOperationImpl.java d539366476014243dbd77ff825b6e8b0eb93cf5f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 76a27298fba3f6c2b4c6d1d3fdfdfde6216e0797
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GridAdvisor.java fd350a0fffd17637a7484690e545689bf8dcbefd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InitialImageOperation.java b43ba2d510275eeb78530e1b81cb62321c2338cf
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InternalRegionArguments.java f7d46feac4a1f4880c6bd1f91b7aaa5b4ddb5f66
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InvalidateOperation.java 6e1d91e426dc6a78da1cc936bb9cef08f3206a06
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/KeyInfo.java 30f30fcb237f7e5bd665e0c329fc39771a959af1
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/KeyWithRegionContext.java b28a551a6703e9a27fe169eacc39185c0addda74
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ListOfDeltas.java 6592863f286cf66bfd634957343b16833568b03b
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java cc5ac59e9390542f593becd37e332d7b63c350d5
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/Oplog.java 96f616b4a2471bdf4e10d8b3cbcf52df59f58bc0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PRHARedundancyProvider.java 6fe39b1e651b1d435ef95f329bd3558d0dbee1e1
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionAttributesImpl.java d1e2bd0ad27cb46c3c9c23bfd0584bfb0feaa013
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java ea207aea40aad944abd8fce572faed73e03f82e4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegionDataStore.java bda68e38fb6bd4f5f2b286ee23d85f4b8b3a4b26
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ProxyRegionMap.java 74c134b90134ded2a19c02440bb756754c3a019d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/QueuedOperation.java 2d5a69866825da65f77f3203adf69e29dc074c78
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionEntry.java 09aef2a02ae851573a9358f1f62c129dee1a3b00
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionMap.java a7c26073dbbc236e000dffd56024a32e957cb991
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteContainsKeyValueMessage.java acf87238a826760b5802516e3986bf26de9f9167
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteDestroyMessage.java f7109bb9b453beb78d4ac7510b3e7b9628a350f6
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteFetchEntryMessage.java 685f0a5ee6c7adeec16a275b0ebb9af217ee4db3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteFetchVersionMessage.java 12e4de6114ef1bb5f3327f65747b78d838b15f37
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteGetMessage.java b565a2cdc89f23b854fd2690f7265284dfd214dd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteInvalidateMessage.java c4ed1ccefa78de7e02531d1656171a05e224e7e0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutAllMessage.java ff09af9a7fa3b48cc673a64f505265ab3e8154ae
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutMessage.java 27f2bb96424bb588b53080f3a29860910d865cec
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteRemoveAllMessage.java 01e8d9e2341b300bd34d09e4fdcdf2a9bb19e330
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/SearchLoadAndWriteProcessor.java 6642ec61b66f1b5cec22704a3610351dba47909b
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEntry.java 2906ff6e03efb0d491ef1d8abe97dec2ae99f24a
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEntryState.java b6686d42a6ec1fd8a0797a17cc007bf006fb3a99
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRegionLockRequestImpl.java 29af5cc96334648a8a26b619d33da72ff3b82a74
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRegionState.java 116edf71e81f95150975f94f709186e427655b84
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXState.java e610991d12ddbe317f6894b71c27c84e09fc78ba
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXStateInterface.java 3fa935129ed1daefcbd163d34dc90962e4230894
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateAttributesProcessor.java 866eaffce1d20dc88e39f04cf4dd3154ebe78db2
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateEntryVersionOperation.java fce4deea5515bb6e6e9972648d09d15acaec77e8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateOperation.java 730d6d772c85e945050c627831f640d1e1b93ddc
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ValidatingDiskRegion.java 54133cc478a206bc30d7606cd0dfd52e9f7549d8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/WrappedCallbackArgument.java 99a5cebbf7189f22119f3eff2e7ce279d979f8cb
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/delta/Delta.java aeabbd8474ef211d03343058f8ff8e05496b72b4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/AbstractExecution.java ff736be3bcbee7e03d62dc2ddd6795e1c39cfb46
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/FunctionStreamingResultCollector.java 3874ad90f8c92602406e318ce9a43b58fc7bc635
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalExecution.java d3fd2f27ecaadc7fe1495365b4ec7e42aedea88f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalFunctionService.java 8af841d0ade52fa6c58c277bb74a2cc87ea14b72
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalRegionFunctionContext.java 22349256f46487ffb25780a82c8778f9d97418b3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/MemberFunctionExecutor.java ac628a0ff429303f8ab31ee9028605bf95e1b765
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/MultiRegionFunctionExecutor.java 192916997f3ffd1639d7f47880476dfd1c9923ea
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/RegionFunctionContextImpl.java 175e863c2a575626716bbc638749356c49be02a8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/ServerFunctionExecutor.java 9c06bf67b0cdbab53e26de11034cd12b644966e8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/ContainsKeyValueMessage.java 4a9c684a49e6e7715d0d583977ab317aa94c9a60
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/DestroyMessage.java c706a3c7d5c14377587aaa6b336ba08c2382f34f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchBulkEntriesMessage.java ea47e91a53ded0ed03781e8ff83b7e7bd8146fb4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessage.java d27e33e32a113bbead7340c54d8e27c8d6fb3339
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntryMessage.java ae363ba53eebad4911f6b2685f804bae2eca2899
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchKeysMessage.java d7c7d71f4aa50584dc39a0ebeea563dccdd40dc8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/GetMessage.java 3fef79004cbca788fcd6b9368c8b193043210f02
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/InvalidateMessage.java 60508c170afe4fa83a8c46c22706e852bcade1c4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PREntriesIterator.java ec2a8dbf18801ed567172c1a0ec3a3daeb08bf5d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PRUpdateEntryVersionMessage.java e1766dc036e864d5ec77aeb32b09ab4537e70f48
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessage.java 626efefc1921cac2919c56ed415707a426b5ea50
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PutAllPRMessage.java 8aaf587a7f72ca60bb2e4a754592ecf8991e5608
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PutMessage.java a6a39dc902027040e4aa49359915f04c9273bff7
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RegionAdvisor.java 03df3fb122f981864e583b9d698ac2f2a9cdede8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RemoteFetchKeysMessage.java ac95e03830ae386cbce04bf9cdc0091568a90e67
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RemoveAllPRMessage.java fb46e0c85a3785dc7aae251f1ecf04edd0f89e54
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/rebalance/PartitionedRegionLoadModel.java 1cfa4a4927b33540efb3f5b952975e0052daeb76
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/GatewayReceiverCommand.java 448be9247cdf9b36ec75899c999f631eec48db0e
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tx/DistTxEntryEvent.java 6e7c21cbd9546cd812ba131aca0a4686bd98bb08
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySender.java 713023ff42cc91295c7767716d111211fdd367c6
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java 2ef5e19a7ea22f84fb1a7b29e5cbe224aaaaf847
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventCallbackArgument.java f6f8d885ff85450346553d49cbb71a9d2f4c6479
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventImpl.java 09d68f547c816747a5a4692ed389afe470982fe3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java 46ff2636dda03d58d7401b196a75e89094de6171
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/RegionAttributesCreation.java 4dfe6aee4c707fc14b6a4cec1f994db690e3b319
> geode-core/src/main/java/com/gemstone/gemfire/internal/i18n/LocalizedStrings.java d3d232ee71390ddc424b4e78a5f907ea974d7e4b
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/LoggingThreadGroup.java 48c0eac3b0862a835dbf30cf3a872f37a9b07017
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/ManagerLogWriter.java 28419fc2eaa17d0836c4c2bb1c295d1f6e80b1ce
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/PureLogWriter.java 3279bf622b51bed1a36438da39df241d8eb55770
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapHelper.java 0f33d5a7d91d2ae16f6864b55054386b56bd80ca
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImpl.java 571c2d1a9aa1f7fe1ece1fb46e1b691d18de72e7
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/annotations/OffHeapIdentifier.java e275467a67fd51aeee637b65f79f360783562bd5
> geode-core/src/main/java/com/gemstone/gemfire/internal/shared/NativeCalls.java f0fc27aac1c7613142fd6a3394860921cf9fbef3
> geode-core/src/main/java/com/gemstone/gemfire/internal/util/ArrayUtils.java 4f15b17dfe9d38f6de878e42cac043ad1e5101aa
> geode-core/src/main/java/com/gemstone/gemfire/internal/util/concurrent/CustomEntryConcurrentHashMap.java 144c7a3a4d9e840889a9ddcac5821f9e3e1caf60
> geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java e11233770d8fc812706cc29b2e288e6305a2fe7b
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 3a06c1c13745f6d6477ff61176d5986ae29d01d6
> geode-core/src/test/java/com/gemstone/gemfire/disttx/DistributedTransactionDUnitTest.java 33306d8c7241c061038fc130cbbcec377b34d906
> geode-core/src/test/java/com/gemstone/gemfire/internal/BackwardCompatibilitySerializationDUnitTest.java 07f87a3fbccaeab722c8d19ea9803387dc0b6da4
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRCustomPartitioningDUnitTest.java 12a143d9ad362e93457d364c302d062e2c23d4f7
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessageJUnitTest.java e08a26808f13124940faffa994a511562a64729b
> geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedDataSerializables.txt d2204a0f5a7673a909a48dc7f846377d0ce88d4d
> geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedSerializables.txt 89305acea1887fcf2edba17b91362bbfc53c5703
>
> Diff: https://reviews.apache.org/r/48189/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 48189: remove sqlf, sql fabric,
gemfirexd from geode-core
Posted by Darrel Schneider <ds...@pivotal.io>.
> On June 6, 2016, 2:51 p.m., Ken Howe wrote:
> > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InitialImageOperation.java, lines 919-924
> > <https://reviews.apache.org/r/48189/diff/1/?file=1405457#file1405457line919>
> >
> > Couldn't these statements be coalesced? "entriesEqual" doesn't look like it's used anywhere else.
They could be but that seems outside the scope of removing the sqlf code.
The old code also only used the local var "entriesEqual" once but still wanted this local var.
Since these 6 lines of code were not modified by these changes I'd prefer to leave it that way.
- Darrel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48189/#review136365
-----------------------------------------------------------
On June 2, 2016, 3:20 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48189/
> -----------------------------------------------------------
>
> (Updated June 2, 2016, 3:20 p.m.)
>
>
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
>
>
> Bugs: GEODE-1464
> https://issues.apache.org/jira/browse/GEODE-1464
>
>
> Repository: geode
>
>
> Description
> -------
>
> removed internal Delta (only used by sqlf)
> removed sqlfDisconnectListener
> removed getStringForSQLF
> removed sqlfabric.sys-disk-dir system property
> removed unInitializedMembers and deferredVolunteerForPrimary
> removed sqlf serialization code
> removed GemFireUtilLauncher
> removed afterValueOverflow
> removed preferObject, eager deserialize, and KeyWithRegionContext
> removed unused sqlf methods in PartitionedRegion
> removed memberUnInitialized
> removed sqlf from DiskEntry
> removed setCallbackArgument from EntryOperationImpl
> removed distributeUpdatedProfileOnHubCreation
> removed getEntriesInTxForSqlFabric
> removed withRoutingObjects and hasRoutingObjects
> removed resetBucketAdvisorParents
> rebalance no longer calls GemFireCacheImpl.getInstance comments
> removed sqlf log messages
> removed sqlf OffHeapIdentifiers
> removed SqlfSerializationException from sanctionedSerializables
> removed static helper methods from DiskWriteAttributesImpl
> removed contextObject from EntryEventImpl
> remove serializeCallbackArg from WrappedCallbackArgument since it was always true
> removed getLeaderRegionName and getColocatedRegionName
> removed newPutEntryEvent
> removed clearLocalPrimaries
> removed call to non-existent OSProcess$NativeOSCalls
> removed putDML
> removed getClassesToSerializers
> simplified cleanUpOnImcompleteOp
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/IndexUpdater.java facbdf2cecd699361c3cc7782a38ab21d436637e
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionMessage.java bb36b8023b050f17e2d8e742875c736bcabf7755
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java 552dbe3e2aeda91a6dbce7d0f27e07c038f683cc
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ReplyProcessor21.java e5e8cbfb9ab734d93fea991b1d6715b9a7b31a9e
> geode-core/src/main/java/com/gemstone/gemfire/internal/DSCODE.java 8d91c6b7e616e42f0c92da07492c2ade4d8e3e6f
> geode-core/src/main/java/com/gemstone/gemfire/internal/DSFIDFactory.java bd78f5ae78953fab616f2ada870aa1aa920d56f3
> geode-core/src/main/java/com/gemstone/gemfire/internal/DataSerializableFixedID.java 7427f9009dfb732971970a518a2a27adc81c62cd
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireUtilLauncher.java fa19049a8f2e1af70250a7c18abe3d4fa8d27a26
> geode-core/src/main/java/com/gemstone/gemfire/internal/InternalDataSerializer.java bff592b5ac8dc98f7bcd716910ae4c776fadb358
> geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java 515b27dcf0ff38ea5f1024f7ba8b7262172c203a
> geode-core/src/main/java/com/gemstone/gemfire/internal/Version.java 258eaf0e683da7ce4025f5cf388574935dcc3bc4
> geode-core/src/main/java/com/gemstone/gemfire/internal/VersionedDataStream.java a2711ffee9e7575edeff8cd921a3168883ce9ec8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractDiskRegionEntry.java b65b7addc4d572b262b0a0a8a99ee4a79ac0390f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java 25cc818603e5a4f1a0a10f57a2861afb0599bd81
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java 0cbec19408198a5d4fc7f975b43ad4075e29a580
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketAdvisor.java c241c6b7760e0cde59facd7f708c716f563eb2a9
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java e2482bb5592546d280c6f3fb73f7775e9a174afd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheDistributionAdvisor.java 4a34771388da63a648c6d7763fc39334aa716b38
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerLauncher.java d4c19ce6e0d464e90fd62935e00e7a7be72ce659
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CachedDeserializableFactory.java 84e44d84807ae05440edd664d1a4b0ab79bf9ea0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationHelper.java 72edc1076c5480a665bba39af21ee87da7635372
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DestroyOperation.java e26719076eb0c49ae364da951f72fef7bf136a42
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java 54ecb0434298ab6af2af8724a33048732735fc7d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskInitFile.java 7e2333e779db4a46d0fe1f88d7ae61c7831fde5a
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskRegion.java c1d2f038992680e94cc5605ade0ae11bb3796531
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskWriteAttributesImpl.java 914c8781ed979be5903b0818750a88dfe2073451
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistTXState.java cafdb805e97fa1e9c5a35e7efe663f1059a6d429
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistTXStateOnCoordinator.java 33bec1c27d574ee963d488123d8b0ab08b9548ea
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedCacheOperation.java 6a7b4f2f7192613b5f90d46274a0875d7483d074
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedPutAllOperation.java b6aa1b644784639973d3232b6e354937d7bd4ac7
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegion.java cc86e2c9381091e33bd877e42fe4a39677644922
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegionFunctionStreamingMessage.java e51bedd4fc621a416a1a2df8b86c876f33b15bfe
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRemoveAllOperation.java 1d216ce63948d8276295de0559307cfb05c2c01c
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryBits.java f95af608efee479aad2038a501c5dae1183bec63
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java 68c8117b45b2319eca861205a1e9e69602738edf
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryOperationImpl.java d539366476014243dbd77ff825b6e8b0eb93cf5f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 76a27298fba3f6c2b4c6d1d3fdfdfde6216e0797
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GridAdvisor.java fd350a0fffd17637a7484690e545689bf8dcbefd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InitialImageOperation.java b43ba2d510275eeb78530e1b81cb62321c2338cf
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InternalRegionArguments.java f7d46feac4a1f4880c6bd1f91b7aaa5b4ddb5f66
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InvalidateOperation.java 6e1d91e426dc6a78da1cc936bb9cef08f3206a06
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/KeyInfo.java 30f30fcb237f7e5bd665e0c329fc39771a959af1
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/KeyWithRegionContext.java b28a551a6703e9a27fe169eacc39185c0addda74
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ListOfDeltas.java 6592863f286cf66bfd634957343b16833568b03b
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java cc5ac59e9390542f593becd37e332d7b63c350d5
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/Oplog.java 96f616b4a2471bdf4e10d8b3cbcf52df59f58bc0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PRHARedundancyProvider.java 6fe39b1e651b1d435ef95f329bd3558d0dbee1e1
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionAttributesImpl.java d1e2bd0ad27cb46c3c9c23bfd0584bfb0feaa013
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java ea207aea40aad944abd8fce572faed73e03f82e4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegionDataStore.java bda68e38fb6bd4f5f2b286ee23d85f4b8b3a4b26
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ProxyRegionMap.java 74c134b90134ded2a19c02440bb756754c3a019d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/QueuedOperation.java 2d5a69866825da65f77f3203adf69e29dc074c78
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionEntry.java 09aef2a02ae851573a9358f1f62c129dee1a3b00
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionMap.java a7c26073dbbc236e000dffd56024a32e957cb991
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteContainsKeyValueMessage.java acf87238a826760b5802516e3986bf26de9f9167
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteDestroyMessage.java f7109bb9b453beb78d4ac7510b3e7b9628a350f6
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteFetchEntryMessage.java 685f0a5ee6c7adeec16a275b0ebb9af217ee4db3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteFetchVersionMessage.java 12e4de6114ef1bb5f3327f65747b78d838b15f37
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteGetMessage.java b565a2cdc89f23b854fd2690f7265284dfd214dd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteInvalidateMessage.java c4ed1ccefa78de7e02531d1656171a05e224e7e0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutAllMessage.java ff09af9a7fa3b48cc673a64f505265ab3e8154ae
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutMessage.java 27f2bb96424bb588b53080f3a29860910d865cec
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteRemoveAllMessage.java 01e8d9e2341b300bd34d09e4fdcdf2a9bb19e330
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/SearchLoadAndWriteProcessor.java 6642ec61b66f1b5cec22704a3610351dba47909b
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEntry.java 2906ff6e03efb0d491ef1d8abe97dec2ae99f24a
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEntryState.java b6686d42a6ec1fd8a0797a17cc007bf006fb3a99
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRegionLockRequestImpl.java 29af5cc96334648a8a26b619d33da72ff3b82a74
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRegionState.java 116edf71e81f95150975f94f709186e427655b84
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXState.java e610991d12ddbe317f6894b71c27c84e09fc78ba
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXStateInterface.java 3fa935129ed1daefcbd163d34dc90962e4230894
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateAttributesProcessor.java 866eaffce1d20dc88e39f04cf4dd3154ebe78db2
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateEntryVersionOperation.java fce4deea5515bb6e6e9972648d09d15acaec77e8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateOperation.java 730d6d772c85e945050c627831f640d1e1b93ddc
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ValidatingDiskRegion.java 54133cc478a206bc30d7606cd0dfd52e9f7549d8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/WrappedCallbackArgument.java 99a5cebbf7189f22119f3eff2e7ce279d979f8cb
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/delta/Delta.java aeabbd8474ef211d03343058f8ff8e05496b72b4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/AbstractExecution.java ff736be3bcbee7e03d62dc2ddd6795e1c39cfb46
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/FunctionStreamingResultCollector.java 3874ad90f8c92602406e318ce9a43b58fc7bc635
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalExecution.java d3fd2f27ecaadc7fe1495365b4ec7e42aedea88f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalFunctionService.java 8af841d0ade52fa6c58c277bb74a2cc87ea14b72
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalRegionFunctionContext.java 22349256f46487ffb25780a82c8778f9d97418b3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/MemberFunctionExecutor.java ac628a0ff429303f8ab31ee9028605bf95e1b765
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/MultiRegionFunctionExecutor.java 192916997f3ffd1639d7f47880476dfd1c9923ea
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/RegionFunctionContextImpl.java 175e863c2a575626716bbc638749356c49be02a8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/ServerFunctionExecutor.java 9c06bf67b0cdbab53e26de11034cd12b644966e8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/ContainsKeyValueMessage.java 4a9c684a49e6e7715d0d583977ab317aa94c9a60
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/DestroyMessage.java c706a3c7d5c14377587aaa6b336ba08c2382f34f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchBulkEntriesMessage.java ea47e91a53ded0ed03781e8ff83b7e7bd8146fb4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessage.java d27e33e32a113bbead7340c54d8e27c8d6fb3339
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntryMessage.java ae363ba53eebad4911f6b2685f804bae2eca2899
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchKeysMessage.java d7c7d71f4aa50584dc39a0ebeea563dccdd40dc8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/GetMessage.java 3fef79004cbca788fcd6b9368c8b193043210f02
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/InvalidateMessage.java 60508c170afe4fa83a8c46c22706e852bcade1c4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PREntriesIterator.java ec2a8dbf18801ed567172c1a0ec3a3daeb08bf5d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PRUpdateEntryVersionMessage.java e1766dc036e864d5ec77aeb32b09ab4537e70f48
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessage.java 626efefc1921cac2919c56ed415707a426b5ea50
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PutAllPRMessage.java 8aaf587a7f72ca60bb2e4a754592ecf8991e5608
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PutMessage.java a6a39dc902027040e4aa49359915f04c9273bff7
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RegionAdvisor.java 03df3fb122f981864e583b9d698ac2f2a9cdede8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RemoteFetchKeysMessage.java ac95e03830ae386cbce04bf9cdc0091568a90e67
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RemoveAllPRMessage.java fb46e0c85a3785dc7aae251f1ecf04edd0f89e54
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/rebalance/PartitionedRegionLoadModel.java 1cfa4a4927b33540efb3f5b952975e0052daeb76
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/GatewayReceiverCommand.java 448be9247cdf9b36ec75899c999f631eec48db0e
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tx/DistTxEntryEvent.java 6e7c21cbd9546cd812ba131aca0a4686bd98bb08
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySender.java 713023ff42cc91295c7767716d111211fdd367c6
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java 2ef5e19a7ea22f84fb1a7b29e5cbe224aaaaf847
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventCallbackArgument.java f6f8d885ff85450346553d49cbb71a9d2f4c6479
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventImpl.java 09d68f547c816747a5a4692ed389afe470982fe3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java 46ff2636dda03d58d7401b196a75e89094de6171
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/RegionAttributesCreation.java 4dfe6aee4c707fc14b6a4cec1f994db690e3b319
> geode-core/src/main/java/com/gemstone/gemfire/internal/i18n/LocalizedStrings.java d3d232ee71390ddc424b4e78a5f907ea974d7e4b
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/LoggingThreadGroup.java 48c0eac3b0862a835dbf30cf3a872f37a9b07017
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/ManagerLogWriter.java 28419fc2eaa17d0836c4c2bb1c295d1f6e80b1ce
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/PureLogWriter.java 3279bf622b51bed1a36438da39df241d8eb55770
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapHelper.java 0f33d5a7d91d2ae16f6864b55054386b56bd80ca
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImpl.java 571c2d1a9aa1f7fe1ece1fb46e1b691d18de72e7
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/annotations/OffHeapIdentifier.java e275467a67fd51aeee637b65f79f360783562bd5
> geode-core/src/main/java/com/gemstone/gemfire/internal/shared/NativeCalls.java f0fc27aac1c7613142fd6a3394860921cf9fbef3
> geode-core/src/main/java/com/gemstone/gemfire/internal/util/ArrayUtils.java 4f15b17dfe9d38f6de878e42cac043ad1e5101aa
> geode-core/src/main/java/com/gemstone/gemfire/internal/util/concurrent/CustomEntryConcurrentHashMap.java 144c7a3a4d9e840889a9ddcac5821f9e3e1caf60
> geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java e11233770d8fc812706cc29b2e288e6305a2fe7b
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 3a06c1c13745f6d6477ff61176d5986ae29d01d6
> geode-core/src/test/java/com/gemstone/gemfire/disttx/DistributedTransactionDUnitTest.java 33306d8c7241c061038fc130cbbcec377b34d906
> geode-core/src/test/java/com/gemstone/gemfire/internal/BackwardCompatibilitySerializationDUnitTest.java 07f87a3fbccaeab722c8d19ea9803387dc0b6da4
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRCustomPartitioningDUnitTest.java 12a143d9ad362e93457d364c302d062e2c23d4f7
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessageJUnitTest.java e08a26808f13124940faffa994a511562a64729b
> geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedDataSerializables.txt d2204a0f5a7673a909a48dc7f846377d0ce88d4d
> geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedSerializables.txt 89305acea1887fcf2edba17b91362bbfc53c5703
>
> Diff: https://reviews.apache.org/r/48189/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 48189: remove sqlf, sql fabric,
gemfirexd from geode-core
Posted by Ken Howe <kh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48189/#review136365
-----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerLauncher.java (lines 373 - 374)
<https://reviews.apache.org/r/48189/#comment201386>
Add the removed word "for". Comment shold read, "...icon to appear for launched procs"
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java (line 210)
<https://reviews.apache.org/r/48189/#comment201388>
Correct typo in string "never e" should be "never be"
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InitialImageOperation.java (lines 888 - 893)
<https://reviews.apache.org/r/48189/#comment201392>
Couldn't these statements be coalesced? "entriesEqual" doesn't look like it's used anywhere else.
- Ken Howe
On June 2, 2016, 10:20 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48189/
> -----------------------------------------------------------
>
> (Updated June 2, 2016, 10:20 p.m.)
>
>
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
>
>
> Bugs: GEODE-1464
> https://issues.apache.org/jira/browse/GEODE-1464
>
>
> Repository: geode
>
>
> Description
> -------
>
> removed internal Delta (only used by sqlf)
> removed sqlfDisconnectListener
> removed getStringForSQLF
> removed sqlfabric.sys-disk-dir system property
> removed unInitializedMembers and deferredVolunteerForPrimary
> removed sqlf serialization code
> removed GemFireUtilLauncher
> removed afterValueOverflow
> removed preferObject, eager deserialize, and KeyWithRegionContext
> removed unused sqlf methods in PartitionedRegion
> removed memberUnInitialized
> removed sqlf from DiskEntry
> removed setCallbackArgument from EntryOperationImpl
> removed distributeUpdatedProfileOnHubCreation
> removed getEntriesInTxForSqlFabric
> removed withRoutingObjects and hasRoutingObjects
> removed resetBucketAdvisorParents
> rebalance no longer calls GemFireCacheImpl.getInstance comments
> removed sqlf log messages
> removed sqlf OffHeapIdentifiers
> removed SqlfSerializationException from sanctionedSerializables
> removed static helper methods from DiskWriteAttributesImpl
> removed contextObject from EntryEventImpl
> remove serializeCallbackArg from WrappedCallbackArgument since it was always true
> removed getLeaderRegionName and getColocatedRegionName
> removed newPutEntryEvent
> removed clearLocalPrimaries
> removed call to non-existent OSProcess$NativeOSCalls
> removed putDML
> removed getClassesToSerializers
> simplified cleanUpOnImcompleteOp
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/IndexUpdater.java facbdf2cecd699361c3cc7782a38ab21d436637e
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionMessage.java bb36b8023b050f17e2d8e742875c736bcabf7755
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java 552dbe3e2aeda91a6dbce7d0f27e07c038f683cc
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ReplyProcessor21.java e5e8cbfb9ab734d93fea991b1d6715b9a7b31a9e
> geode-core/src/main/java/com/gemstone/gemfire/internal/DSCODE.java 8d91c6b7e616e42f0c92da07492c2ade4d8e3e6f
> geode-core/src/main/java/com/gemstone/gemfire/internal/DSFIDFactory.java bd78f5ae78953fab616f2ada870aa1aa920d56f3
> geode-core/src/main/java/com/gemstone/gemfire/internal/DataSerializableFixedID.java 7427f9009dfb732971970a518a2a27adc81c62cd
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireUtilLauncher.java fa19049a8f2e1af70250a7c18abe3d4fa8d27a26
> geode-core/src/main/java/com/gemstone/gemfire/internal/InternalDataSerializer.java bff592b5ac8dc98f7bcd716910ae4c776fadb358
> geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java 515b27dcf0ff38ea5f1024f7ba8b7262172c203a
> geode-core/src/main/java/com/gemstone/gemfire/internal/Version.java 258eaf0e683da7ce4025f5cf388574935dcc3bc4
> geode-core/src/main/java/com/gemstone/gemfire/internal/VersionedDataStream.java a2711ffee9e7575edeff8cd921a3168883ce9ec8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractDiskRegionEntry.java b65b7addc4d572b262b0a0a8a99ee4a79ac0390f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java 25cc818603e5a4f1a0a10f57a2861afb0599bd81
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java 0cbec19408198a5d4fc7f975b43ad4075e29a580
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketAdvisor.java c241c6b7760e0cde59facd7f708c716f563eb2a9
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java e2482bb5592546d280c6f3fb73f7775e9a174afd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheDistributionAdvisor.java 4a34771388da63a648c6d7763fc39334aa716b38
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerLauncher.java d4c19ce6e0d464e90fd62935e00e7a7be72ce659
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CachedDeserializableFactory.java 84e44d84807ae05440edd664d1a4b0ab79bf9ea0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationHelper.java 72edc1076c5480a665bba39af21ee87da7635372
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DestroyOperation.java e26719076eb0c49ae364da951f72fef7bf136a42
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java 54ecb0434298ab6af2af8724a33048732735fc7d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskInitFile.java 7e2333e779db4a46d0fe1f88d7ae61c7831fde5a
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskRegion.java c1d2f038992680e94cc5605ade0ae11bb3796531
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskWriteAttributesImpl.java 914c8781ed979be5903b0818750a88dfe2073451
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistTXState.java cafdb805e97fa1e9c5a35e7efe663f1059a6d429
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistTXStateOnCoordinator.java 33bec1c27d574ee963d488123d8b0ab08b9548ea
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedCacheOperation.java 6a7b4f2f7192613b5f90d46274a0875d7483d074
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedPutAllOperation.java b6aa1b644784639973d3232b6e354937d7bd4ac7
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegion.java cc86e2c9381091e33bd877e42fe4a39677644922
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegionFunctionStreamingMessage.java e51bedd4fc621a416a1a2df8b86c876f33b15bfe
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRemoveAllOperation.java 1d216ce63948d8276295de0559307cfb05c2c01c
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryBits.java f95af608efee479aad2038a501c5dae1183bec63
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java 68c8117b45b2319eca861205a1e9e69602738edf
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryOperationImpl.java d539366476014243dbd77ff825b6e8b0eb93cf5f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 76a27298fba3f6c2b4c6d1d3fdfdfde6216e0797
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GridAdvisor.java fd350a0fffd17637a7484690e545689bf8dcbefd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InitialImageOperation.java b43ba2d510275eeb78530e1b81cb62321c2338cf
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InternalRegionArguments.java f7d46feac4a1f4880c6bd1f91b7aaa5b4ddb5f66
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InvalidateOperation.java 6e1d91e426dc6a78da1cc936bb9cef08f3206a06
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/KeyInfo.java 30f30fcb237f7e5bd665e0c329fc39771a959af1
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/KeyWithRegionContext.java b28a551a6703e9a27fe169eacc39185c0addda74
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ListOfDeltas.java 6592863f286cf66bfd634957343b16833568b03b
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java cc5ac59e9390542f593becd37e332d7b63c350d5
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/Oplog.java 96f616b4a2471bdf4e10d8b3cbcf52df59f58bc0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PRHARedundancyProvider.java 6fe39b1e651b1d435ef95f329bd3558d0dbee1e1
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionAttributesImpl.java d1e2bd0ad27cb46c3c9c23bfd0584bfb0feaa013
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java ea207aea40aad944abd8fce572faed73e03f82e4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegionDataStore.java bda68e38fb6bd4f5f2b286ee23d85f4b8b3a4b26
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ProxyRegionMap.java 74c134b90134ded2a19c02440bb756754c3a019d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/QueuedOperation.java 2d5a69866825da65f77f3203adf69e29dc074c78
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionEntry.java 09aef2a02ae851573a9358f1f62c129dee1a3b00
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionMap.java a7c26073dbbc236e000dffd56024a32e957cb991
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteContainsKeyValueMessage.java acf87238a826760b5802516e3986bf26de9f9167
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteDestroyMessage.java f7109bb9b453beb78d4ac7510b3e7b9628a350f6
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteFetchEntryMessage.java 685f0a5ee6c7adeec16a275b0ebb9af217ee4db3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteFetchVersionMessage.java 12e4de6114ef1bb5f3327f65747b78d838b15f37
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteGetMessage.java b565a2cdc89f23b854fd2690f7265284dfd214dd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteInvalidateMessage.java c4ed1ccefa78de7e02531d1656171a05e224e7e0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutAllMessage.java ff09af9a7fa3b48cc673a64f505265ab3e8154ae
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutMessage.java 27f2bb96424bb588b53080f3a29860910d865cec
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteRemoveAllMessage.java 01e8d9e2341b300bd34d09e4fdcdf2a9bb19e330
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/SearchLoadAndWriteProcessor.java 6642ec61b66f1b5cec22704a3610351dba47909b
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEntry.java 2906ff6e03efb0d491ef1d8abe97dec2ae99f24a
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEntryState.java b6686d42a6ec1fd8a0797a17cc007bf006fb3a99
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRegionLockRequestImpl.java 29af5cc96334648a8a26b619d33da72ff3b82a74
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRegionState.java 116edf71e81f95150975f94f709186e427655b84
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXState.java e610991d12ddbe317f6894b71c27c84e09fc78ba
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXStateInterface.java 3fa935129ed1daefcbd163d34dc90962e4230894
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateAttributesProcessor.java 866eaffce1d20dc88e39f04cf4dd3154ebe78db2
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateEntryVersionOperation.java fce4deea5515bb6e6e9972648d09d15acaec77e8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateOperation.java 730d6d772c85e945050c627831f640d1e1b93ddc
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ValidatingDiskRegion.java 54133cc478a206bc30d7606cd0dfd52e9f7549d8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/WrappedCallbackArgument.java 99a5cebbf7189f22119f3eff2e7ce279d979f8cb
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/delta/Delta.java aeabbd8474ef211d03343058f8ff8e05496b72b4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/AbstractExecution.java ff736be3bcbee7e03d62dc2ddd6795e1c39cfb46
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/FunctionStreamingResultCollector.java 3874ad90f8c92602406e318ce9a43b58fc7bc635
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalExecution.java d3fd2f27ecaadc7fe1495365b4ec7e42aedea88f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalFunctionService.java 8af841d0ade52fa6c58c277bb74a2cc87ea14b72
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalRegionFunctionContext.java 22349256f46487ffb25780a82c8778f9d97418b3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/MemberFunctionExecutor.java ac628a0ff429303f8ab31ee9028605bf95e1b765
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/MultiRegionFunctionExecutor.java 192916997f3ffd1639d7f47880476dfd1c9923ea
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/RegionFunctionContextImpl.java 175e863c2a575626716bbc638749356c49be02a8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/ServerFunctionExecutor.java 9c06bf67b0cdbab53e26de11034cd12b644966e8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/ContainsKeyValueMessage.java 4a9c684a49e6e7715d0d583977ab317aa94c9a60
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/DestroyMessage.java c706a3c7d5c14377587aaa6b336ba08c2382f34f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchBulkEntriesMessage.java ea47e91a53ded0ed03781e8ff83b7e7bd8146fb4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessage.java d27e33e32a113bbead7340c54d8e27c8d6fb3339
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntryMessage.java ae363ba53eebad4911f6b2685f804bae2eca2899
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchKeysMessage.java d7c7d71f4aa50584dc39a0ebeea563dccdd40dc8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/GetMessage.java 3fef79004cbca788fcd6b9368c8b193043210f02
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/InvalidateMessage.java 60508c170afe4fa83a8c46c22706e852bcade1c4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PREntriesIterator.java ec2a8dbf18801ed567172c1a0ec3a3daeb08bf5d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PRUpdateEntryVersionMessage.java e1766dc036e864d5ec77aeb32b09ab4537e70f48
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessage.java 626efefc1921cac2919c56ed415707a426b5ea50
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PutAllPRMessage.java 8aaf587a7f72ca60bb2e4a754592ecf8991e5608
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PutMessage.java a6a39dc902027040e4aa49359915f04c9273bff7
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RegionAdvisor.java 03df3fb122f981864e583b9d698ac2f2a9cdede8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RemoteFetchKeysMessage.java ac95e03830ae386cbce04bf9cdc0091568a90e67
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RemoveAllPRMessage.java fb46e0c85a3785dc7aae251f1ecf04edd0f89e54
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/rebalance/PartitionedRegionLoadModel.java 1cfa4a4927b33540efb3f5b952975e0052daeb76
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/GatewayReceiverCommand.java 448be9247cdf9b36ec75899c999f631eec48db0e
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tx/DistTxEntryEvent.java 6e7c21cbd9546cd812ba131aca0a4686bd98bb08
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySender.java 713023ff42cc91295c7767716d111211fdd367c6
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java 2ef5e19a7ea22f84fb1a7b29e5cbe224aaaaf847
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventCallbackArgument.java f6f8d885ff85450346553d49cbb71a9d2f4c6479
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventImpl.java 09d68f547c816747a5a4692ed389afe470982fe3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java 46ff2636dda03d58d7401b196a75e89094de6171
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/RegionAttributesCreation.java 4dfe6aee4c707fc14b6a4cec1f994db690e3b319
> geode-core/src/main/java/com/gemstone/gemfire/internal/i18n/LocalizedStrings.java d3d232ee71390ddc424b4e78a5f907ea974d7e4b
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/LoggingThreadGroup.java 48c0eac3b0862a835dbf30cf3a872f37a9b07017
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/ManagerLogWriter.java 28419fc2eaa17d0836c4c2bb1c295d1f6e80b1ce
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/PureLogWriter.java 3279bf622b51bed1a36438da39df241d8eb55770
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapHelper.java 0f33d5a7d91d2ae16f6864b55054386b56bd80ca
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImpl.java 571c2d1a9aa1f7fe1ece1fb46e1b691d18de72e7
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/annotations/OffHeapIdentifier.java e275467a67fd51aeee637b65f79f360783562bd5
> geode-core/src/main/java/com/gemstone/gemfire/internal/shared/NativeCalls.java f0fc27aac1c7613142fd6a3394860921cf9fbef3
> geode-core/src/main/java/com/gemstone/gemfire/internal/util/ArrayUtils.java 4f15b17dfe9d38f6de878e42cac043ad1e5101aa
> geode-core/src/main/java/com/gemstone/gemfire/internal/util/concurrent/CustomEntryConcurrentHashMap.java 144c7a3a4d9e840889a9ddcac5821f9e3e1caf60
> geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java e11233770d8fc812706cc29b2e288e6305a2fe7b
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 3a06c1c13745f6d6477ff61176d5986ae29d01d6
> geode-core/src/test/java/com/gemstone/gemfire/disttx/DistributedTransactionDUnitTest.java 33306d8c7241c061038fc130cbbcec377b34d906
> geode-core/src/test/java/com/gemstone/gemfire/internal/BackwardCompatibilitySerializationDUnitTest.java 07f87a3fbccaeab722c8d19ea9803387dc0b6da4
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRCustomPartitioningDUnitTest.java 12a143d9ad362e93457d364c302d062e2c23d4f7
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessageJUnitTest.java e08a26808f13124940faffa994a511562a64729b
> geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedDataSerializables.txt d2204a0f5a7673a909a48dc7f846377d0ce88d4d
> geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedSerializables.txt 89305acea1887fcf2edba17b91362bbfc53c5703
>
> Diff: https://reviews.apache.org/r/48189/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 48189: remove sqlf, sql fabric,
gemfirexd from geode-core
Posted by Scott Jewell <sj...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48189/#review136326
-----------------------------------------------------------
Ship it!
Page 4 reviewed - looks good
- Scott Jewell
On June 2, 2016, 10:20 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48189/
> -----------------------------------------------------------
>
> (Updated June 2, 2016, 10:20 p.m.)
>
>
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
>
>
> Bugs: GEODE-1464
> https://issues.apache.org/jira/browse/GEODE-1464
>
>
> Repository: geode
>
>
> Description
> -------
>
> removed internal Delta (only used by sqlf)
> removed sqlfDisconnectListener
> removed getStringForSQLF
> removed sqlfabric.sys-disk-dir system property
> removed unInitializedMembers and deferredVolunteerForPrimary
> removed sqlf serialization code
> removed GemFireUtilLauncher
> removed afterValueOverflow
> removed preferObject, eager deserialize, and KeyWithRegionContext
> removed unused sqlf methods in PartitionedRegion
> removed memberUnInitialized
> removed sqlf from DiskEntry
> removed setCallbackArgument from EntryOperationImpl
> removed distributeUpdatedProfileOnHubCreation
> removed getEntriesInTxForSqlFabric
> removed withRoutingObjects and hasRoutingObjects
> removed resetBucketAdvisorParents
> rebalance no longer calls GemFireCacheImpl.getInstance comments
> removed sqlf log messages
> removed sqlf OffHeapIdentifiers
> removed SqlfSerializationException from sanctionedSerializables
> removed static helper methods from DiskWriteAttributesImpl
> removed contextObject from EntryEventImpl
> remove serializeCallbackArg from WrappedCallbackArgument since it was always true
> removed getLeaderRegionName and getColocatedRegionName
> removed newPutEntryEvent
> removed clearLocalPrimaries
> removed call to non-existent OSProcess$NativeOSCalls
> removed putDML
> removed getClassesToSerializers
> simplified cleanUpOnImcompleteOp
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/IndexUpdater.java facbdf2cecd699361c3cc7782a38ab21d436637e
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionMessage.java bb36b8023b050f17e2d8e742875c736bcabf7755
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java 552dbe3e2aeda91a6dbce7d0f27e07c038f683cc
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ReplyProcessor21.java e5e8cbfb9ab734d93fea991b1d6715b9a7b31a9e
> geode-core/src/main/java/com/gemstone/gemfire/internal/DSCODE.java 8d91c6b7e616e42f0c92da07492c2ade4d8e3e6f
> geode-core/src/main/java/com/gemstone/gemfire/internal/DSFIDFactory.java bd78f5ae78953fab616f2ada870aa1aa920d56f3
> geode-core/src/main/java/com/gemstone/gemfire/internal/DataSerializableFixedID.java 7427f9009dfb732971970a518a2a27adc81c62cd
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireUtilLauncher.java fa19049a8f2e1af70250a7c18abe3d4fa8d27a26
> geode-core/src/main/java/com/gemstone/gemfire/internal/InternalDataSerializer.java bff592b5ac8dc98f7bcd716910ae4c776fadb358
> geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java 515b27dcf0ff38ea5f1024f7ba8b7262172c203a
> geode-core/src/main/java/com/gemstone/gemfire/internal/Version.java 258eaf0e683da7ce4025f5cf388574935dcc3bc4
> geode-core/src/main/java/com/gemstone/gemfire/internal/VersionedDataStream.java a2711ffee9e7575edeff8cd921a3168883ce9ec8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractDiskRegionEntry.java b65b7addc4d572b262b0a0a8a99ee4a79ac0390f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java 25cc818603e5a4f1a0a10f57a2861afb0599bd81
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java 0cbec19408198a5d4fc7f975b43ad4075e29a580
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketAdvisor.java c241c6b7760e0cde59facd7f708c716f563eb2a9
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java e2482bb5592546d280c6f3fb73f7775e9a174afd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheDistributionAdvisor.java 4a34771388da63a648c6d7763fc39334aa716b38
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerLauncher.java d4c19ce6e0d464e90fd62935e00e7a7be72ce659
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CachedDeserializableFactory.java 84e44d84807ae05440edd664d1a4b0ab79bf9ea0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationHelper.java 72edc1076c5480a665bba39af21ee87da7635372
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DestroyOperation.java e26719076eb0c49ae364da951f72fef7bf136a42
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java 54ecb0434298ab6af2af8724a33048732735fc7d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskInitFile.java 7e2333e779db4a46d0fe1f88d7ae61c7831fde5a
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskRegion.java c1d2f038992680e94cc5605ade0ae11bb3796531
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskWriteAttributesImpl.java 914c8781ed979be5903b0818750a88dfe2073451
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistTXState.java cafdb805e97fa1e9c5a35e7efe663f1059a6d429
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistTXStateOnCoordinator.java 33bec1c27d574ee963d488123d8b0ab08b9548ea
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedCacheOperation.java 6a7b4f2f7192613b5f90d46274a0875d7483d074
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedPutAllOperation.java b6aa1b644784639973d3232b6e354937d7bd4ac7
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegion.java cc86e2c9381091e33bd877e42fe4a39677644922
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegionFunctionStreamingMessage.java e51bedd4fc621a416a1a2df8b86c876f33b15bfe
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRemoveAllOperation.java 1d216ce63948d8276295de0559307cfb05c2c01c
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryBits.java f95af608efee479aad2038a501c5dae1183bec63
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java 68c8117b45b2319eca861205a1e9e69602738edf
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryOperationImpl.java d539366476014243dbd77ff825b6e8b0eb93cf5f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 76a27298fba3f6c2b4c6d1d3fdfdfde6216e0797
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GridAdvisor.java fd350a0fffd17637a7484690e545689bf8dcbefd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InitialImageOperation.java b43ba2d510275eeb78530e1b81cb62321c2338cf
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InternalRegionArguments.java f7d46feac4a1f4880c6bd1f91b7aaa5b4ddb5f66
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InvalidateOperation.java 6e1d91e426dc6a78da1cc936bb9cef08f3206a06
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/KeyInfo.java 30f30fcb237f7e5bd665e0c329fc39771a959af1
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/KeyWithRegionContext.java b28a551a6703e9a27fe169eacc39185c0addda74
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ListOfDeltas.java 6592863f286cf66bfd634957343b16833568b03b
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java cc5ac59e9390542f593becd37e332d7b63c350d5
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/Oplog.java 96f616b4a2471bdf4e10d8b3cbcf52df59f58bc0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PRHARedundancyProvider.java 6fe39b1e651b1d435ef95f329bd3558d0dbee1e1
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionAttributesImpl.java d1e2bd0ad27cb46c3c9c23bfd0584bfb0feaa013
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java ea207aea40aad944abd8fce572faed73e03f82e4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegionDataStore.java bda68e38fb6bd4f5f2b286ee23d85f4b8b3a4b26
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ProxyRegionMap.java 74c134b90134ded2a19c02440bb756754c3a019d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/QueuedOperation.java 2d5a69866825da65f77f3203adf69e29dc074c78
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionEntry.java 09aef2a02ae851573a9358f1f62c129dee1a3b00
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionMap.java a7c26073dbbc236e000dffd56024a32e957cb991
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteContainsKeyValueMessage.java acf87238a826760b5802516e3986bf26de9f9167
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteDestroyMessage.java f7109bb9b453beb78d4ac7510b3e7b9628a350f6
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteFetchEntryMessage.java 685f0a5ee6c7adeec16a275b0ebb9af217ee4db3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteFetchVersionMessage.java 12e4de6114ef1bb5f3327f65747b78d838b15f37
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteGetMessage.java b565a2cdc89f23b854fd2690f7265284dfd214dd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteInvalidateMessage.java c4ed1ccefa78de7e02531d1656171a05e224e7e0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutAllMessage.java ff09af9a7fa3b48cc673a64f505265ab3e8154ae
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutMessage.java 27f2bb96424bb588b53080f3a29860910d865cec
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteRemoveAllMessage.java 01e8d9e2341b300bd34d09e4fdcdf2a9bb19e330
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/SearchLoadAndWriteProcessor.java 6642ec61b66f1b5cec22704a3610351dba47909b
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEntry.java 2906ff6e03efb0d491ef1d8abe97dec2ae99f24a
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEntryState.java b6686d42a6ec1fd8a0797a17cc007bf006fb3a99
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRegionLockRequestImpl.java 29af5cc96334648a8a26b619d33da72ff3b82a74
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRegionState.java 116edf71e81f95150975f94f709186e427655b84
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXState.java e610991d12ddbe317f6894b71c27c84e09fc78ba
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXStateInterface.java 3fa935129ed1daefcbd163d34dc90962e4230894
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateAttributesProcessor.java 866eaffce1d20dc88e39f04cf4dd3154ebe78db2
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateEntryVersionOperation.java fce4deea5515bb6e6e9972648d09d15acaec77e8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateOperation.java 730d6d772c85e945050c627831f640d1e1b93ddc
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ValidatingDiskRegion.java 54133cc478a206bc30d7606cd0dfd52e9f7549d8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/WrappedCallbackArgument.java 99a5cebbf7189f22119f3eff2e7ce279d979f8cb
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/delta/Delta.java aeabbd8474ef211d03343058f8ff8e05496b72b4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/AbstractExecution.java ff736be3bcbee7e03d62dc2ddd6795e1c39cfb46
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/FunctionStreamingResultCollector.java 3874ad90f8c92602406e318ce9a43b58fc7bc635
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalExecution.java d3fd2f27ecaadc7fe1495365b4ec7e42aedea88f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalFunctionService.java 8af841d0ade52fa6c58c277bb74a2cc87ea14b72
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalRegionFunctionContext.java 22349256f46487ffb25780a82c8778f9d97418b3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/MemberFunctionExecutor.java ac628a0ff429303f8ab31ee9028605bf95e1b765
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/MultiRegionFunctionExecutor.java 192916997f3ffd1639d7f47880476dfd1c9923ea
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/RegionFunctionContextImpl.java 175e863c2a575626716bbc638749356c49be02a8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/ServerFunctionExecutor.java 9c06bf67b0cdbab53e26de11034cd12b644966e8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/ContainsKeyValueMessage.java 4a9c684a49e6e7715d0d583977ab317aa94c9a60
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/DestroyMessage.java c706a3c7d5c14377587aaa6b336ba08c2382f34f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchBulkEntriesMessage.java ea47e91a53ded0ed03781e8ff83b7e7bd8146fb4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessage.java d27e33e32a113bbead7340c54d8e27c8d6fb3339
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntryMessage.java ae363ba53eebad4911f6b2685f804bae2eca2899
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchKeysMessage.java d7c7d71f4aa50584dc39a0ebeea563dccdd40dc8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/GetMessage.java 3fef79004cbca788fcd6b9368c8b193043210f02
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/InvalidateMessage.java 60508c170afe4fa83a8c46c22706e852bcade1c4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PREntriesIterator.java ec2a8dbf18801ed567172c1a0ec3a3daeb08bf5d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PRUpdateEntryVersionMessage.java e1766dc036e864d5ec77aeb32b09ab4537e70f48
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessage.java 626efefc1921cac2919c56ed415707a426b5ea50
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PutAllPRMessage.java 8aaf587a7f72ca60bb2e4a754592ecf8991e5608
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PutMessage.java a6a39dc902027040e4aa49359915f04c9273bff7
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RegionAdvisor.java 03df3fb122f981864e583b9d698ac2f2a9cdede8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RemoteFetchKeysMessage.java ac95e03830ae386cbce04bf9cdc0091568a90e67
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RemoveAllPRMessage.java fb46e0c85a3785dc7aae251f1ecf04edd0f89e54
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/rebalance/PartitionedRegionLoadModel.java 1cfa4a4927b33540efb3f5b952975e0052daeb76
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/GatewayReceiverCommand.java 448be9247cdf9b36ec75899c999f631eec48db0e
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tx/DistTxEntryEvent.java 6e7c21cbd9546cd812ba131aca0a4686bd98bb08
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySender.java 713023ff42cc91295c7767716d111211fdd367c6
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java 2ef5e19a7ea22f84fb1a7b29e5cbe224aaaaf847
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventCallbackArgument.java f6f8d885ff85450346553d49cbb71a9d2f4c6479
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventImpl.java 09d68f547c816747a5a4692ed389afe470982fe3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java 46ff2636dda03d58d7401b196a75e89094de6171
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/RegionAttributesCreation.java 4dfe6aee4c707fc14b6a4cec1f994db690e3b319
> geode-core/src/main/java/com/gemstone/gemfire/internal/i18n/LocalizedStrings.java d3d232ee71390ddc424b4e78a5f907ea974d7e4b
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/LoggingThreadGroup.java 48c0eac3b0862a835dbf30cf3a872f37a9b07017
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/ManagerLogWriter.java 28419fc2eaa17d0836c4c2bb1c295d1f6e80b1ce
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/PureLogWriter.java 3279bf622b51bed1a36438da39df241d8eb55770
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapHelper.java 0f33d5a7d91d2ae16f6864b55054386b56bd80ca
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImpl.java 571c2d1a9aa1f7fe1ece1fb46e1b691d18de72e7
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/annotations/OffHeapIdentifier.java e275467a67fd51aeee637b65f79f360783562bd5
> geode-core/src/main/java/com/gemstone/gemfire/internal/shared/NativeCalls.java f0fc27aac1c7613142fd6a3394860921cf9fbef3
> geode-core/src/main/java/com/gemstone/gemfire/internal/util/ArrayUtils.java 4f15b17dfe9d38f6de878e42cac043ad1e5101aa
> geode-core/src/main/java/com/gemstone/gemfire/internal/util/concurrent/CustomEntryConcurrentHashMap.java 144c7a3a4d9e840889a9ddcac5821f9e3e1caf60
> geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java e11233770d8fc812706cc29b2e288e6305a2fe7b
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 3a06c1c13745f6d6477ff61176d5986ae29d01d6
> geode-core/src/test/java/com/gemstone/gemfire/disttx/DistributedTransactionDUnitTest.java 33306d8c7241c061038fc130cbbcec377b34d906
> geode-core/src/test/java/com/gemstone/gemfire/internal/BackwardCompatibilitySerializationDUnitTest.java 07f87a3fbccaeab722c8d19ea9803387dc0b6da4
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRCustomPartitioningDUnitTest.java 12a143d9ad362e93457d364c302d062e2c23d4f7
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessageJUnitTest.java e08a26808f13124940faffa994a511562a64729b
> geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedDataSerializables.txt d2204a0f5a7673a909a48dc7f846377d0ce88d4d
> geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedSerializables.txt 89305acea1887fcf2edba17b91362bbfc53c5703
>
> Diff: https://reviews.apache.org/r/48189/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 48189: remove sqlf, sql fabric,
gemfirexd from geode-core
Posted by Eric Shu <es...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48189/#review136373
-----------------------------------------------------------
Ship it!
- Eric Shu
On June 2, 2016, 10:20 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48189/
> -----------------------------------------------------------
>
> (Updated June 2, 2016, 10:20 p.m.)
>
>
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
>
>
> Bugs: GEODE-1464
> https://issues.apache.org/jira/browse/GEODE-1464
>
>
> Repository: geode
>
>
> Description
> -------
>
> removed internal Delta (only used by sqlf)
> removed sqlfDisconnectListener
> removed getStringForSQLF
> removed sqlfabric.sys-disk-dir system property
> removed unInitializedMembers and deferredVolunteerForPrimary
> removed sqlf serialization code
> removed GemFireUtilLauncher
> removed afterValueOverflow
> removed preferObject, eager deserialize, and KeyWithRegionContext
> removed unused sqlf methods in PartitionedRegion
> removed memberUnInitialized
> removed sqlf from DiskEntry
> removed setCallbackArgument from EntryOperationImpl
> removed distributeUpdatedProfileOnHubCreation
> removed getEntriesInTxForSqlFabric
> removed withRoutingObjects and hasRoutingObjects
> removed resetBucketAdvisorParents
> rebalance no longer calls GemFireCacheImpl.getInstance comments
> removed sqlf log messages
> removed sqlf OffHeapIdentifiers
> removed SqlfSerializationException from sanctionedSerializables
> removed static helper methods from DiskWriteAttributesImpl
> removed contextObject from EntryEventImpl
> remove serializeCallbackArg from WrappedCallbackArgument since it was always true
> removed getLeaderRegionName and getColocatedRegionName
> removed newPutEntryEvent
> removed clearLocalPrimaries
> removed call to non-existent OSProcess$NativeOSCalls
> removed putDML
> removed getClassesToSerializers
> simplified cleanUpOnImcompleteOp
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/IndexUpdater.java facbdf2cecd699361c3cc7782a38ab21d436637e
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionMessage.java bb36b8023b050f17e2d8e742875c736bcabf7755
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java 552dbe3e2aeda91a6dbce7d0f27e07c038f683cc
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ReplyProcessor21.java e5e8cbfb9ab734d93fea991b1d6715b9a7b31a9e
> geode-core/src/main/java/com/gemstone/gemfire/internal/DSCODE.java 8d91c6b7e616e42f0c92da07492c2ade4d8e3e6f
> geode-core/src/main/java/com/gemstone/gemfire/internal/DSFIDFactory.java bd78f5ae78953fab616f2ada870aa1aa920d56f3
> geode-core/src/main/java/com/gemstone/gemfire/internal/DataSerializableFixedID.java 7427f9009dfb732971970a518a2a27adc81c62cd
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireUtilLauncher.java fa19049a8f2e1af70250a7c18abe3d4fa8d27a26
> geode-core/src/main/java/com/gemstone/gemfire/internal/InternalDataSerializer.java bff592b5ac8dc98f7bcd716910ae4c776fadb358
> geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java 515b27dcf0ff38ea5f1024f7ba8b7262172c203a
> geode-core/src/main/java/com/gemstone/gemfire/internal/Version.java 258eaf0e683da7ce4025f5cf388574935dcc3bc4
> geode-core/src/main/java/com/gemstone/gemfire/internal/VersionedDataStream.java a2711ffee9e7575edeff8cd921a3168883ce9ec8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractDiskRegionEntry.java b65b7addc4d572b262b0a0a8a99ee4a79ac0390f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java 25cc818603e5a4f1a0a10f57a2861afb0599bd81
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java 0cbec19408198a5d4fc7f975b43ad4075e29a580
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketAdvisor.java c241c6b7760e0cde59facd7f708c716f563eb2a9
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java e2482bb5592546d280c6f3fb73f7775e9a174afd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheDistributionAdvisor.java 4a34771388da63a648c6d7763fc39334aa716b38
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerLauncher.java d4c19ce6e0d464e90fd62935e00e7a7be72ce659
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CachedDeserializableFactory.java 84e44d84807ae05440edd664d1a4b0ab79bf9ea0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationHelper.java 72edc1076c5480a665bba39af21ee87da7635372
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DestroyOperation.java e26719076eb0c49ae364da951f72fef7bf136a42
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java 54ecb0434298ab6af2af8724a33048732735fc7d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskInitFile.java 7e2333e779db4a46d0fe1f88d7ae61c7831fde5a
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskRegion.java c1d2f038992680e94cc5605ade0ae11bb3796531
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskWriteAttributesImpl.java 914c8781ed979be5903b0818750a88dfe2073451
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistTXState.java cafdb805e97fa1e9c5a35e7efe663f1059a6d429
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistTXStateOnCoordinator.java 33bec1c27d574ee963d488123d8b0ab08b9548ea
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedCacheOperation.java 6a7b4f2f7192613b5f90d46274a0875d7483d074
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedPutAllOperation.java b6aa1b644784639973d3232b6e354937d7bd4ac7
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegion.java cc86e2c9381091e33bd877e42fe4a39677644922
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegionFunctionStreamingMessage.java e51bedd4fc621a416a1a2df8b86c876f33b15bfe
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRemoveAllOperation.java 1d216ce63948d8276295de0559307cfb05c2c01c
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryBits.java f95af608efee479aad2038a501c5dae1183bec63
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java 68c8117b45b2319eca861205a1e9e69602738edf
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryOperationImpl.java d539366476014243dbd77ff825b6e8b0eb93cf5f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 76a27298fba3f6c2b4c6d1d3fdfdfde6216e0797
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GridAdvisor.java fd350a0fffd17637a7484690e545689bf8dcbefd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InitialImageOperation.java b43ba2d510275eeb78530e1b81cb62321c2338cf
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InternalRegionArguments.java f7d46feac4a1f4880c6bd1f91b7aaa5b4ddb5f66
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InvalidateOperation.java 6e1d91e426dc6a78da1cc936bb9cef08f3206a06
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/KeyInfo.java 30f30fcb237f7e5bd665e0c329fc39771a959af1
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/KeyWithRegionContext.java b28a551a6703e9a27fe169eacc39185c0addda74
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ListOfDeltas.java 6592863f286cf66bfd634957343b16833568b03b
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java cc5ac59e9390542f593becd37e332d7b63c350d5
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/Oplog.java 96f616b4a2471bdf4e10d8b3cbcf52df59f58bc0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PRHARedundancyProvider.java 6fe39b1e651b1d435ef95f329bd3558d0dbee1e1
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionAttributesImpl.java d1e2bd0ad27cb46c3c9c23bfd0584bfb0feaa013
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java ea207aea40aad944abd8fce572faed73e03f82e4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegionDataStore.java bda68e38fb6bd4f5f2b286ee23d85f4b8b3a4b26
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ProxyRegionMap.java 74c134b90134ded2a19c02440bb756754c3a019d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/QueuedOperation.java 2d5a69866825da65f77f3203adf69e29dc074c78
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionEntry.java 09aef2a02ae851573a9358f1f62c129dee1a3b00
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionMap.java a7c26073dbbc236e000dffd56024a32e957cb991
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteContainsKeyValueMessage.java acf87238a826760b5802516e3986bf26de9f9167
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteDestroyMessage.java f7109bb9b453beb78d4ac7510b3e7b9628a350f6
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteFetchEntryMessage.java 685f0a5ee6c7adeec16a275b0ebb9af217ee4db3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteFetchVersionMessage.java 12e4de6114ef1bb5f3327f65747b78d838b15f37
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteGetMessage.java b565a2cdc89f23b854fd2690f7265284dfd214dd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteInvalidateMessage.java c4ed1ccefa78de7e02531d1656171a05e224e7e0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutAllMessage.java ff09af9a7fa3b48cc673a64f505265ab3e8154ae
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutMessage.java 27f2bb96424bb588b53080f3a29860910d865cec
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteRemoveAllMessage.java 01e8d9e2341b300bd34d09e4fdcdf2a9bb19e330
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/SearchLoadAndWriteProcessor.java 6642ec61b66f1b5cec22704a3610351dba47909b
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEntry.java 2906ff6e03efb0d491ef1d8abe97dec2ae99f24a
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEntryState.java b6686d42a6ec1fd8a0797a17cc007bf006fb3a99
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRegionLockRequestImpl.java 29af5cc96334648a8a26b619d33da72ff3b82a74
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRegionState.java 116edf71e81f95150975f94f709186e427655b84
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXState.java e610991d12ddbe317f6894b71c27c84e09fc78ba
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXStateInterface.java 3fa935129ed1daefcbd163d34dc90962e4230894
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateAttributesProcessor.java 866eaffce1d20dc88e39f04cf4dd3154ebe78db2
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateEntryVersionOperation.java fce4deea5515bb6e6e9972648d09d15acaec77e8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateOperation.java 730d6d772c85e945050c627831f640d1e1b93ddc
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ValidatingDiskRegion.java 54133cc478a206bc30d7606cd0dfd52e9f7549d8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/WrappedCallbackArgument.java 99a5cebbf7189f22119f3eff2e7ce279d979f8cb
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/delta/Delta.java aeabbd8474ef211d03343058f8ff8e05496b72b4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/AbstractExecution.java ff736be3bcbee7e03d62dc2ddd6795e1c39cfb46
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/FunctionStreamingResultCollector.java 3874ad90f8c92602406e318ce9a43b58fc7bc635
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalExecution.java d3fd2f27ecaadc7fe1495365b4ec7e42aedea88f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalFunctionService.java 8af841d0ade52fa6c58c277bb74a2cc87ea14b72
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/InternalRegionFunctionContext.java 22349256f46487ffb25780a82c8778f9d97418b3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/MemberFunctionExecutor.java ac628a0ff429303f8ab31ee9028605bf95e1b765
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/MultiRegionFunctionExecutor.java 192916997f3ffd1639d7f47880476dfd1c9923ea
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/RegionFunctionContextImpl.java 175e863c2a575626716bbc638749356c49be02a8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/ServerFunctionExecutor.java 9c06bf67b0cdbab53e26de11034cd12b644966e8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/ContainsKeyValueMessage.java 4a9c684a49e6e7715d0d583977ab317aa94c9a60
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/DestroyMessage.java c706a3c7d5c14377587aaa6b336ba08c2382f34f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchBulkEntriesMessage.java ea47e91a53ded0ed03781e8ff83b7e7bd8146fb4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessage.java d27e33e32a113bbead7340c54d8e27c8d6fb3339
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntryMessage.java ae363ba53eebad4911f6b2685f804bae2eca2899
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchKeysMessage.java d7c7d71f4aa50584dc39a0ebeea563dccdd40dc8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/GetMessage.java 3fef79004cbca788fcd6b9368c8b193043210f02
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/InvalidateMessage.java 60508c170afe4fa83a8c46c22706e852bcade1c4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PREntriesIterator.java ec2a8dbf18801ed567172c1a0ec3a3daeb08bf5d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PRUpdateEntryVersionMessage.java e1766dc036e864d5ec77aeb32b09ab4537e70f48
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessage.java 626efefc1921cac2919c56ed415707a426b5ea50
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PutAllPRMessage.java 8aaf587a7f72ca60bb2e4a754592ecf8991e5608
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PutMessage.java a6a39dc902027040e4aa49359915f04c9273bff7
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RegionAdvisor.java 03df3fb122f981864e583b9d698ac2f2a9cdede8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RemoteFetchKeysMessage.java ac95e03830ae386cbce04bf9cdc0091568a90e67
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RemoveAllPRMessage.java fb46e0c85a3785dc7aae251f1ecf04edd0f89e54
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/rebalance/PartitionedRegionLoadModel.java 1cfa4a4927b33540efb3f5b952975e0052daeb76
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/GatewayReceiverCommand.java 448be9247cdf9b36ec75899c999f631eec48db0e
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tx/DistTxEntryEvent.java 6e7c21cbd9546cd812ba131aca0a4686bd98bb08
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySender.java 713023ff42cc91295c7767716d111211fdd367c6
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java 2ef5e19a7ea22f84fb1a7b29e5cbe224aaaaf847
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventCallbackArgument.java f6f8d885ff85450346553d49cbb71a9d2f4c6479
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventImpl.java 09d68f547c816747a5a4692ed389afe470982fe3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java 46ff2636dda03d58d7401b196a75e89094de6171
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/RegionAttributesCreation.java 4dfe6aee4c707fc14b6a4cec1f994db690e3b319
> geode-core/src/main/java/com/gemstone/gemfire/internal/i18n/LocalizedStrings.java d3d232ee71390ddc424b4e78a5f907ea974d7e4b
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/LoggingThreadGroup.java 48c0eac3b0862a835dbf30cf3a872f37a9b07017
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/ManagerLogWriter.java 28419fc2eaa17d0836c4c2bb1c295d1f6e80b1ce
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/PureLogWriter.java 3279bf622b51bed1a36438da39df241d8eb55770
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapHelper.java 0f33d5a7d91d2ae16f6864b55054386b56bd80ca
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImpl.java 571c2d1a9aa1f7fe1ece1fb46e1b691d18de72e7
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/annotations/OffHeapIdentifier.java e275467a67fd51aeee637b65f79f360783562bd5
> geode-core/src/main/java/com/gemstone/gemfire/internal/shared/NativeCalls.java f0fc27aac1c7613142fd6a3394860921cf9fbef3
> geode-core/src/main/java/com/gemstone/gemfire/internal/util/ArrayUtils.java 4f15b17dfe9d38f6de878e42cac043ad1e5101aa
> geode-core/src/main/java/com/gemstone/gemfire/internal/util/concurrent/CustomEntryConcurrentHashMap.java 144c7a3a4d9e840889a9ddcac5821f9e3e1caf60
> geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java e11233770d8fc812706cc29b2e288e6305a2fe7b
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 3a06c1c13745f6d6477ff61176d5986ae29d01d6
> geode-core/src/test/java/com/gemstone/gemfire/disttx/DistributedTransactionDUnitTest.java 33306d8c7241c061038fc130cbbcec377b34d906
> geode-core/src/test/java/com/gemstone/gemfire/internal/BackwardCompatibilitySerializationDUnitTest.java 07f87a3fbccaeab722c8d19ea9803387dc0b6da4
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRCustomPartitioningDUnitTest.java 12a143d9ad362e93457d364c302d062e2c23d4f7
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessageJUnitTest.java e08a26808f13124940faffa994a511562a64729b
> geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedDataSerializables.txt d2204a0f5a7673a909a48dc7f846377d0ce88d4d
> geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedSerializables.txt 89305acea1887fcf2edba17b91362bbfc53c5703
>
> Diff: https://reviews.apache.org/r/48189/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>