[jira] [Commented] (HELIX-483) Simplify logical config classes

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HELIX-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14077061#comment-14077061 ] 

Hudson commented on HELIX-483:
------------------------------

UNSTABLE: Integrated in helix #1269 (See [https://builds.apache.org/job/helix/1269/])
[HELIX-483] Simplify logical config classes (kanak: rev ff958b19f0911ad337439616ada746eee7c95e23)
* helix-core/src/main/java/org/apache/helix/api/Participant.java
* helix-core/src/main/java/org/apache/helix/model/ResourceConfiguration.java
* helix-core/src/test/java/org/apache/helix/controller/stages/TestMsgSelectionStage.java
* helix-core/src/main/java/org/apache/helix/api/Controller.java
* helix-core/src/main/java/org/apache/helix/api/Resource.java
* helix-core/src/test/java/org/apache/helix/api/TestUpdateConfig.java
* helix-core/src/main/java/org/apache/helix/controller/stages/MessageSelectionStage.java
* helix-core/src/main/java/org/apache/helix/controller/stages/ResourceComputationStage.java
* helix-core/src/main/java/org/apache/helix/api/config/ResourceConfig.java
* helix-core/src/test/java/org/apache/helix/controller/strategy/TestNewAutoRebalanceStrategy.java
* helix-core/src/main/java/org/apache/helix/api/RunningInstance.java
* helix-core/src/test/java/org/apache/helix/controller/stages/BaseStageTest.java
* helix-core/src/main/java/org/apache/helix/api/Cluster.java
* helix-core/src/test/java/org/apache/helix/integration/task/TestTaskRebalancer.java
* helix-core/src/main/java/org/apache/helix/api/config/ClusterConfig.java
* helix-provisioning/src/main/java/org/apache/helix/provisioning/yarn/NMCallbackHandler.java
* helix-core/src/main/java/org/apache/helix/controller/stages/ExternalViewComputeStage.java
* recipes/jobrunner-yarn/src/main/java/org/apache/helix/provisioning/yarn/example/JobRunnerMain.java
* helix-core/src/main/java/org/apache/helix/controller/rebalancer/util/ConstraintBasedAssignment.java
* helix-core/src/main/java/org/apache/helix/api/accessor/ClusterAccessor.java
* helix-core/src/main/java/org/apache/helix/controller/stages/CurrentStateComputationStage.java
* helix-core/src/test/java/org/apache/helix/api/TestNamespacedConfig.java
* helix-core/src/main/java/org/apache/helix/controller/stages/TaskAssignmentStage.java
* helix-core/src/main/java/org/apache/helix/api/config/ParticipantConfig.java
* helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationStage.java
* helix-provisioning/src/main/java/org/apache/helix/provisioning/tools/ContainerAdmin.java
* helix-core/src/main/java/org/apache/helix/task/TaskRebalancer.java
* helix-core/src/test/java/org/apache/helix/api/accessor/TestAtomicAccessors.java
* helix-core/src/main/java/org/apache/helix/controller/stages/CompatibilityCheckStage.java
* helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java
* helix-examples/src/main/java/org/apache/helix/examples/LogicalModelExample.java
* helix-core/src/main/java/org/apache/helix/controller/stages/ContainerProvisioningStage.java


> Simplify logical config classes
> -------------------------------
>
>                 Key: HELIX-483
>                 URL: https://issues.apache.org/jira/browse/HELIX-483
>             Project: Apache Helix
>          Issue Type: Sub-task
>            Reporter: Kanak Biscuitwala
>            Assignee: Kanak Biscuitwala
>              Labels: kanban
>
> There is a large amount of code duplication in the config classes and that makes everything harder to maintain. We should keep these classes small and just be essentially wrappers on the physical model, but with the benefit of being an aggregation of multiple physical model classes.



--
This message was sent by Atlassian JIRA
(v6.2#6252)