You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "Tom White (JIRA)" <ji...@apache.org> on 2011/06/02 22:51:47 UTC
[jira] [Created] (WHIRR-321) Run findbugs
Run findbugs
------------
Key: WHIRR-321
URL: https://issues.apache.org/jira/browse/WHIRR-321
Project: Whirr
Issue Type: Improvement
Reporter: Tom White
We should run findbugs on the source code and fix any violations.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-321) Run findbugs
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-321:
------------------------------
Fix Version/s: 0.6.0
Status: Patch Available (was: Open)
> Run findbugs
> ------------
>
> Key: WHIRR-321
> URL: https://issues.apache.org/jira/browse/WHIRR-321
> Project: Whirr
> Issue Type: Improvement
> Reporter: Tom White
> Assignee: Andrei Savu
> Fix For: 0.6.0
>
> Attachments: WHIRR-321.patch
>
>
> We should run findbugs on the source code and fix any violations.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-321) Run findbugs
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-321:
------------------------------
Fix Version/s: (was: 0.6.0)
Moving out of 0.6.0 until we can reach consensus.
> Run findbugs
> ------------
>
> Key: WHIRR-321
> URL: https://issues.apache.org/jira/browse/WHIRR-321
> Project: Whirr
> Issue Type: Improvement
> Reporter: Tom White
> Assignee: Andrei Savu
> Attachments: WHIRR-321.patch, WHIRR-321.patch
>
>
> We should run findbugs on the source code and fix any violations.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-321) Run findbugs
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-321:
------------------------------
Attachment: WHIRR-321.patch
Downgraded findbugs to version 2.3.2. Everything looks fine on maven 3 (build & checks).
On maven 2.2.1 findbugs:check finds some irrelevant issues that are ignored when running inside maven3.
Do we really need to support both maven2 and maven3? I guess this is going to be difficult.
> Run findbugs
> ------------
>
> Key: WHIRR-321
> URL: https://issues.apache.org/jira/browse/WHIRR-321
> Project: Whirr
> Issue Type: Improvement
> Reporter: Tom White
> Assignee: Andrei Savu
> Fix For: 0.6.0
>
> Attachments: WHIRR-321.patch, WHIRR-321.patch
>
>
> We should run findbugs on the source code and fix any violations.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-321) Run findbugs
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044400#comment-13044400 ]
Andrei Savu commented on WHIRR-321:
-----------------------------------
It works for me with Maven 3. I will try with Maven 2 later and look for an workaround so that it works on both versions.
> Run findbugs
> ------------
>
> Key: WHIRR-321
> URL: https://issues.apache.org/jira/browse/WHIRR-321
> Project: Whirr
> Issue Type: Improvement
> Reporter: Tom White
> Assignee: Andrei Savu
> Fix For: 0.6.0
>
> Attachments: WHIRR-321.patch
>
>
> We should run findbugs on the source code and fix any violations.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-321) Run findbugs
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044341#comment-13044341 ]
Tom White commented on WHIRR-321:
---------------------------------
I get an error trying to download org.codehaus.mojo:findbugs-maven-plugin:pom:2.3.3-SNAPSHOT - (it's not in Maven Central) - did you add another repository? (This is with Maven 2).
When I downgrade to version 2.3.2 of the plugin it doesn't generate a report with "mvn site" nor with "mvn findbugs:check".
I think we should run this check just before committing a new change, so we'll need to update the wiki with instructions.
> Run findbugs
> ------------
>
> Key: WHIRR-321
> URL: https://issues.apache.org/jira/browse/WHIRR-321
> Project: Whirr
> Issue Type: Improvement
> Reporter: Tom White
> Assignee: Andrei Savu
> Fix For: 0.6.0
>
> Attachments: WHIRR-321.patch
>
>
> We should run findbugs on the source code and fix any violations.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-321) Run findbugs
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-321:
------------------------------
Attachment: WHIRR-321.patch
I've added findbugs to the reporting section in the parent pom and I have fixed all the existing issues.
> Run findbugs
> ------------
>
> Key: WHIRR-321
> URL: https://issues.apache.org/jira/browse/WHIRR-321
> Project: Whirr
> Issue Type: Improvement
> Reporter: Tom White
> Assignee: Andrei Savu
> Fix For: 0.6.0
>
> Attachments: WHIRR-321.patch
>
>
> We should run findbugs on the source code and fix any violations.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-321) Run findbugs
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated WHIRR-321:
----------------------------
Attachment: WHIRR-321.patch
I updated the patch to require Maven 3, but it's not publishing the project reports. This looks relevant: http://maven.apache.org/plugins/maven-site-plugin/maven-3.html.
> Run findbugs
> ------------
>
> Key: WHIRR-321
> URL: https://issues.apache.org/jira/browse/WHIRR-321
> Project: Whirr
> Issue Type: Improvement
> Reporter: Tom White
> Assignee: Andrei Savu
> Attachments: WHIRR-321.patch, WHIRR-321.patch, WHIRR-321.patch
>
>
> We should run findbugs on the source code and fix any violations.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (WHIRR-321) Run findbugs
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu reassigned WHIRR-321:
---------------------------------
Assignee: Andrei Savu
> Run findbugs
> ------------
>
> Key: WHIRR-321
> URL: https://issues.apache.org/jira/browse/WHIRR-321
> Project: Whirr
> Issue Type: Improvement
> Reporter: Tom White
> Assignee: Andrei Savu
>
> We should run findbugs on the source code and fix any violations.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-321) Run findbugs
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045568#comment-13045568 ]
Tom White commented on WHIRR-321:
---------------------------------
I would be OK requiring Maven 3. What do others think?
> Run findbugs
> ------------
>
> Key: WHIRR-321
> URL: https://issues.apache.org/jira/browse/WHIRR-321
> Project: Whirr
> Issue Type: Improvement
> Reporter: Tom White
> Assignee: Andrei Savu
> Fix For: 0.6.0
>
> Attachments: WHIRR-321.patch, WHIRR-321.patch
>
>
> We should run findbugs on the source code and fix any violations.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira