[GitHub] [incubator-superset] graceguo-supercat commented on pull request #9637: [WIP][explore view] add partition as adhoc filter option

[GitBox <gi...@apache.org>]

graceguo-supercat commented on pull request #9637:
URL: https://github.com/apache/incubator-superset/pull/9637#issuecomment-619165165


   > Instead of adding a new tab, how about making the filter value an option list with a "Latest partition" option:
   
   I can answer this first. Currently adhocFilter object has 2 type: `SIMPLE` and `SQL`, and they are not _interchangeable_. For example, a SQL type adhocFilter with expression `ds < '2020-04-01'` doesn't convert to SIMPLE type with `ds`, `equals` and `2020-04-01` 3 parts. I think this is because many SQL cannot easily converted to those 3 pre-defined parts in Simple type. SQL expression's subject doesn't have to be in the simple mode dropdown list.
   
   Actually I did try to use simple mode. But because i saw a few cases in airbnb that partition columns are not in the simple mode columns list so i gave up.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org