You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/04/16 00:41:18 UTC
[kudu-CR] WIP [docs] updated master-related scenarios w.r.t. CM
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13022
Change subject: WIP [docs] updated master-related scenarios w.r.t. CM
......................................................................
WIP [docs] updated master-related scenarios w.r.t. CM
WIP: Do we need to mention CM in the upstream doc at all?
Maybe, we should remove all CM-related references
from this doc?
Change-Id: I96bf3ec0de07a46151f947a18b9466da5f05adb3
---
M docs/administration.adoc
1 file changed, 8 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/13022/1
--
To view, visit http://gerrit.cloudera.org:8080/13022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I96bf3ec0de07a46151f947a18b9466da5f05adb3
Gerrit-Change-Number: 13022
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [docs] updated master-related scenarios w.r.t. CM roles
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13022
to look at the new patch set (#2).
Change subject: [docs] updated master-related scenarios w.r.t. CM roles
......................................................................
[docs] updated master-related scenarios w.r.t. CM roles
Updated documention on multi-master recovery troubleshooting scenarios
to mention the necessity to remove Kudu Master roles from dead nodes
if using CM. Other minor updates to help avoid inconsistencies between
the actual and gflags-provided lists of master nodes in Kudu cluster.
Change-Id: I96bf3ec0de07a46151f947a18b9466da5f05adb3
---
M docs/administration.adoc
1 file changed, 8 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/13022/2
--
To view, visit http://gerrit.cloudera.org:8080/13022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I96bf3ec0de07a46151f947a18b9466da5f05adb3
Gerrit-Change-Number: 13022
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] WIP [docs] updated master-related scenarios w.r.t. CM
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13022 )
Change subject: WIP [docs] updated master-related scenarios w.r.t. CM
......................................................................
Patch Set 1: Verified+1
unrelated test flake
--
To view, visit http://gerrit.cloudera.org:8080/13022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I96bf3ec0de07a46151f947a18b9466da5f05adb3
Gerrit-Change-Number: 13022
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 16 Apr 2019 03:06:10 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] updated master-related scenarios w.r.t. CM roles
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [docs] updated master-related scenarios w.r.t. CM roles
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I96bf3ec0de07a46151f947a18b9466da5f05adb3
Gerrit-Change-Number: 13022
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [docs] updated master-related scenarios w.r.t. CM roles
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13022 )
Change subject: [docs] updated master-related scenarios w.r.t. CM roles
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13022/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/13022/1/docs/administration.adoc@754
PS1, Line 754: run-time flag
> Nit: I think "configuration parameter", "parameter", or "flag" are better o
Think you missed this comment.
--
To view, visit http://gerrit.cloudera.org:8080/13022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I96bf3ec0de07a46151f947a18b9466da5f05adb3
Gerrit-Change-Number: 13022
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 18 Apr 2019 18:24:57 +0000
Gerrit-HasComments: Yes
[kudu-CR] WIP [docs] updated master-related scenarios w.r.t. CM
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13022 )
Change subject: WIP [docs] updated master-related scenarios w.r.t. CM
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13022/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13022/1//COMMIT_MSG@9
PS1, Line 9: WIP: Do we need to mention CM in the upstream doc at all?
: Maybe, we should remove all CM-related references
: from this doc?
Maybe. But this patch is a strict improvement over what came before, so I feel like I can approve of it without wading into the larger conversation about whether CM should be mentioned at all.
http://gerrit.cloudera.org:8080/#/c/13022/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/13022/1/docs/administration.adoc@754
PS1, Line 754: run-time flag
Nit: I think "configuration parameter", "parameter", or "flag" are better options than "run-time flag" here and below.
--
To view, visit http://gerrit.cloudera.org:8080/13022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I96bf3ec0de07a46151f947a18b9466da5f05adb3
Gerrit-Change-Number: 13022
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 16 Apr 2019 22:42:50 +0000
Gerrit-HasComments: Yes
[kudu-CR] WIP [docs] updated master-related scenarios w.r.t. CM
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13022 )
Change subject: WIP [docs] updated master-related scenarios w.r.t. CM
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13022/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13022/1//COMMIT_MSG@9
PS1, Line 9: WIP: Do we need to mention CM in the upstream doc at all?
: Maybe, we should remove all CM-related references
: from this doc?
> How about generalizing it? Something like ‘if you’re using a cluster admini
Well, that generalization sounds good, but usually it boils down to something additional like '... general-blurb ... (e.g., remove Kudu Master Roles in CM)' because later on we should clarify about what 'remove old masters' mean in some particular case. Otherwise, there is not much value in adding vague generalizations which do not provide concrete enough information for people running DevOps, or in some cases might even confuse them.
I think for this patch we can do as Adar suggested: let's go forward with keeping the mention of CM as elsewhere in the document, and then move to next step, thinking about whether CM should or should not be mentioned, and what is the best resolution.
--
To view, visit http://gerrit.cloudera.org:8080/13022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I96bf3ec0de07a46151f947a18b9466da5f05adb3
Gerrit-Change-Number: 13022
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 17 Apr 2019 20:22:01 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] updated master-related scenarios w.r.t. CM roles
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13022 )
Change subject: [docs] updated master-related scenarios w.r.t. CM roles
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13022/2/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/13022/2/docs/administration.adoc@754
PS2, Line 754: run-time flag.
nit: To some, this might be conflated with being a flag users can change at runtime. Maybe "Master configuration" and "Tablet Server configuration"?
--
To view, visit http://gerrit.cloudera.org:8080/13022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I96bf3ec0de07a46151f947a18b9466da5f05adb3
Gerrit-Change-Number: 13022
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 18 Apr 2019 18:47:02 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] updated master-related scenarios w.r.t. CM roles
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13022 )
Change subject: [docs] updated master-related scenarios w.r.t. CM roles
......................................................................
Patch Set 2: Verified+1
unrelated test flakes
--
To view, visit http://gerrit.cloudera.org:8080/13022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I96bf3ec0de07a46151f947a18b9466da5f05adb3
Gerrit-Change-Number: 13022
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 18 Apr 2019 15:43:30 +0000
Gerrit-HasComments: No
[kudu-CR] WIP [docs] updated master-related scenarios w.r.t. CM
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13022 )
Change subject: WIP [docs] updated master-related scenarios w.r.t. CM
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13022/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13022/1//COMMIT_MSG@9
PS1, Line 9: WIP: Do we need to mention CM in the upstream doc at all?
: Maybe, we should remove all CM-related references
: from this doc?
> Maybe. But this patch is a strict improvement over what came before, so I f
How about generalizing it? Something like ‘if you’re using a cluster administration tool that automatically generates the list of masters based on where the masters are deployed, make sure to remove the old masters’
--
To view, visit http://gerrit.cloudera.org:8080/13022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I96bf3ec0de07a46151f947a18b9466da5f05adb3
Gerrit-Change-Number: 13022
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 17 Apr 2019 17:21:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] WIP [docs] updated master-related scenarios w.r.t. CM
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: WIP [docs] updated master-related scenarios w.r.t. CM
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I96bf3ec0de07a46151f947a18b9466da5f05adb3
Gerrit-Change-Number: 13022
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>