You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by is...@apache.org on 2019/12/16 14:50:22 UTC
[lucene-solr] branch master updated: SOLR-14096: Stopping
-Denable.packages=true from leaking to other tests
This is an automated email from the ASF dual-hosted git repository.
ishan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git
The following commit(s) were added to refs/heads/master by this push:
new ee0b066 SOLR-14096: Stopping -Denable.packages=true from leaking to other tests
ee0b066 is described below
commit ee0b066ab63ab21645b91c5a190b157fa56b6ca7
Author: Ishan Chattopadhyaya <is...@apache.org>
AuthorDate: Mon Dec 16 20:20:07 2019 +0530
SOLR-14096: Stopping -Denable.packages=true from leaking to other tests
---
.../org/apache/solr/filestore/TestDistribPackageStore.java | 13 ++++++++++++-
solr/core/src/test/org/apache/solr/pkg/TestPackages.java | 13 ++++++++++++-
2 files changed, 24 insertions(+), 2 deletions(-)
diff --git a/solr/core/src/test/org/apache/solr/filestore/TestDistribPackageStore.java b/solr/core/src/test/org/apache/solr/filestore/TestDistribPackageStore.java
index 64b1ef8..e90dd5e 100644
--- a/solr/core/src/test/org/apache/solr/filestore/TestDistribPackageStore.java
+++ b/solr/core/src/test/org/apache/solr/filestore/TestDistribPackageStore.java
@@ -47,6 +47,8 @@ import org.apache.solr.common.util.Utils;
import org.apache.solr.util.LogLevel;
import org.apache.zookeeper.CreateMode;
import org.apache.zookeeper.server.ByteBufferInputStream;
+import org.junit.After;
+import org.junit.Before;
import static org.apache.solr.common.util.Utils.JAVABINCONSUMER;
import static org.apache.solr.core.TestDynamicLoading.getFileContent;
@@ -54,8 +56,17 @@ import static org.apache.solr.core.TestDynamicLoading.getFileContent;
@LogLevel("org.apache.solr.filestore.PackageStoreAPI=DEBUG;org.apache.solr.filestore.DistribPackageStore=DEBUG")
public class TestDistribPackageStore extends SolrCloudTestCase {
- public void testPackageStoreManagement() throws Exception {
+ @Before
+ public void setup() {
System.setProperty("enable.packages", "true");
+ }
+
+ @After
+ public void teardown() {
+ System.clearProperty("enable.packages");
+ }
+
+ public void testPackageStoreManagement() throws Exception {
MiniSolrCloudCluster cluster =
configureCluster(4)
.withJettyConfig(jetty -> jetty.enableV2(true))
diff --git a/solr/core/src/test/org/apache/solr/pkg/TestPackages.java b/solr/core/src/test/org/apache/solr/pkg/TestPackages.java
index 9356d9d..baa8a99 100644
--- a/solr/core/src/test/org/apache/solr/pkg/TestPackages.java
+++ b/solr/core/src/test/org/apache/solr/pkg/TestPackages.java
@@ -54,6 +54,8 @@ import org.apache.solr.filestore.TestDistribPackageStore;
import org.apache.solr.util.LogLevel;
import org.apache.zookeeper.CreateMode;
import org.apache.zookeeper.data.Stat;
+import org.junit.After;
+import org.junit.Before;
import org.junit.Test;
import static org.apache.solr.common.cloud.ZkStateReader.SOLR_PKGS_PATH;
@@ -67,9 +69,18 @@ import static org.apache.solr.filestore.TestDistribPackageStore.waitForAllNodesH
//@org.apache.lucene.util.LuceneTestCase.AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/SOLR-13822") // leaks files
public class TestPackages extends SolrCloudTestCase {
+ @Before
+ public void setup() {
+ System.setProperty("enable.packages", "true");
+ }
+
+ @After
+ public void teardown() {
+ System.clearProperty("enable.packages");
+ }
+
@Test
public void testPluginLoading() throws Exception {
- System.setProperty("enable.packages", "true");
MiniSolrCloudCluster cluster =
configureCluster(4)
.withJettyConfig(jetty -> jetty.enableV2(true))