You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/06 04:45:49 UTC
[GitHub] [airflow] kevgeo opened a new pull request, #24860: Add blocksize arg for ftp hook #23935
kevgeo opened a new pull request, #24860:
URL: https://github.com/apache/airflow/pull/24860
This PR is for [issue #23935](https://github.com/apache/airflow/issues/23935) to add blocksize as an argument to transfer files from ftp server to local machine in user-defined chunks. I have also added blocksize as an argument to store_file() which transfers from local machine to ftp server as it is useful too.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #24860: Add blocksize arg for ftp hook
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #24860:
URL: https://github.com/apache/airflow/pull/24860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #24860: Add blocksize arg for ftp hook
Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #24860:
URL: https://github.com/apache/airflow/pull/24860#issuecomment-1175916421
Makes sense, but please fix the errors. (Documentation failure is unrelated and can be ignored for now.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kevgeo commented on pull request #24860: Add blocksize arg for ftp hook
Posted by GitBox <gi...@apache.org>.
kevgeo commented on PR #24860:
URL: https://github.com/apache/airflow/pull/24860#issuecomment-1178379494
Thanks @uranusjr for reviewing and @potiuk for the helpful discussion on slack :grin:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org