You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@commons.apache.org by bu...@apache.org on 2005/04/25 14:57:06 UTC

DO NOT REPLY [Bug 34601] New: - FileFinder.find() doesn't work correctly with Finder.TIME option

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=34601>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34601

           Summary: FileFinder.find() doesn't work correctly with
                    Finder.TIME option
           Product: Commons
           Version: Nightly Builds
          Platform: All
        OS/Version: Windows 2000
            Status: NEW
          Severity: normal
          Priority: P2
         Component: IO
        AssignedTo: commons-dev@jakarta.apache.org
        ReportedBy: mkompf@gmx.net


FileFinder.find(File file, Map option) doesn't work correctly if options
contains a Finder.TIME with a value greater than 24.

The error is in FindingFilter.TimeFilter.accept(File file):
 
In the expression  

file.lastModified() > System.currentTimeMillis() - this.argument * 60000*60*24

the part 'this.argument * 60000*60*24' is evaluated in the integer value range
which is exhausted if this.argument > 24

Fix: use 'this.argument * 60000L * 60L * 24L'

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org