You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stu Hood (JIRA)" <ji...@apache.org> on 2011/01/31 08:42:11 UTC
[jira] Created: (CASSANDRA-2075) Eliminate excess comparator
creation
Eliminate excess comparator creation
------------------------------------
Key: CASSANDRA-2075
URL: https://issues.apache.org/jira/browse/CASSANDRA-2075
Project: Cassandra
Issue Type: Improvement
Reporter: Stu Hood
Priority: Minor
Despite the singleton status of each AbstractType, we end up creating at least one new comparator per query. By making more of the "wrapper" comparators that exist in the codebase members of AbstractType, we could cut down on the "new Comparator" spam.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2075) Eliminate excess comparator
creation
Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Dusbabek updated CASSANDRA-2075:
-------------------------------------
Fix Version/s: 0.7.2
> Eliminate excess comparator creation
> ------------------------------------
>
> Key: CASSANDRA-2075
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2075
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Stu Hood
> Priority: Minor
> Labels: abstract_types, gc
> Fix For: 0.7.2
>
>
> Despite the singleton status of each AbstractType, we end up creating at least one new comparator per query. By making more of the "wrapper" comparators that exist in the codebase members of AbstractType, we could cut down on the "new Comparator" spam.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2075) Eliminate excess comparator
creation
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000160#comment-13000160 ]
Sylvain Lebresne commented on CASSANDRA-2075:
---------------------------------------------
+1
(minor point: can't we remove AbstractType.getReverseComparator() altogether instead of deprecating it ?)
> Eliminate excess comparator creation
> ------------------------------------
>
> Key: CASSANDRA-2075
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2075
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Stu Hood
> Assignee: Jonathan Ellis
> Priority: Minor
> Labels: abstract_types, gc
> Fix For: 0.7.4
>
> Attachments: 2075.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Despite the singleton status of each AbstractType, we end up creating at least one new comparator per query. By making more of the "wrapper" comparators that exist in the codebase members of AbstractType, we could cut down on the "new Comparator" spam.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2075) Eliminate excess comparator
creation
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-2075:
--------------------------------------
Attachment: 2075.txt
Sylvain already did this for IndexInfo comparators. Attached patch adds fields for IColumn and reverse ByteBuffer comparators.
> Eliminate excess comparator creation
> ------------------------------------
>
> Key: CASSANDRA-2075
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2075
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Stu Hood
> Priority: Minor
> Labels: abstract_types, gc
> Fix For: 0.7.4
>
> Attachments: 2075.txt
>
>
> Despite the singleton status of each AbstractType, we end up creating at least one new comparator per query. By making more of the "wrapper" comparators that exist in the codebase members of AbstractType, we could cut down on the "new Comparator" spam.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2075) Eliminate excess comparator
creation
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000172#comment-13000172 ]
Hudson commented on CASSANDRA-2075:
-----------------------------------
Integrated in Cassandra-0.7 #328 (See [https://hudson.apache.org/hudson/job/Cassandra-0.7/328/])
cache IColumn and reverse comparators in AbstractType
patch by jbellis; reviewed by slebresne for CASSANDRA-2075
> Eliminate excess comparator creation
> ------------------------------------
>
> Key: CASSANDRA-2075
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2075
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Stu Hood
> Assignee: Jonathan Ellis
> Priority: Minor
> Labels: abstract_types, gc
> Fix For: 0.7.4
>
> Attachments: 2075.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Despite the singleton status of each AbstractType, we end up creating at least one new comparator per query. By making more of the "wrapper" comparators that exist in the codebase members of AbstractType, we could cut down on the "new Comparator" spam.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2075) Eliminate excess comparator
creation
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-2075:
--------------------------------------
Remaining Estimate: 1h
Original Estimate: 1h
> Eliminate excess comparator creation
> ------------------------------------
>
> Key: CASSANDRA-2075
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2075
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Stu Hood
> Assignee: Jonathan Ellis
> Priority: Minor
> Labels: abstract_types, gc
> Fix For: 0.7.4
>
> Attachments: 2075.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Despite the singleton status of each AbstractType, we end up creating at least one new comparator per query. By making more of the "wrapper" comparators that exist in the codebase members of AbstractType, we could cut down on the "new Comparator" spam.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2075) Eliminate excess comparator
creation
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Williams updated CASSANDRA-2075:
----------------------------------------
Fix Version/s: (was: 0.7.2)
0.7.3
> Eliminate excess comparator creation
> ------------------------------------
>
> Key: CASSANDRA-2075
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2075
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Stu Hood
> Priority: Minor
> Labels: abstract_types, gc
> Fix For: 0.7.3
>
>
> Despite the singleton status of each AbstractType, we end up creating at least one new comparator per query. By making more of the "wrapper" comparators that exist in the codebase members of AbstractType, we could cut down on the "new Comparator" spam.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2075) Eliminate excess comparator
creation
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988680#comment-12988680 ]
Stu Hood commented on CASSANDRA-2075:
-------------------------------------
Main culprits are IFilter.getColumnComparator() and the reversed comparator created in SliceQueryFilter.
> Eliminate excess comparator creation
> ------------------------------------
>
> Key: CASSANDRA-2075
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2075
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Stu Hood
> Priority: Minor
> Labels: abstract_types, gc
>
> Despite the singleton status of each AbstractType, we end up creating at least one new comparator per query. By making more of the "wrapper" comparators that exist in the codebase members of AbstractType, we could cut down on the "new Comparator" spam.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2075) Eliminate excess comparator
creation
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000164#comment-13000164 ]
Jonathan Ellis commented on CASSANDRA-2075:
-------------------------------------------
committed
we should keep the public API stable until 0.8, just in case people are using that externally (I wouldn't be surprised if Hector does for instance)
> Eliminate excess comparator creation
> ------------------------------------
>
> Key: CASSANDRA-2075
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2075
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Stu Hood
> Assignee: Jonathan Ellis
> Priority: Minor
> Labels: abstract_types, gc
> Fix For: 0.7.4
>
> Attachments: 2075.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Despite the singleton status of each AbstractType, we end up creating at least one new comparator per query. By making more of the "wrapper" comparators that exist in the codebase members of AbstractType, we could cut down on the "new Comparator" spam.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (CASSANDRA-2075) Eliminate excess comparator
creation
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reassigned CASSANDRA-2075:
-----------------------------------------
Assignee: Jonathan Ellis
> Eliminate excess comparator creation
> ------------------------------------
>
> Key: CASSANDRA-2075
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2075
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Stu Hood
> Assignee: Jonathan Ellis
> Priority: Minor
> Labels: abstract_types, gc
> Fix For: 0.7.4
>
> Attachments: 2075.txt
>
>
> Despite the singleton status of each AbstractType, we end up creating at least one new comparator per query. By making more of the "wrapper" comparators that exist in the codebase members of AbstractType, we could cut down on the "new Comparator" spam.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira