You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ta...@apache.org on 2015/01/29 16:15:27 UTC

qpid-jms git commit: Remove the held request

Repository: qpid-jms
Updated Branches:
  refs/heads/master 0502aba74 -> b58538237


Remove the held request

Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/b5853823
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/b5853823
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/b5853823

Branch: refs/heads/master
Commit: b58538237cdd7d017b1ea3f6b8d951629793e873
Parents: 0502aba
Author: Timothy Bish <ta...@gmail.com>
Authored: Thu Jan 29 10:15:10 2015 -0500
Committer: Timothy Bish <ta...@gmail.com>
Committed: Thu Jan 29 10:15:10 2015 -0500

----------------------------------------------------------------------
 .../org/apache/qpid/jms/provider/failover/FailoverProvider.java    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/b5853823/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/failover/FailoverProvider.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/failover/FailoverProvider.java b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/failover/FailoverProvider.java
index 5a4438f..28f6838 100644
--- a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/failover/FailoverProvider.java
+++ b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/failover/FailoverProvider.java
@@ -813,7 +813,7 @@ public class FailoverProvider extends DefaultProviderListener implements Provide
                     requests.remove(id);
                     getWrappedRequest().onFailure(e);
                 } catch (JMSException jmsEx) {
-                    //TODO: should we remove the request as above?
+                    requests.remove(id);
                     getWrappedRequest().onFailure(jmsEx);
                 } catch (Throwable e) {
                     LOG.debug("Caught exception while executing task: {}", e.getMessage());


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org