[GitHub] [ozone] mukul1987 commented on a change in pull request #1665: HDDS-4554. numKey metrics goes negative after intermediate directory deletion.

[GitBox <gi...@apache.org>]

mukul1987 commented on a change in pull request #1665:
URL: https://github.com/apache/ozone/pull/1665#discussion_r537717407



##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequest.java
##########
@@ -336,6 +338,7 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
 
     switch (result) {
     case SUCCESS:
+      omMetrics.incNumKeys(numMissingParents);

Review comment:
       The metric being incremented here is because of the missing directories. The key/file value is incremented because of metric increment in OmKeyCommitRequest




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org