You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by be...@apache.org on 2025/12/02 19:16:55 UTC

(superset) branch master updated: fix: `is_column_reference` check (#36382)

This is an automated email from the ASF dual-hosted git repository.

beto pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new d05ab91d11 fix: `is_column_reference` check (#36382)
d05ab91d11 is described below

commit d05ab91d11b72e4233c6a440f11fcffb8459d56b
Author: Beto Dealmeida <ro...@dealmeida.net>
AuthorDate: Tue Dec 2 14:16:48 2025 -0500

    fix: `is_column_reference` check (#36382)
---
 superset/connectors/sqla/models.py | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/superset/connectors/sqla/models.py b/superset/connectors/sqla/models.py
index a5ae662384..40d993a2f7 100644
--- a/superset/connectors/sqla/models.py
+++ b/superset/connectors/sqla/models.py
@@ -1524,14 +1524,10 @@ class SqlaTable(
         has_timegrain = col.get("columnType") == "BASE_AXIS" and time_grain
         is_dttm = False
         pdf = None
-        is_column_reference = col.get("isColumnReference")
+        is_column_reference = col.get("isColumnReference", False)
 
         # First, check if this is a column reference that exists in metadata
-        col_in_metadata = None
-        if is_column_reference:
-            col_in_metadata = self.get_column(sql_expression)
-
-        if col_in_metadata:
+        if col_in_metadata := self.get_column(sql_expression):
             # Column exists in metadata - use it directly
             sqla_column = col_in_metadata.get_sqla_col(
                 template_processor=template_processor