[GitHub] [pinot] snleee commented on a diff in pull request #10463: Segment compaction for upsert real-time tables

["snleee (via GitHub)" <gi...@apache.org>]

snleee commented on code in PR #10463:
URL: https://github.com/apache/pinot/pull/10463#discussion_r1214634125


##########
pinot-core/src/main/java/org/apache/pinot/core/common/MinionConstants.java:
##########
@@ -136,4 +136,18 @@ public static class SegmentGenerationAndPushTask {
     public static final String CONFIG_NUMBER_CONCURRENT_TASKS_PER_INSTANCE =
         "SegmentGenerationAndPushTask.numConcurrentTasksPerInstance";
   }
+
+  public static class UpsertCompactionTask {
+    public static final String TASK_TYPE = "UpsertCompactionTask";
+    /**
+     * The time period to wait before picking segments for this task
+     * e.g. if set to "2d", no task will be scheduled for a time window younger than 2 days
+     */
+    public static final String BUFFER_TIME_PERIOD_KEY = "bufferTimePeriod";
+    /**
+     * The maximum amount of old records allowed for an existing segment.
+     * e.g. if the current amount surpasses 2500000, then the segment will be compacted
+     */
+    public static final String INVALID_RECORDS_THRESHOLD = "invalidRecordsThreshold";

Review Comment:
   Can we use percentage instead of the absolute number? Absolute number will be hard to configure the task and we need to know about the number of records per segments for each table.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org