You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Ned Collyer (JIRA)" <ji...@apache.org> on 2008/06/05 08:15:44 UTC
[jira] Created: (WICKET-1684) FileUploadField should return
FileUpload as its converted input
FileUploadField should return FileUpload as its converted input
---------------------------------------------------------------
Key: WICKET-1684
URL: https://issues.apache.org/jira/browse/WICKET-1684
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4-M2
Reporter: Ned Collyer
Priority: Minor
Fix For: 1.4-M3
FileUploadField should return FileUpload as its converted input so the file can be validated.
Eg,
@Override
protected void convertInput() {
setConvertedInput(getFileUpload());
}
Apparently MultiFileUploadField handles this (I've checked, it appears to be in the convertValue method).
For more context see http://www.nabble.com/Best-way-of-validating-FileUploadField-td17662018.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1684) FileUploadField should return
FileUpload as its converted input
Posted by "Timo Rantalaiho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604408#action_12604408 ]
Timo Rantalaiho commented on WICKET-1684:
-----------------------------------------
Seems to make sense to me. This changes existing behavior (currently FileUpload returns the file name), but because convertedInput is now something else than the model object after submit, it's a bug and it' should be OK to break it if someone depends on it.
> FileUploadField should return FileUpload as its converted input
> ---------------------------------------------------------------
>
> Key: WICKET-1684
> URL: https://issues.apache.org/jira/browse/WICKET-1684
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M2
> Reporter: Ned Collyer
> Priority: Minor
> Fix For: 1.4-M3
>
>
> FileUploadField should return FileUpload as its converted input so the file can be validated.
> Eg,
> @Override
> protected void convertInput() {
> setConvertedInput(getFileUpload());
> }
> Apparently MultiFileUploadField handles this (I've checked, it appears to be in the convertValue method).
> For more context see http://www.nabble.com/Best-way-of-validating-FileUploadField-td17662018.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1684) FileUploadField should return
FileUpload as its converted input
Posted by "Timo Rantalaiho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timo Rantalaiho reassigned WICKET-1684:
---------------------------------------
Assignee: Timo Rantalaiho
> FileUploadField should return FileUpload as its converted input
> ---------------------------------------------------------------
>
> Key: WICKET-1684
> URL: https://issues.apache.org/jira/browse/WICKET-1684
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M2
> Reporter: Ned Collyer
> Assignee: Timo Rantalaiho
> Priority: Minor
> Fix For: 1.4-M3
>
>
> FileUploadField should return FileUpload as its converted input so the file can be validated.
> Eg,
> @Override
> protected void convertInput() {
> setConvertedInput(getFileUpload());
> }
> Apparently MultiFileUploadField handles this (I've checked, it appears to be in the convertValue method).
> For more context see http://www.nabble.com/Best-way-of-validating-FileUploadField-td17662018.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1684) FileUploadField should return
FileUpload as its converted input
Posted by "Timo Rantalaiho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timo Rantalaiho resolved WICKET-1684.
-------------------------------------
Resolution: Fixed
Fixed in trunk (1.4). Thanks for reporting!
> FileUploadField should return FileUpload as its converted input
> ---------------------------------------------------------------
>
> Key: WICKET-1684
> URL: https://issues.apache.org/jira/browse/WICKET-1684
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M2
> Reporter: Ned Collyer
> Assignee: Timo Rantalaiho
> Priority: Minor
> Fix For: 1.4-M3
>
>
> FileUploadField should return FileUpload as its converted input so the file can be validated.
> Eg,
> @Override
> protected void convertInput() {
> setConvertedInput(getFileUpload());
> }
> Apparently MultiFileUploadField handles this (I've checked, it appears to be in the convertValue method).
> For more context see http://www.nabble.com/Best-way-of-validating-FileUploadField-td17662018.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.