You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/05 14:06:00 UTC

[jira] [Commented] (ARROW-2402) [C++] FixedSizeBinaryBuilder::Append lacks "const char*" overload

    [ https://issues.apache.org/jira/browse/ARROW-2402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426972#comment-16426972 ] 

ASF GitHub Bot commented on ARROW-2402:
---------------------------------------

pitrou opened a new pull request #1841: ARROW-2402: [C++] Avoid spurious copies with FixedSizeBinaryBuilder
URL: https://github.com/apache/arrow/pull/1841
 
 
   The lack of a FixedSizeBinaryBuilder::Append() overload for "const char*" implied a temporary conversion to std::string.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> [C++] FixedSizeBinaryBuilder::Append lacks "const char*" overload
> -----------------------------------------------------------------
>
>                 Key: ARROW-2402
>                 URL: https://issues.apache.org/jira/browse/ARROW-2402
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>    Affects Versions: 0.9.0
>            Reporter: Antoine Pitrou
>            Priority: Major
>              Labels: pull-request-available
>
> This implies that calling {{FixedSizeBinaryBuilder::Append}} with a "const char*" argument currently instantiates a temporary {{std::string}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)