You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "tooptoop4 (via GitHub)" <gi...@apache.org> on 2023/04/25 04:26:03 UTC
[GitHub] [superset] tooptoop4 opened a new pull request, #23804: chore: bump python version to 3.11 in Dockerfile
tooptoop4 opened a new pull request, #23804:
URL: https://github.com/apache/superset/pull/23804
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #23804: chore: bump python version to 3.11 in Dockerfile
Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on PR #23804:
URL: https://github.com/apache/superset/pull/23804#issuecomment-1524757533
Hi @tooptoop4!
We use minimum supported version of python in Dockerfile. It's 3.8 version.
But we can push a docker image with python 3.11 - look at https://github.com/apache/superset/pull/22770 PR how to do it!
@villebro @dpgaspar can we rid 3.8 & 3.9 PY versions of in superset 3.0 and use only 3.10 & 3.11 PY versions? In superset 4.0 we'll rid 3.10 PY version of and will use only 3.11 & 3.12 PY versions. What do you thinks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #23804: chore: bump python version to 3.11 in Dockerfile
Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on PR #23804:
URL: https://github.com/apache/superset/pull/23804#issuecomment-1525081955
@villebro Yes, I want to do it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mdeshmu commented on pull request #23804: chore: bump python version to 3.11 in Dockerfile
Posted by "mdeshmu (via GitHub)" <gi...@apache.org>.
mdeshmu commented on PR #23804:
URL: https://github.com/apache/superset/pull/23804#issuecomment-1544281626
I have raised [the PR](https://github.com/apache/superset/pull/24021) to add support for 3.11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #23804: chore: bump python version to 3.11 in Dockerfile
Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on PR #23804:
URL: https://github.com/apache/superset/pull/23804#issuecomment-1545287140
If you have a slack account in apache/superset you can join `#server-refactoring` channel and help us to fix PyHive for PY 3.10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #23804: chore: bump python version to 3.11 in Dockerfile
Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on PR #23804:
URL: https://github.com/apache/superset/pull/23804#issuecomment-1544286983
@mdeshmu We use the minimum supported version of Python! It's Py3.9 because a lot of drivers don't have support Py3.10 & Py3.11 (for example: PyHive don't have support new version of python)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mdeshmu commented on pull request #23804: chore: bump python version to 3.11 in Dockerfile
Posted by "mdeshmu (via GitHub)" <gi...@apache.org>.
mdeshmu commented on PR #23804:
URL: https://github.com/apache/superset/pull/23804#issuecomment-1545269484
Would that be in 3.0 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #23804: chore: bump python version to 3.11 in Dockerfile
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #23804:
URL: https://github.com/apache/superset/pull/23804#issuecomment-1524851269
@EugeneTorap I agree, we should bump to 3.10 as the official version. Would you be up for making the changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #23804: chore: bump python version to 3.11 in Dockerfile
Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on PR #23804:
URL: https://github.com/apache/superset/pull/23804#issuecomment-1545250796
@mdeshmu Yes, we will soon have a PR for `Bump to Python3.10` where we only use 3.10 and 3.11 PY for docker images.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: bump python version to 3.11 in Dockerfile [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch closed pull request #23804: chore: bump python version to 3.11 in Dockerfile
URL: https://github.com/apache/superset/pull/23804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #23804: chore: bump python version to 3.11 in Dockerfile
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23804:
URL: https://github.com/apache/superset/pull/23804#issuecomment-1524471961
Pinging @villebro and @EugeneTorap as I believe you've wrangled with this in the past, and know the perils and pitfalls here better than most :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mdeshmu commented on pull request #23804: chore: bump python version to 3.11 in Dockerfile
Posted by "mdeshmu (via GitHub)" <gi...@apache.org>.
mdeshmu commented on PR #23804:
URL: https://github.com/apache/superset/pull/23804#issuecomment-1545188395
I didn't clearly understand what you are saying.
I saw @sebastianliebscher's [PR](https://github.com/apache/superset/pull/23890) in which he has made python 3.9 as default and added support for 3.10 additional images.
I have justed extended that work and added support for 3.11 additional images.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #23804: chore: bump python version to 3.11 in Dockerfile
Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on PR #23804:
URL: https://github.com/apache/superset/pull/23804#issuecomment-1545144451
@mdeshmu, I agree with you but @sebastianliebscher and me are working on updating the minimum PY version of the superset from 3.9 to 3.10 and use only 3.10 & 3.11 here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mdeshmu commented on pull request #23804: chore: bump python version to 3.11 in Dockerfile
Posted by "mdeshmu (via GitHub)" <gi...@apache.org>.
mdeshmu commented on PR #23804:
URL: https://github.com/apache/superset/pull/23804#issuecomment-1544300683
I am not changing the default image version which supports 3.9. I just added the ability to create additional images with 3.11 so that we can use it with Superset's code base.
Talking of database drivers, Many of the drivers we use, do support Py 3.11. For e.g. pyathena, redshift-connector, pyscopg2 and many more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #23804: chore: bump python version to 3.11 in Dockerfile
Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on PR #23804:
URL: https://github.com/apache/superset/pull/23804#issuecomment-1545284316
Yeap, we plan to use only PY 3.10 & 3.11 in Superset 3.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: bump python version to 3.11 in Dockerfile [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23804:
URL: https://github.com/apache/superset/pull/23804#issuecomment-1960489005
@EugeneTorap @villebro @tooptoop4 is this PR still relevant? It looks like we're still on 3.9.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: bump python version to 3.11 in Dockerfile [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #23804:
URL: https://github.com/apache/superset/pull/23804#issuecomment-2030392639
Closing this in favor or https://github.com/apache/superset/pull/24112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org