You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/29 14:34:02 UTC

[GitHub] [pulsar-client-go] ttys3 opened a new pull request, #818: [log]: Fix up logrusWrapper

ttys3 opened a new pull request, #818:
URL: https://github.com/apache/pulsar-client-go/pull/818

   <--
   ### Contribution Checklist
     
     - Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
       Skip *Issue XYZ* if there is no associated github issue for this pull request.
       Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ### Motivation
   
   
   Fix up logrusWrapper
   
   I think that's a typo, I found it today when I'm implement a uber zap logger wrapper.
   
   ### Modifications
   
   as the code
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   
   ### Documentation
   
     - Does this pull request introduce a new feature? ( no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] Shoothzj commented on pull request #818: [log]: Fix up logrusWrapper

Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #818:
URL: https://github.com/apache/pulsar-client-go/pull/818#issuecomment-1243314625

   @wolfstudy @freeznet should we put this in 0.9.0?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org