You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/07/05 19:57:00 UTC

[jira] [Work logged] (HADOOP-17764) S3AInputStream read does not re-open the input stream on the second read retry attempt

     [ https://issues.apache.org/jira/browse/HADOOP-17764?focusedWorklogId=618771&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-618771 ]

ASF GitHub Bot logged work on HADOOP-17764:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Jul/21 19:56
            Start Date: 05/Jul/21 19:56
    Worklog Time Spent: 10m 
      Work Description: steveloughran commented on pull request #3109:
URL: https://github.com/apache/hadoop/pull/3109#issuecomment-874303444


   Note: we could also backport to 3.2.x if you want to cherrypick the 3.3 changes and retest...then provide a new PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 618771)
    Time Spent: 9h  (was: 8h 50m)

> S3AInputStream read does not re-open the input stream on the second read retry attempt
> --------------------------------------------------------------------------------------
>
>                 Key: HADOOP-17764
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17764
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/s3
>    Affects Versions: 3.3.1
>            Reporter: Zamil Majdy
>            Assignee: Zamil Majdy
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.3.2
>
>          Time Spent: 9h
>  Remaining Estimate: 0h
>
> *Bug description:*
> The read method in S3AInputStream has this following behaviour when an IOException happening during the read:
>  * {{reopen and read quickly}}: The client after failing in the first attempt of {{read}}, will reopen the stream and try reading again without {{sleep}}.
>  * {{reopen and wait for fixed duration}}: The client after failing in the attempt of {{read}}, will reopen the stream, sleep for {{fs.s3a.retry.interval}} milliseconds (defaults to 500 ms), and then try reading from the stream.
> While doing the {{reopen and read quickly}} process, the subsequent read will be retried without reopening the input stream in case of the second failure happened. This leads to some of the bytes read being skipped which results to corrupt/less data than required. 
>  
> *Scenario to reproduce:*
>  * Execute S3AInputStream `read()` or `read(b, off, len)`.
>  * The read failed and throws `Connection Reset` exception after reading some data.
>  * The InputStream is re-opened and another `read()` or `read(b, off, len)` is executed
>  * The read failed for the second time and throws `Connection Reset` exception after reading some data.
>  * The InputStream is not re-opened and another `read()` or `read(b, off, len)` is executed after sleep
>  * The read succeed, but it skips the first few bytes that has already been read on the second failure.
>  
> *Proposed fix:*
> [https://github.com/apache/hadoop/pull/3109]
> Added the test that reproduces the issue along with the fix



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org