[jira] [Commented] (HIVE-21586) Thrift generated cpp files for metastore do not compile

["Quanlong Huang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-21586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531670#comment-17531670 ] 

Quanlong Huang commented on HIVE-21586:
---------------------------------------

[~ngangam] Can we port this to branch-3.1?

[~chufucun] is working on Hive 3.1.x support in Impala (IMPALA-10871). We have to apply a patch for this: https://github.com/apache/impala/blob/4186727/testdata/cluster/hive/patch0-HIVE-21586.diff

> Thrift generated cpp files for metastore do not compile
> -------------------------------------------------------
>
>                 Key: HIVE-21586
>                 URL: https://issues.apache.org/jira/browse/HIVE-21586
>             Project: Hive
>          Issue Type: Bug
>          Components: Standalone Metastore
>    Affects Versions: 3.1.0
>            Reporter: Vihang Karajgaonkar
>            Assignee: Vihang Karajgaonkar
>            Priority: Major
>             Fix For: 3.2.0, 4.0.0, 4.0.0-alpha-1
>
>         Attachments: HIVE-21586.01.patch, HIVE-21586.02.patch, HIVE-21586.03.patch, HIVE-21586.04.branch-3.patch, HIVE-21586.04.patch, HIVE-21586.05.patch, HIVE-21586.nothrift.patch
>
>
> The way some structs like CreationMetadata, CompactionInfo, ColumnStatistics are defined in hive_metastore.thrift is that these structs are used before they are defined. While this works for the java code which is generated, it does not work for the generated cpp code since Thrift does not use pointer/references to the forward declared classes.
> The easy fix for this would be to reorder the struct definitions in the hive_metastore.thrift so that they are always defined before they are used.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)