You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Mathias Walter (JIRA)" <de...@myfaces.apache.org> on 2010/02/04 19:10:28 UTC

[jira] Created: (TRINIDAD-1708) issues with new Trinidad default skin - Casablanca

issues with new Trinidad default skin - Casablanca
--------------------------------------------------

                 Key: TRINIDAD-1708
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1708
             Project: MyFaces Trinidad
          Issue Type: Bug
          Components: Skinning
    Affects Versions: 1.2.14-core 
            Reporter: Mathias Walter


Disabling gridlines (verticalGridVisible="false" horizontalGridVisible="false") in table or treeTable does not work. Neither in FireFox nor in IE8. Can also be seen in the show case.

Also, Trinidad input/select components are not rendered well if they are placed in the actions facet of a table/treeTable. See screenshot.

The first input is a h:inputText, 2nd is tr:inputText and 3rd is tr:inputText with simple=true.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TRINIDAD-1708) issues with new Trinidad default skin - Casablanca

Posted by "Mathias Walter (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831674#action_12831674 ] 

Mathias Walter commented on TRINIDAD-1708:
------------------------------------------

Thanks for fixing it. I've created the new issue TRINIDAD-1718 for the problem with the input/select components. I hope one fix would address both components.

> issues with new Trinidad default skin - Casablanca
> --------------------------------------------------
>
>                 Key: TRINIDAD-1708
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1708
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Skinning
>    Affects Versions: 1.2.14-core 
>            Reporter: Mathias Walter
>            Assignee: Catalin Kormos
>             Fix For: 1.2.14-core 
>
>         Attachments: casablanca_TreeTable_actionsFacet.jpg
>
>
> Disabling gridlines (verticalGridVisible="false" horizontalGridVisible="false") in table or treeTable does not work. Neither in FireFox nor in IE8. Can also be seen in the show case.
> Also, Trinidad input/select components are not rendered well if they are placed in the actions facet of a table/treeTable. See screenshot.
> The first input is a h:inputText, 2nd is tr:inputText and 3rd is tr:inputText with simple=true.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (TRINIDAD-1708) issues with new Trinidad default skin - Casablanca

Posted by "Catalin Kormos (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Catalin Kormos resolved TRINIDAD-1708.
--------------------------------------

    Resolution: Fixed

TRINIDAD-1720 has been fixed, I put this also as resolved, please test again and reopen if it still doesn't work.

> issues with new Trinidad default skin - Casablanca
> --------------------------------------------------
>
>                 Key: TRINIDAD-1708
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1708
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Skinning
>    Affects Versions: 1.2.14-core 
>            Reporter: Mathias Walter
>            Assignee: Catalin Kormos
>             Fix For: 1.2.14-core 
>
>         Attachments: casablanca_TreeTable_actionsFacet.jpg
>
>
> Disabling gridlines (verticalGridVisible="false" horizontalGridVisible="false") in table or treeTable does not work. Neither in FireFox nor in IE8. Can also be seen in the show case.
> Also, Trinidad input/select components are not rendered well if they are placed in the actions facet of a table/treeTable. See screenshot.
> The first input is a h:inputText, 2nd is tr:inputText and 3rd is tr:inputText with simple=true.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (TRINIDAD-1708) issues with new Trinidad default skin - Casablanca

Posted by "Mathias Walter (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mathias Walter reopened TRINIDAD-1708:
--------------------------------------


The fix is incomplete. As soon as one of the xxxGridVisible attributes are set to false, both horizontal and vertical grid lines are not drawn, even if the other yyyGridVisible attribute is set to false. I tried all combinations with treeTable.

> issues with new Trinidad default skin - Casablanca
> --------------------------------------------------
>
>                 Key: TRINIDAD-1708
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1708
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Skinning
>    Affects Versions: 1.2.14-core 
>            Reporter: Mathias Walter
>            Assignee: Catalin Kormos
>             Fix For: 1.2.14-core 
>
>         Attachments: casablanca_TreeTable_actionsFacet.jpg
>
>
> Disabling gridlines (verticalGridVisible="false" horizontalGridVisible="false") in table or treeTable does not work. Neither in FireFox nor in IE8. Can also be seen in the show case.
> Also, Trinidad input/select components are not rendered well if they are placed in the actions facet of a table/treeTable. See screenshot.
> The first input is a h:inputText, 2nd is tr:inputText and 3rd is tr:inputText with simple=true.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (TRINIDAD-1708) issues with new Trinidad default skin - Casablanca

Posted by "Catalin Kormos (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Catalin Kormos resolved TRINIDAD-1708.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.2.14-core 

I committed a fix for the disabling of grid lines part. The other issue where Trinidad input/select components are not rendered well if they are placed in the actions facet of a table / treeTable, it is a bit more difficult. I would like to ask you to open a separate Jira issue for that. In general, mixing issue can cause this kind of situations, where one part is easier to fix than the other and so the issue could stay open for longer then needed; it's better to track them separately as they are anyway separate issues.

Thanks,
Catalin

> issues with new Trinidad default skin - Casablanca
> --------------------------------------------------
>
>                 Key: TRINIDAD-1708
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1708
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Skinning
>    Affects Versions: 1.2.14-core 
>            Reporter: Mathias Walter
>            Assignee: Catalin Kormos
>             Fix For: 1.2.14-core 
>
>         Attachments: casablanca_TreeTable_actionsFacet.jpg
>
>
> Disabling gridlines (verticalGridVisible="false" horizontalGridVisible="false") in table or treeTable does not work. Neither in FireFox nor in IE8. Can also be seen in the show case.
> Also, Trinidad input/select components are not rendered well if they are placed in the actions facet of a table/treeTable. See screenshot.
> The first input is a h:inputText, 2nd is tr:inputText and 3rd is tr:inputText with simple=true.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.