You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/15 09:54:11 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #30663: [SPARK-33700][SQL] Avoid file meta reading when enableFilterPushDown is true and filters is empty for Parquet and Orc
HyukjinKwon commented on a change in pull request #30663:
URL: https://github.com/apache/spark/pull/30663#discussion_r543200132
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala
##########
@@ -184,7 +184,7 @@ class OrcFileFormat
Iterator.empty
} else {
// ORC predicate pushdown
- if (orcFilterPushDown) {
+ if (orcFilterPushDown && filters.nonEmpty) {
Review comment:
Can you do this in CSV, Avro and JSON filters too since we're here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org