[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4258: [WIP][TVM] Bring Your Own Codegen to TVM

[GitBox <gi...@apache.org>]

tqchen commented on a change in pull request #4258: [WIP][TVM] Bring Your Own Codegen to TVM
URL: https://github.com/apache/incubator-tvm/pull/4258#discussion_r353498612
 
 

 ##########
 File path: src/relay/backend/graph_runtime_codegen.cc
 ##########
 @@ -639,6 +668,35 @@ class GraphRuntimeCodegenModule : public runtime::ModuleNode {
       return PackedFunc([sptr_to_self, this](TVMArgs args, TVMRetValue* rv) {
         *rv = this->output_.lowered_funcs;
       });
+    } else if (name == "get_external_funcs") {
 
 Review comment:
   I don't really like the current monolithic approach to handle the external compilations. Perhaps we can think a bit deeper.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services