[jira] [Commented] (PHOENIX-1396) Avoid unnecessary ResultSpooler.bin files creation/deletion every time SpoolingResultIterator is used

["Jeffrey Zhong (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14195751#comment-14195751 ] 

Jeffrey Zhong commented on PHOENIX-1396:
----------------------------------------

[~giacomotaylor] Could you please review it so that I can check it in? Thanks.

> Avoid unnecessary ResultSpooler.bin files creation/deletion every time SpoolingResultIterator is used 
> ------------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-1396
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1396
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.0.0
>            Reporter: Jeffrey Zhong
>            Assignee: Jeffrey Zhong
>         Attachments: PHOENIX-1396.patch
>
>
> In SpoolingResultIterator.java, we have following code:
> {code}
>             tempFile = File.createTempFile("ResultSpooler",".bin", new File(spoolDirectory));
>             DeferredFileOutputStream spoolTo = new DeferredFileOutputStream(size, tempFile) {
> {code}
> Basically we pre-create spill file even we don't reach memory threshold and later we delete the same file if it's not needed in finally block. We can remove these unnecessary file creation & deletion altogether.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)