You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/08/23 22:45:21 UTC

[jira] [Commented] (APEXMALHAR-2192) Implement SpillableByteArrayListMultimapImpl.removeAll(Object key)

    [ https://issues.apache.org/jira/browse/APEXMALHAR-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15433788#comment-15433788 ] 

ASF GitHub Bot commented on APEXMALHAR-2192:
--------------------------------------------

GitHub user davidyan74 opened a pull request:

    https://github.com/apache/apex-malhar/pull/377

    *Review Only* APEXMALHAR-2192 Added some spillable method implementations

    This is not ready for merge yet. Please do not comment on missing unit tests, code style, debug statements, etc.
    
    @brightchen @ilooner I added removeAll method to SpillableByteArrayListMultimapImpl but the testRemoveAll test method fails. Can you please take a look at what I did wrong?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/davidyan74/apex-malhar APEXMALHAR-2192

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/apex-malhar/pull/377.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #377
    
----
commit f8168445e1f78ca48924a90a2ee0140eb85bde23
Author: David Yan <da...@datatorrent.com>
Date:   2016-08-22T20:15:36Z

    added some spillable method implementations

----


> Implement SpillableByteArrayListMultimapImpl.removeAll(Object key)
> ------------------------------------------------------------------
>
>                 Key: APEXMALHAR-2192
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2192
>             Project: Apache Apex Malhar
>          Issue Type: Sub-task
>            Reporter: David Yan
>            Assignee: David Yan
>
> This is needed by the spillable implementation of SpillableWindowedKeyedStorage. In the implementation of WindowedOperator, when purging a window, we need to purge all keys associated with a given window.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)