[jira] [Commented] (HADOOP-8433) Logs are getting misplaced after introducing hadoop-env.sh

["Jay Finger (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-8433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287516#comment-13287516 ] 

Jay Finger commented on HADOOP-8433:
------------------------------------

I don't like the approach of commenting this line out.  I think a lot of admins will infer from this that uncommenting the line will result in some useful behavior.

A bigger problem is that hadoop-env.sh is sometimes included twice.  For example, hadoop-daemon.sh includes hadoop-config.sh, which includes hadoop-env.sh.  Then later hadoop-daemon.sh includes hadoop-env.sh explicitly.  It seems to me that this is the actual root cause of the issue, and that it is likely going to cause other headaches in the future by people who don't suspect that it will be included twice.
                
> Logs are getting misplaced after introducing hadoop-env.sh
> ----------------------------------------------------------
>
>                 Key: HADOOP-8433
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8433
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 2.0.1-alpha, 3.0.0
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>         Attachments: HADOOP-8433.patch, Hadoop-8433.patch
>
>
> It's better to comment the following in hadoop-env.sh
> # Where log files are stored.  $HADOOP_HOME/logs by default.
> export HADOOP_LOG_DIR=${HADOOP_LOG_DIR}/$USER
> Because of this logs are placing under root($user) and this getting called two times while starting process.
> hence logs are placing at /root/root/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira