You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/11 10:57:31 UTC
[GitHub] [incubator-superset] mifercre opened a new pull request #9115:
[WIP] Issue #7954 Fix auth for celery cache warmup requests
mifercre opened a new pull request #9115: [WIP] Issue #7954 Fix auth for celery cache warmup requests
URL: https://github.com/apache/incubator-superset/pull/9115
### CATEGORY
Choose one
- [X] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9115: [WIP]
Issue #7954 Fix auth for celery cache warmup requests
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9115: [WIP] Issue #7954 Fix auth for celery cache warmup requests
URL: https://github.com/apache/incubator-superset/pull/9115#issuecomment-584658644
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9115?src=pr&el=h1) Report
> Merging [#9115](https://codecov.io/gh/apache/incubator-superset/pull/9115?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/291306392443a5a0d0e2ee0cc4a95d37c56d4589?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9115?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9115 +/- ##
======================================
Coverage 59.1% 59.1%
======================================
Files 372 372
Lines 11920 11920
Branches 2917 2917
======================================
Hits 7045 7045
Misses 4693 4693
Partials 182 182
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9115?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9115?src=pr&el=footer). Last update [2913063...ce1a9c4](https://codecov.io/gh/apache/incubator-superset/pull/9115?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on a change in pull
request #9115: [fix] auth for celery cache warmup requests (issue #7954)
Posted by GitBox <gi...@apache.org>.
willbarrett commented on a change in pull request #9115: [fix] auth for celery cache warmup requests (issue #7954)
URL: https://github.com/apache/incubator-superset/pull/9115#discussion_r379186211
##########
File path: superset/config.py
##########
@@ -696,6 +696,9 @@ class CeleryConfig: # pylint: disable=too-few-public-methods
# The base URL to query for accessing the user interface
WEBDRIVER_BASEURL = "http://0.0.0.0:8080/"
+# User credentials to use for celery's cache warm-up task
+CACHE_WARMUP_USER = "admin"
Review comment:
It might be better to default this to a user with fewer permissions. `admin` is equivalent to `sudo` - best used with caution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] saurabh1920 commented on pull request #9115: [fix] auth for celery cache warmup requests (issue #7954)
Posted by GitBox <gi...@apache.org>.
saurabh1920 commented on pull request #9115:
URL: https://github.com/apache/incubator-superset/pull/9115#issuecomment-680578209
@ukm21 I tried what you suggested but I am getting unauthorized error.
Here is traceback.
`Traceback (most recent call last):
File "/app/superset/tasks/cache.py", line 304, in cache_warmup
File "/usr/local/lib/python3.6/urllib/request.py", line 223, in urlopen
return opener.open(url, data, timeout)
File "/usr/local/lib/python3.6/urllib/request.py", line 532, in open
response = meth(req, response)
File "/usr/local/lib/python3.6/urllib/request.py", line 642, in http_response
'http', request, response, code, msg, hdrs)
File "/usr/local/lib/python3.6/urllib/request.py", line 570, in error
return self._call_chain(*args)
File "/usr/local/lib/python3.6/urllib/request.py", line 504, in _call_chain
result = func(*args)
File "/usr/local/lib/python3.6/urllib/request.py", line 650, in http_error_default
raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 401: UNAUTHORIZED`
How did you manage to bypass authorization?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #9115: [fix]
auth for celery cache warmup requests (issue #7954)
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #9115: [fix] auth for celery cache warmup requests (issue #7954)
URL: https://github.com/apache/incubator-superset/pull/9115#issuecomment-613159222
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ukm21 commented on pull request #9115: [fix] auth for celery cache warmup requests (issue #7954)
Posted by GitBox <gi...@apache.org>.
ukm21 commented on pull request #9115:
URL: https://github.com/apache/incubator-superset/pull/9115#issuecomment-649996607
@mifercre Thanks for your reply,
I got this working using
[#7148](https://github.com/apache/incubator-superset/pull/7148/commits/76e6aa9e1395f8445d8d4cd613b9b865da4fdb8c)
as the master branch hits this url 'http://0.0.0.0:8081/superset/explore/?form_data=%7B%22slice_id%22%3A%204%7D' but for cache warmup we need to hit 'http://0.0.0.0:8081/superset/warm_up_cache/?slice_id=30'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mifercre commented on pull request #9115: [fix] auth for celery cache warmup requests (issue #7954)
Posted by GitBox <gi...@apache.org>.
mifercre commented on pull request #9115:
URL: https://github.com/apache/incubator-superset/pull/9115#issuecomment-649144581
@umandal yes. Can you paste any error logs, flask/gunicorn logs...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] umandal commented on pull request #9115: [fix] auth for celery cache warmup requests (issue #7954)
Posted by GitBox <gi...@apache.org>.
umandal commented on pull request #9115:
URL: https://github.com/apache/incubator-superset/pull/9115#issuecomment-648877825
@mifercre Is your cache getting refreshed after authentication?
after using these changes our authentication is successful but, Superset is not able to trigger query to refresh cache, and cache not getting refreshed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org