You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/23 08:47:31 UTC
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6895: esp32c3: Add initial support to esp32c3-devkit-rust-1 board
pkarashchenko commented on code in PR #6895:
URL: https://github.com/apache/incubator-nuttx/pull/6895#discussion_r952330961
##########
boards/risc-v/esp32c3/esp32c3-devkit-rust-1/src/esp32c3_autoleds.c:
##########
@@ -0,0 +1,112 @@
+/****************************************************************************
+ * boards/risc-v/esp32c3/esp32c3-devkit-rust-1/src/esp32c3_autoleds.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <debug.h>
+
+#include <arch/board/board.h>
+
+#include "esp32c3_gpio.h"
+#include "hardware/esp32c3_gpio_sigmap.h"
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+/* IO7 is connected to LED D2 */
+
+#define GPIO_LED 7
+
+/****************************************************************************
+ * Private Functions
+ ****************************************************************************/
+
+static inline void set_led(bool v)
+{
+ ledinfo("Turn LED %s\n", v ? "on":"off");
+ esp32c3_gpiowrite(GPIO_LED, v);
+}
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: board_autoled_initialize
+ ****************************************************************************/
+
+void board_autoled_initialize(void)
+{
+ /* Configure the LED's pin to be used as output */
+
+ esp32c3_gpio_matrix_out(GPIO_LED, SIG_GPIO_OUT_IDX, 0, 0);
+ esp32c3_configgpio(GPIO_LED, OUTPUT_FUNCTION_1 | INPUT_FUNCTION_1);
+}
+
+/****************************************************************************
+ * Name: board_autoled_on
+ ****************************************************************************/
+
+void board_autoled_on(int led)
+{
+ ledinfo("board_autoled_on(%d)\n", led);
+
+ switch (led)
+ {
+ case LED_STARTED:
+ case LED_HEAPALLOCATE:
+
+ /* As the board provides only one soft controllable LED, we simply
+ * turn it on when the board boots.
+ */
+
+ set_led(true);
+ break;
+
+ case LED_PANIC:
+
+ /* For panic state, the LED is blinking */
+
+ set_led(true);
+ break;
Review Comment:
please add 2 spaces for case block
also please add `default`case
##########
boards/risc-v/esp32c3/esp32c3-devkit-rust-1/src/esp32c3_autoleds.c:
##########
@@ -0,0 +1,112 @@
+/****************************************************************************
+ * boards/risc-v/esp32c3/esp32c3-devkit-rust-1/src/esp32c3_autoleds.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <debug.h>
+
+#include <arch/board/board.h>
+
+#include "esp32c3_gpio.h"
+#include "hardware/esp32c3_gpio_sigmap.h"
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+/* IO7 is connected to LED D2 */
+
+#define GPIO_LED 7
+
+/****************************************************************************
+ * Private Functions
+ ****************************************************************************/
+
+static inline void set_led(bool v)
+{
+ ledinfo("Turn LED %s\n", v ? "on":"off");
+ esp32c3_gpiowrite(GPIO_LED, v);
+}
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: board_autoled_initialize
+ ****************************************************************************/
+
+void board_autoled_initialize(void)
+{
+ /* Configure the LED's pin to be used as output */
+
+ esp32c3_gpio_matrix_out(GPIO_LED, SIG_GPIO_OUT_IDX, 0, 0);
+ esp32c3_configgpio(GPIO_LED, OUTPUT_FUNCTION_1 | INPUT_FUNCTION_1);
+}
+
+/****************************************************************************
+ * Name: board_autoled_on
+ ****************************************************************************/
+
+void board_autoled_on(int led)
+{
+ ledinfo("board_autoled_on(%d)\n", led);
+
+ switch (led)
+ {
+ case LED_STARTED:
+ case LED_HEAPALLOCATE:
+
+ /* As the board provides only one soft controllable LED, we simply
+ * turn it on when the board boots.
+ */
+
+ set_led(true);
+ break;
+
+ case LED_PANIC:
+
+ /* For panic state, the LED is blinking */
+
+ set_led(true);
+ break;
+ }
+}
+
+/****************************************************************************
+ * Name: board_autoled_off
+ ****************************************************************************/
+
+void board_autoled_off(int led)
+{
+ switch (led)
+ {
+ case LED_PANIC:
+
+ /* For panic state, the LED is blinking */
+
+ set_led(false);
+ break;
Review Comment:
please add 2 spaces for case block.
also please add `default` case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org