You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pig.apache.org by ol...@apache.org on 2008/07/09 01:14:25 UTC

svn commit: r675045 - in /incubator/pig/trunk: CHANGES.txt src/org/apache/pig/backend/hadoop/executionengine/HExecutionEngine.java

Author: olga
Date: Tue Jul  8 16:14:24 2008
New Revision: 675045

URL: http://svn.apache.org/viewvc?rev=675045&view=rev
Log:
 PIG-291: hod.param parameters not passed properly

Modified:
    incubator/pig/trunk/CHANGES.txt
    incubator/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/HExecutionEngine.java

Modified: incubator/pig/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/incubator/pig/trunk/CHANGES.txt?rev=675045&r1=675044&r2=675045&view=diff
==============================================================================
--- incubator/pig/trunk/CHANGES.txt (original)
+++ incubator/pig/trunk/CHANGES.txt Tue Jul  8 16:14:24 2008
@@ -339,3 +339,5 @@
     PIG-34: added missing licenses
 
     PIG-34: added LICENSE, NOTICE and README file
+
+    PIG-291: hod.param parameters not passed properly (thatha via olgan)

Modified: incubator/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/HExecutionEngine.java
URL: http://svn.apache.org/viewvc/incubator/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/HExecutionEngine.java?rev=675045&r1=675044&r2=675045&view=diff
==============================================================================
--- incubator/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/HExecutionEngine.java (original)
+++ incubator/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/HExecutionEngine.java Tue Jul  8 16:14:24 2008
@@ -373,14 +373,13 @@
             int nodes = getNumNodes(hodParams);
 
             // command format: hod allocate - d <cluster_dir> -n <number_of_nodes> <other params>
-            String[] cmdarray = new String[7];
-            cmdarray[0] = "hod";
-            cmdarray[1] = "allocate";
-            cmdarray[2] = "-d";
-            cmdarray[3] = hodConfDir;
-            cmdarray[4] = "-n";
-            cmdarray[5] = Integer.toString(nodes);
-            cmdarray[6] = hodParams.toString();
+                       String[] fixedCmdArray = new String[] { "hod", "allocate", "-d",
+                                       hodConfDir, "-n", Integer.toString(nodes) };
+               String[] extraParams = hodParams.toString().split(" ");
+    
+               String[] cmdarray = new String[fixedCmdArray.length + extraParams.length];
+               System.arraycopy(fixedCmdArray, 0, cmdarray, 0, fixedCmdArray.length);
+               System.arraycopy(extraParams, 0, cmdarray, fixedCmdArray.length, extraParams.length);
 
             log.info("Connecting to HOD...");
             log.debug("sending HOD command " + cmdToString(cmdarray));