You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/12/17 21:30:18 UTC
Review Request 29178: Disallowed empty DiskInfo.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29178/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-2030
https://issues.apache.org/jira/browse/MESOS-2030
Repository: mesos-git
Description
-------
Disallowed empty DiskInfo.
Diffs
-----
src/master/master.cpp 0f55a5cc2d6845cbaace718a48f771d80aad0e6e
Diff: https://reviews.apache.org/r/29178/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 29178: Disallowed empty DiskInfo.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29178/#review65398
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29178]
All tests passed.
- Mesos ReviewBot
On Dec. 17, 2014, 8:30 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29178/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2014, 8:30 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2030
> https://issues.apache.org/jira/browse/MESOS-2030
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Disallowed empty DiskInfo.
>
>
> Diffs
> -----
>
> src/master/master.cpp 0f55a5cc2d6845cbaace718a48f771d80aad0e6e
>
> Diff: https://reviews.apache.org/r/29178/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 29178: Disallowed empty DiskInfo.
Posted by Jie Yu <yu...@gmail.com>.
> On Dec. 18, 2014, 12:18 a.m., Ben Mahler wrote:
> > src/master/master.cpp, lines 1988-1994
> > <https://reviews.apache.org/r/29178/diff/1/?file=795164#file795164line1988>
> >
> > What about:
> >
> > ```
> > } else if (resource.disk().has_volume()) {
> > return Error("Non-persistent disk volume is not supported");
> > } else {
> > return Error("DiskInfo is set but empty");
> > }
> > ```
Much nicer!
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29178/#review65399
-----------------------------------------------------------
On Dec. 17, 2014, 8:30 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29178/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2014, 8:30 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2030
> https://issues.apache.org/jira/browse/MESOS-2030
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Disallowed empty DiskInfo.
>
>
> Diffs
> -----
>
> src/master/master.cpp 0f55a5cc2d6845cbaace718a48f771d80aad0e6e
>
> Diff: https://reviews.apache.org/r/29178/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 29178: Disallowed empty DiskInfo.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29178/#review65399
-----------------------------------------------------------
Ship it!
src/master/master.cpp
<https://reviews.apache.org/r/29178/#comment108506>
What about:
```
} else if (resource.disk().has_volume()) {
return Error("Non-persistent disk volume is not supported");
} else {
return Error("DiskInfo is set but empty");
}
```
- Ben Mahler
On Dec. 17, 2014, 8:30 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29178/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2014, 8:30 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2030
> https://issues.apache.org/jira/browse/MESOS-2030
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Disallowed empty DiskInfo.
>
>
> Diffs
> -----
>
> src/master/master.cpp 0f55a5cc2d6845cbaace718a48f771d80aad0e6e
>
> Diff: https://reviews.apache.org/r/29178/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>