You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/26 02:49:51 UTC
[GitHub] [flink] lamber-ken commented on a change in pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
lamber-ken commented on a change in pull request #11887:
URL: https://github.com/apache/flink/pull/11887#discussion_r415196998
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -1675,15 +1703,12 @@ private boolean isJobManagerConnectionValid(JobID jobId, JobMasterId jobMasterId
return CompletableFuture.supplyAsync(() -> {
final File file = new File(filePath);
if (file.exists()) {
- final TransientBlobCache transientBlobService = blobCacheService.getTransientBlobService();
- final TransientBlobKey transientBlobKey;
- try (FileInputStream fileInputStream = new FileInputStream(file)) {
- transientBlobKey = transientBlobService.putTransient(fileInputStream);
- } catch (IOException e) {
+ try {
+ return putTransientBlobStream(new FileInputStream(file), fileTag).get();
+ } catch (Exception e) {
Review comment:
hi @tillrohrmann, since doesn't make thread dump as stream in your design right now, we can revert it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org