Occasional test big in windows.

[Christian Brenninkmeijer <ch...@manchester.ac.uk>]

In Ro Bundles
class bundles.java

protected void close(boolean deleteOnClose) throws IOException {
...
/*
* FIXME: Enable this if closing temporary bundles is slow doing
* closing (as those files are being compressed):
* RecursiveDeleteVisitor.deleteRecursively(getRoot());
*/

Well guess what.

I managed to get exactly this situation several times on a windows machine.

Christian

Re: Occasional test big in windows.

[Stian Soiland-Reyes <st...@apache.org>]

Could you track this in Jira..?

I tried enabling it, but then loooads of tests fail:


Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.015
sec <<< FAILURE! - in
org.apache.taverna.robundle.manifest.TestManifestJSON
createBundle(org.apache.taverna.robundle.manifest.TestManifestJSON)
Time elapsed: 0.014 sec  <<< ERROR!
java.lang.NullPointerException: null
    at com.sun.nio.zipfs.ZipFileSystem.removeFromTree(ZipFileSystem.java:2332)
    at com.sun.nio.zipfs.ZipFileSystem.updateDelete(ZipFileSystem.java:1109)
    at com.sun.nio.zipfs.ZipFileSystem.deleteFile(ZipFileSystem.java:1346)
    at com.sun.nio.zipfs.ZipPath.delete(ZipPath.java:655)
    at com.sun.nio.zipfs.ZipFileSystemProvider.delete(ZipFileSystemProvider.java:206)
    at org.apache.taverna.robundle.fs.BundleFileSystemProvider.delete(BundleFileSystemProvider.java:376)
    at java.nio.file.Files.delete(Files.java:1079)
    at org.apache.taverna.robundle.utils.RecursiveDeleteVisitor.postVisitDirectory(RecursiveDeleteVisitor.java:46)
    at org.apache.taverna.robundle.utils.RecursiveDeleteVisitor.postVisitDirectory(RecursiveDeleteVisitor.java:34)
    at java.nio.file.FileTreeWalker.walk(FileTreeWalker.java:224)
    at java.nio.file.FileTreeWalker.walk(FileTreeWalker.java:69)
    at java.nio.file.Files.walkFileTree(Files.java:2602)
    at java.nio.file.Files.walkFileTree(Files.java:2635)
    at org.apache.taverna.robundle.utils.RecursiveDeleteVisitor.deleteRecursively(RecursiveDeleteVisitor.java:37)
    at org.apache.taverna.robundle.Bundle.close(Bundle.java:74)
    at org.apache.taverna.robundle.Bundle.close(Bundle.java:54)
    at org.apache.taverna.robundle.manifest.TestManifestJSON.createBundle(TestManifestJSON.java:151)


Unexpected failure of setLastModifiedTime on root
java.nio.file.NoSuchFileException:
    at com.sun.nio.zipfs.ZipFileSystem.setTimes(ZipFileSystem.java:341)
    at com.sun.nio.zipfs.ZipPath.setTimes(ZipPath.java:692)
    at com.sun.nio.zipfs.ZipFileAttributeView.setTimes(ZipFileAttributeView.java:114)
    at java.nio.file.Files.setLastModifiedTime(Files.java:2248)
    at org.apache.taverna.robundle.fs.TestZipFS.setLastModifiedTime(TestZipFS.java:188)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
    at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
    at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
    at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
    at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
    at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
    at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
    at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
    at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
    at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
    at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
    at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
    at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
    at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264)
    at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
    at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124)
    at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200)
    at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153)
    at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)


Do you think you could investigate further..? Perhaps we can't delete
/ itself, just its files?

On 24 June 2015 at 17:20, Christian Brenninkmeijer
<ch...@manchester.ac.uk> wrote:
> In Ro Bundles
> class bundles.java
>
> protected void close(boolean deleteOnClose) throws IOException {
> ...
> /*
> * FIXME: Enable this if closing temporary bundles is slow doing
> * closing (as those files are being compressed):
> * RecursiveDeleteVisitor.deleteRecursively(getRoot());
> */
>
> Well guess what.
>
> I managed to get exactly this situation several times on a windows machine.
>
> Christian



-- 
Stian Soiland-Reyes
Apache Taverna (incubating), Apache Commons RDF (incubating)
http://orcid.org/0000-0001-9842-9718