[GitHub] williaster commented on issue #5126: [dashboard v2] add v1 switch

[GitBox <gi...@apache.org>]

williaster commented on issue #5126: [dashboard v2] add v1 switch
URL: https://github.com/apache/incubator-superset/pull/5126#issuecomment-394903656
 
 
   @graceguo-supercat as we discussed this turned into a monster PR that addressed many issues, including some with the v1<>v2 switch. It fixes the following cc @elibrumbau:
   
   **Critical bugs**
   - [x] Markdown persisting issue => now toggles edit/preview on focus/unfocus
   - [x] “save as” doesn't persist new title
   - [x] drag drop issues
      - [x] can't drop row between rows
      - [x] orientation is wrong for charts in a rows (this is due to depth incrments)
      - [x] it's hard to find where to drag something to put it into a tab 
   
   **V1 <> V2 switch**
   - [x] Clarify What why when + additional info (info heirarchy) 
   - [x] There should be an action button that is explicit (e.g. save & convert to v2; convert to v2)
   - [x] Add something that indicates that you are in preview mode after the modal 
   
   **Other issues from feedback**
   - [x] Add text indicator “In use” for slices that are already in use
   - [x] Highlight/darken text of new components when you are hovering over a component
   - [x] slice adder datasources should open in new tab
   - [x] Make vis type hierarchy more clear in cards. eg  Visualization: line
   - [x] Toasts should go away after a while (set default to 4s, errors persist)
   - [x] consolidate actions into one dropdown
   - [x] fix markdown header size + styling
   - [x] delete row when you move / delete child and it's empty
   - [x] Slice picker search and filter are not super obvious
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org