You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martijn Dashorst (JIRA)" <ji...@apache.org> on 2007/12/09 22:59:43 UTC
[jira] Created: (WICKET-1215) WicketTester recreates session after
setting attributes on it
WicketTester recreates session after setting attributes on it
-------------------------------------------------------------
Key: WICKET-1215
URL: https://issues.apache.org/jira/browse/WICKET-1215
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.3.0-rc1
Reporter: Martijn Dashorst
Fix For: 1.3.0-rc3
The following test for internationalization doesn't work, as rendering the page will create a new session.
WicketTester tester = new WicketTester();
tester.getWicketSession().setLocale(Locale.FRENCH);
tester.startPage(HelloWorld.class);
tester.assertLabel("message", "Bonjour tout le monde!");
But setting up the response and request first works around recreating the session
WicketTester tester = new WicketTester();
tester.setupRequestAndResponse();
tester.getWicketSession().setLocale(Locale.FRENCH);
tester.startPage(HelloWorld.class);
tester.assertLabel("message", "Bonjour tout le monde!");
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1215) WicketTester recreates session after
setting attributes on it
Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn Dashorst updated WICKET-1215:
-------------------------------------
Fix Version/s: (was: 1.4-M3)
1.4-M4
Moved to next milestone release.
> WicketTester recreates session after setting attributes on it
> -------------------------------------------------------------
>
> Key: WICKET-1215
> URL: https://issues.apache.org/jira/browse/WICKET-1215
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-M1
> Reporter: Martijn Dashorst
> Fix For: 1.4-M4
>
>
> The following test for internationalization doesn't work, as rendering the page will create a new session.
> WicketTester tester = new WicketTester();
> tester.getWicketSession().setLocale(Locale.FRENCH);
> tester.startPage(HelloWorld.class);
> tester.assertLabel("message", "Bonjour tout le monde!");
> But setting up the response and request first works around recreating the session
> WicketTester tester = new WicketTester();
> tester.setupRequestAndResponse();
> tester.getWicketSession().setLocale(Locale.FRENCH);
> tester.startPage(HelloWorld.class);
> tester.assertLabel("message", "Bonjour tout le monde!");
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1215) WicketTester recreates session after
setting attributes on it
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reassigned WICKET-1215:
---------------------------------------
Assignee: Martin Grigorov (was: Juergen Donnerstag)
> WicketTester recreates session after setting attributes on it
> -------------------------------------------------------------
>
> Key: WICKET-1215
> URL: https://issues.apache.org/jira/browse/WICKET-1215
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-M1
> Reporter: Martijn Dashorst
> Assignee: Martin Grigorov
> Fix For: 1.5-M3
>
>
> The following test for internationalization doesn't work, as rendering the page will create a new session.
> WicketTester tester = new WicketTester();
> tester.getWicketSession().setLocale(Locale.FRENCH);
> tester.startPage(HelloWorld.class);
> tester.assertLabel("message", "Bonjour tout le monde!");
> But setting up the response and request first works around recreating the session
> WicketTester tester = new WicketTester();
> tester.setupRequestAndResponse();
> tester.getWicketSession().setLocale(Locale.FRENCH);
> tester.startPage(HelloWorld.class);
> tester.assertLabel("message", "Bonjour tout le monde!");
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1215) WicketTester recreates session after
setting attributes on it
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-1215:
---------------------------------------
Fix Version/s: (was: 1.4-M2)
1.4-M3
> WicketTester recreates session after setting attributes on it
> -------------------------------------------------------------
>
> Key: WICKET-1215
> URL: https://issues.apache.org/jira/browse/WICKET-1215
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-M1
> Reporter: Martijn Dashorst
> Fix For: 1.4-M3
>
>
> The following test for internationalization doesn't work, as rendering the page will create a new session.
> WicketTester tester = new WicketTester();
> tester.getWicketSession().setLocale(Locale.FRENCH);
> tester.startPage(HelloWorld.class);
> tester.assertLabel("message", "Bonjour tout le monde!");
> But setting up the response and request first works around recreating the session
> WicketTester tester = new WicketTester();
> tester.setupRequestAndResponse();
> tester.getWicketSession().setLocale(Locale.FRENCH);
> tester.startPage(HelloWorld.class);
> tester.assertLabel("message", "Bonjour tout le monde!");
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1215) WicketTester recreates session after
setting attributes on it
Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn Dashorst updated WICKET-1215:
-------------------------------------
Affects Version/s: (was: 1.3.0-rc1)
1.4-M1
Fix Version/s: (was: 1.3.1)
1.4-M1
Issue Type: Improvement (was: Bug)
Moved to 1.4 as we will be looking at Wicket Tester.
> WicketTester recreates session after setting attributes on it
> -------------------------------------------------------------
>
> Key: WICKET-1215
> URL: https://issues.apache.org/jira/browse/WICKET-1215
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-M1
> Reporter: Martijn Dashorst
> Fix For: 1.4-M1
>
>
> The following test for internationalization doesn't work, as rendering the page will create a new session.
> WicketTester tester = new WicketTester();
> tester.getWicketSession().setLocale(Locale.FRENCH);
> tester.startPage(HelloWorld.class);
> tester.assertLabel("message", "Bonjour tout le monde!");
> But setting up the response and request first works around recreating the session
> WicketTester tester = new WicketTester();
> tester.setupRequestAndResponse();
> tester.getWicketSession().setLocale(Locale.FRENCH);
> tester.startPage(HelloWorld.class);
> tester.assertLabel("message", "Bonjour tout le monde!");
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1215) WicketTester recreates session after
setting attributes on it
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-1215:
---------------------------------------
Fix Version/s: (was: 1.3.0-rc3)
1.3.1
> WicketTester recreates session after setting attributes on it
> -------------------------------------------------------------
>
> Key: WICKET-1215
> URL: https://issues.apache.org/jira/browse/WICKET-1215
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-rc1
> Reporter: Martijn Dashorst
> Fix For: 1.3.1
>
>
> The following test for internationalization doesn't work, as rendering the page will create a new session.
> WicketTester tester = new WicketTester();
> tester.getWicketSession().setLocale(Locale.FRENCH);
> tester.startPage(HelloWorld.class);
> tester.assertLabel("message", "Bonjour tout le monde!");
> But setting up the response and request first works around recreating the session
> WicketTester tester = new WicketTester();
> tester.setupRequestAndResponse();
> tester.getWicketSession().setLocale(Locale.FRENCH);
> tester.startPage(HelloWorld.class);
> tester.assertLabel("message", "Bonjour tout le monde!");
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1215) WicketTester recreates session after
setting attributes on it
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-1215:
---------------------------------------
Fix Version/s: (was: 1.4-M1)
1.4-M2
> WicketTester recreates session after setting attributes on it
> -------------------------------------------------------------
>
> Key: WICKET-1215
> URL: https://issues.apache.org/jira/browse/WICKET-1215
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-M1
> Reporter: Martijn Dashorst
> Fix For: 1.4-M2
>
>
> The following test for internationalization doesn't work, as rendering the page will create a new session.
> WicketTester tester = new WicketTester();
> tester.getWicketSession().setLocale(Locale.FRENCH);
> tester.startPage(HelloWorld.class);
> tester.assertLabel("message", "Bonjour tout le monde!");
> But setting up the response and request first works around recreating the session
> WicketTester tester = new WicketTester();
> tester.setupRequestAndResponse();
> tester.getWicketSession().setLocale(Locale.FRENCH);
> tester.startPage(HelloWorld.class);
> tester.assertLabel("message", "Bonjour tout le monde!");
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1215) WicketTester recreates session after
setting attributes on it
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-1215:
----------------------------------
Fix Version/s: 1.5-M3
(was: 1.5-M2)
> WicketTester recreates session after setting attributes on it
> -------------------------------------------------------------
>
> Key: WICKET-1215
> URL: https://issues.apache.org/jira/browse/WICKET-1215
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-M1
> Reporter: Martijn Dashorst
> Assignee: Juergen Donnerstag
> Fix For: 1.5-M3
>
>
> The following test for internationalization doesn't work, as rendering the page will create a new session.
> WicketTester tester = new WicketTester();
> tester.getWicketSession().setLocale(Locale.FRENCH);
> tester.startPage(HelloWorld.class);
> tester.assertLabel("message", "Bonjour tout le monde!");
> But setting up the response and request first works around recreating the session
> WicketTester tester = new WicketTester();
> tester.setupRequestAndResponse();
> tester.getWicketSession().setLocale(Locale.FRENCH);
> tester.startPage(HelloWorld.class);
> tester.assertLabel("message", "Bonjour tout le monde!");
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1215) WicketTester recreates session after
setting attributes on it
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag reassigned WICKET-1215:
------------------------------------------
Assignee: Juergen Donnerstag (was: Timo Rantalaiho)
> WicketTester recreates session after setting attributes on it
> -------------------------------------------------------------
>
> Key: WICKET-1215
> URL: https://issues.apache.org/jira/browse/WICKET-1215
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-M1
> Reporter: Martijn Dashorst
> Assignee: Juergen Donnerstag
> Fix For: 1.5-M1
>
>
> The following test for internationalization doesn't work, as rendering the page will create a new session.
> WicketTester tester = new WicketTester();
> tester.getWicketSession().setLocale(Locale.FRENCH);
> tester.startPage(HelloWorld.class);
> tester.assertLabel("message", "Bonjour tout le monde!");
> But setting up the response and request first works around recreating the session
> WicketTester tester = new WicketTester();
> tester.setupRequestAndResponse();
> tester.getWicketSession().setLocale(Locale.FRENCH);
> tester.startPage(HelloWorld.class);
> tester.assertLabel("message", "Bonjour tout le monde!");
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1215) WicketTester recreates session
after setting attributes on it
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924348#action_12924348 ]
Hudson commented on WICKET-1215:
--------------------------------
Integrated in Apache Wicket 1.5.x #451 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.5.x/451/])
WICKET-1215 WicketTester recreates session after setting attributes on it
Add a unit test for the described problem that WicketTester creates a new Session when starting a page.
> WicketTester recreates session after setting attributes on it
> -------------------------------------------------------------
>
> Key: WICKET-1215
> URL: https://issues.apache.org/jira/browse/WICKET-1215
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-M1
> Reporter: Martijn Dashorst
> Assignee: Martin Grigorov
> Fix For: 1.5-M3
>
>
> The following test for internationalization doesn't work, as rendering the page will create a new session.
> WicketTester tester = new WicketTester();
> tester.getWicketSession().setLocale(Locale.FRENCH);
> tester.startPage(HelloWorld.class);
> tester.assertLabel("message", "Bonjour tout le monde!");
> But setting up the response and request first works around recreating the session
> WicketTester tester = new WicketTester();
> tester.setupRequestAndResponse();
> tester.getWicketSession().setLocale(Locale.FRENCH);
> tester.startPage(HelloWorld.class);
> tester.assertLabel("message", "Bonjour tout le monde!");
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1215) WicketTester recreates session after
setting attributes on it
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-1215:
----------------------------------
Fix Version/s: (was: 1.5-M1)
1.5-M2
> WicketTester recreates session after setting attributes on it
> -------------------------------------------------------------
>
> Key: WICKET-1215
> URL: https://issues.apache.org/jira/browse/WICKET-1215
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-M1
> Reporter: Martijn Dashorst
> Assignee: Juergen Donnerstag
> Fix For: 1.5-M2
>
>
> The following test for internationalization doesn't work, as rendering the page will create a new session.
> WicketTester tester = new WicketTester();
> tester.getWicketSession().setLocale(Locale.FRENCH);
> tester.startPage(HelloWorld.class);
> tester.assertLabel("message", "Bonjour tout le monde!");
> But setting up the response and request first works around recreating the session
> WicketTester tester = new WicketTester();
> tester.setupRequestAndResponse();
> tester.getWicketSession().setLocale(Locale.FRENCH);
> tester.startPage(HelloWorld.class);
> tester.assertLabel("message", "Bonjour tout le monde!");
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1215) WicketTester recreates session after
setting attributes on it
Posted by "Timo Rantalaiho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timo Rantalaiho updated WICKET-1215:
------------------------------------
Fix Version/s: (was: 1.4-M4)
1.5-M1
Assignee: Timo Rantalaiho
In 1.4 living with the workaround is acceptable, thanks for providing that.
Let's see how we can address this in 1.5.
> WicketTester recreates session after setting attributes on it
> -------------------------------------------------------------
>
> Key: WICKET-1215
> URL: https://issues.apache.org/jira/browse/WICKET-1215
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-M1
> Reporter: Martijn Dashorst
> Assignee: Timo Rantalaiho
> Fix For: 1.5-M1
>
>
> The following test for internationalization doesn't work, as rendering the page will create a new session.
> WicketTester tester = new WicketTester();
> tester.getWicketSession().setLocale(Locale.FRENCH);
> tester.startPage(HelloWorld.class);
> tester.assertLabel("message", "Bonjour tout le monde!");
> But setting up the response and request first works around recreating the session
> WicketTester tester = new WicketTester();
> tester.setupRequestAndResponse();
> tester.getWicketSession().setLocale(Locale.FRENCH);
> tester.startPage(HelloWorld.class);
> tester.assertLabel("message", "Bonjour tout le monde!");
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1215) WicketTester recreates session after
setting attributes on it
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-1215.
-------------------------------------
Resolution: Fixed
It seems this already works as expected in Wicket 1.5.
With r1026816 I added a unit test for the described case.
> WicketTester recreates session after setting attributes on it
> -------------------------------------------------------------
>
> Key: WICKET-1215
> URL: https://issues.apache.org/jira/browse/WICKET-1215
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-M1
> Reporter: Martijn Dashorst
> Assignee: Martin Grigorov
> Fix For: 1.5-M3
>
>
> The following test for internationalization doesn't work, as rendering the page will create a new session.
> WicketTester tester = new WicketTester();
> tester.getWicketSession().setLocale(Locale.FRENCH);
> tester.startPage(HelloWorld.class);
> tester.assertLabel("message", "Bonjour tout le monde!");
> But setting up the response and request first works around recreating the session
> WicketTester tester = new WicketTester();
> tester.setupRequestAndResponse();
> tester.getWicketSession().setLocale(Locale.FRENCH);
> tester.startPage(HelloWorld.class);
> tester.assertLabel("message", "Bonjour tout le monde!");
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.