You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jean-Daniel Cryans (Created) (JIRA)" <ji...@apache.org> on 2012/02/09 00:33:00 UTC

[jira] [Created] (HBASE-5359) Alter in the shell can be too quick and return before the table is altered

Alter in the shell can be too quick and return before the table is altered
--------------------------------------------------------------------------

                 Key: HBASE-5359
                 URL: https://issues.apache.org/jira/browse/HBASE-5359
             Project: HBase
          Issue Type: Bug
    Affects Versions: 0.92.0
            Reporter: Jean-Daniel Cryans
             Fix For: 0.94.0, 0.92.1


This seems to be a recent change in behavior but I'm still not sure where it's coming from.

The shell is able to call HMaster.getAlterStatus before the TableEventHandler is able call AM.setRegionsToReopen so that the returned status shows no pending regions. It means that the alter seems "instantaneous" although it's far from completed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5359) Alter in the shell can be too quick and return before the table is altered

Posted by "Jean-Daniel Cryans (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246540#comment-13246540 ] 

Jean-Daniel Cryans commented on HBASE-5359:
-------------------------------------------

Looks like it works as expected, +1
                
> Alter in the shell can be too quick and return before the table is altered
> --------------------------------------------------------------------------
>
>                 Key: HBASE-5359
>                 URL: https://issues.apache.org/jira/browse/HBASE-5359
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.96.0
>
>         Attachments: HBASE-5359.patch
>
>
> This seems to be a recent change in behavior but I'm still not sure where it's coming from.
> The shell is able to call HMaster.getAlterStatus before the TableEventHandler is able call AM.setRegionsToReopen so that the returned status shows no pending regions. It means that the alter seems "instantaneous" although it's far from completed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5359) Alter in the shell can be too quick and return before the table is altered

Posted by "Nicolas Spiegelberg (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246574#comment-13246574 ] 

Nicolas Spiegelberg commented on HBASE-5359:
--------------------------------------------

The only worry that I have with this patch is that I have an unconditional wait.  The code should theoretically be fine because the main problem would be handling a shutdownNow() request.  In this case, it should throw an InterruptException and be released by the finally block that Ted mentions.  However, a bug would cause the RPC thread (and, hence, the RS) to hang and avoid exiting.  That said, adding a time on the wait might end up masking a bug and cause the shutdown process to appear hacky.
                
> Alter in the shell can be too quick and return before the table is altered
> --------------------------------------------------------------------------
>
>                 Key: HBASE-5359
>                 URL: https://issues.apache.org/jira/browse/HBASE-5359
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.96.0
>
>         Attachments: HBASE-5359.patch
>
>
> This seems to be a recent change in behavior but I'm still not sure where it's coming from.
> The shell is able to call HMaster.getAlterStatus before the TableEventHandler is able call AM.setRegionsToReopen so that the returned status shows no pending regions. It means that the alter seems "instantaneous" although it's far from completed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5359) Alter in the shell can be too quick and return before the table is altered

Posted by "Nicolas Spiegelberg (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246517#comment-13246517 ] 

Nicolas Spiegelberg commented on HBASE-5359:
--------------------------------------------

Besides focusing on fixing HBASE-5335, I only worked on a solution for alterTable because alter_status is visibly broken without this, where the user may never notice the subtle race conditions with the other APIs.
                
> Alter in the shell can be too quick and return before the table is altered
> --------------------------------------------------------------------------
>
>                 Key: HBASE-5359
>                 URL: https://issues.apache.org/jira/browse/HBASE-5359
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.92.2
>
>         Attachments: HBASE-5359.patch
>
>
> This seems to be a recent change in behavior but I'm still not sure where it's coming from.
> The shell is able to call HMaster.getAlterStatus before the TableEventHandler is able call AM.setRegionsToReopen so that the returned status shows no pending regions. It means that the alter seems "instantaneous" although it's far from completed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5359) Alter in the shell can be too quick and return before the table is altered

Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Spiegelberg updated HBASE-5359:
---------------------------------------

    Resolution: Fixed
      Assignee: Nicolas Spiegelberg
        Status: Resolved  (was: Patch Available)

fixed on trunk.  should probably port to 94
                
> Alter in the shell can be too quick and return before the table is altered
> --------------------------------------------------------------------------
>
>                 Key: HBASE-5359
>                 URL: https://issues.apache.org/jira/browse/HBASE-5359
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Jean-Daniel Cryans
>            Assignee: Nicolas Spiegelberg
>             Fix For: 0.96.0
>
>         Attachments: HBASE-5359.patch
>
>
> This seems to be a recent change in behavior but I'm still not sure where it's coming from.
> The shell is able to call HMaster.getAlterStatus before the TableEventHandler is able call AM.setRegionsToReopen so that the returned status shows no pending regions. It means that the alter seems "instantaneous" although it's far from completed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5359) Alter in the shell can be too quick and return before the table is altered

Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Spiegelberg updated HBASE-5359:
---------------------------------------

    Attachment: HBASE-5359.patch

This is a initial patch that compiles/works/fixes HBASE-5335, but is not extensively tested.  Note that this can also be extended to support addColumn and other TableEventHandlers.  We should probably also employ a similar technique for enableTable/disableTable.  Feel free to run with this or ask questions.  It's pretty simple: just add a conditional variable to wait for ZK persist (or Exception).
                
> Alter in the shell can be too quick and return before the table is altered
> --------------------------------------------------------------------------
>
>                 Key: HBASE-5359
>                 URL: https://issues.apache.org/jira/browse/HBASE-5359
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.92.2
>
>         Attachments: HBASE-5359.patch
>
>
> This seems to be a recent change in behavior but I'm still not sure where it's coming from.
> The shell is able to call HMaster.getAlterStatus before the TableEventHandler is able call AM.setRegionsToReopen so that the returned status shows no pending regions. It means that the alter seems "instantaneous" although it's far from completed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5359) Alter in the shell can be too quick and return before the table is altered

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246583#comment-13246583 ] 

Hadoop QA commented on HBASE-5359:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12521348/HBASE-5359.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper
                  org.apache.hadoop.hbase.mapreduce.TestImportTsv
                  org.apache.hadoop.hbase.mapred.TestTableMapReduce
                  org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
                  org.apache.hadoop.hbase.mapreduce.TestTableMapReduce

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1387//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1387//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1387//console

This message is automatically generated.
                
> Alter in the shell can be too quick and return before the table is altered
> --------------------------------------------------------------------------
>
>                 Key: HBASE-5359
>                 URL: https://issues.apache.org/jira/browse/HBASE-5359
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.96.0
>
>         Attachments: HBASE-5359.patch
>
>
> This seems to be a recent change in behavior but I'm still not sure where it's coming from.
> The shell is able to call HMaster.getAlterStatus before the TableEventHandler is able call AM.setRegionsToReopen so that the returned status shows no pending regions. It means that the alter seems "instantaneous" although it's far from completed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5359) Alter in the shell can be too quick and return before the table is altered

Posted by "Nicolas Spiegelberg (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246757#comment-13246757 ] 

Nicolas Spiegelberg commented on HBASE-5359:
--------------------------------------------

All the Hadoop QA tests are existing issues.  Seem to be caused by HBASE-5636...  Example of prior test problems: https://builds.apache.org/job/PreCommit-HBASE-Build/1369/
                
> Alter in the shell can be too quick and return before the table is altered
> --------------------------------------------------------------------------
>
>                 Key: HBASE-5359
>                 URL: https://issues.apache.org/jira/browse/HBASE-5359
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.96.0
>
>         Attachments: HBASE-5359.patch
>
>
> This seems to be a recent change in behavior but I'm still not sure where it's coming from.
> The shell is able to call HMaster.getAlterStatus before the TableEventHandler is able call AM.setRegionsToReopen so that the returned status shows no pending regions. It means that the alter seems "instantaneous" although it's far from completed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5359) Alter in the shell can be too quick and return before the table is altered

Posted by "Nicolas Spiegelberg (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246568#comment-13246568 ] 

Nicolas Spiegelberg commented on HBASE-5359:
--------------------------------------------

@Ted: note that setPersist() just means that we have past the conditional variable of needing to set persistence.  In the exception case, we don't need to set persistence, we just need to let the other thread finish.  One additional feature that we can add is the ability to propagate the exception in the ExecutorService thread to the RPC thread so the user visibly sees that his operation has failed.
                
> Alter in the shell can be too quick and return before the table is altered
> --------------------------------------------------------------------------
>
>                 Key: HBASE-5359
>                 URL: https://issues.apache.org/jira/browse/HBASE-5359
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.96.0
>
>         Attachments: HBASE-5359.patch
>
>
> This seems to be a recent change in behavior but I'm still not sure where it's coming from.
> The shell is able to call HMaster.getAlterStatus before the TableEventHandler is able call AM.setRegionsToReopen so that the returned status shows no pending regions. It means that the alter seems "instantaneous" although it's far from completed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5359) Alter in the shell can be too quick and return before the table is altered

Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246813#comment-13246813 ] 

stack commented on HBASE-5359:
------------------------------

@Lars +1 on getting this into 0.94.
                
> Alter in the shell can be too quick and return before the table is altered
> --------------------------------------------------------------------------
>
>                 Key: HBASE-5359
>                 URL: https://issues.apache.org/jira/browse/HBASE-5359
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Jean-Daniel Cryans
>            Assignee: Nicolas Spiegelberg
>             Fix For: 0.96.0
>
>         Attachments: HBASE-5359.patch
>
>
> This seems to be a recent change in behavior but I'm still not sure where it's coming from.
> The shell is able to call HMaster.getAlterStatus before the TableEventHandler is able call AM.setRegionsToReopen so that the returned status shows no pending regions. It means that the alter seems "instantaneous" although it's far from completed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5359) Alter in the shell can be too quick and return before the table is altered

Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246539#comment-13246539 ] 

Zhihong Yu commented on HBASE-5359:
-----------------------------------

{code}
     } catch (KeeperException e) {
       LOG.error("Error manipulating table " + Bytes.toString(tableName), e);
+    } finally {
+      // notify the waiting thread that we're done persisting the request
+      setPersist();
{code}
Should the setPersist() call be excluded from the case where KeeperException is encountered ?
                
> Alter in the shell can be too quick and return before the table is altered
> --------------------------------------------------------------------------
>
>                 Key: HBASE-5359
>                 URL: https://issues.apache.org/jira/browse/HBASE-5359
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.96.0
>
>         Attachments: HBASE-5359.patch
>
>
> This seems to be a recent change in behavior but I'm still not sure where it's coming from.
> The shell is able to call HMaster.getAlterStatus before the TableEventHandler is able call AM.setRegionsToReopen so that the returned status shows no pending regions. It means that the alter seems "instantaneous" although it's far from completed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5359) Alter in the shell can be too quick and return before the table is altered

Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246792#comment-13246792 ] 

stack commented on HBASE-5359:
------------------------------

+1 on patch
                
> Alter in the shell can be too quick and return before the table is altered
> --------------------------------------------------------------------------
>
>                 Key: HBASE-5359
>                 URL: https://issues.apache.org/jira/browse/HBASE-5359
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.96.0
>
>         Attachments: HBASE-5359.patch
>
>
> This seems to be a recent change in behavior but I'm still not sure where it's coming from.
> The shell is able to call HMaster.getAlterStatus before the TableEventHandler is able call AM.setRegionsToReopen so that the returned status shows no pending regions. It means that the alter seems "instantaneous" although it's far from completed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5359) Alter in the shell can be too quick and return before the table is altered

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247032#comment-13247032 ] 

Hudson commented on HBASE-5359:
-------------------------------

Integrated in HBase-TRUNK-security #157 (See [https://builds.apache.org/job/HBase-TRUNK-security/157/])
    HBASE-5359 Alter in the shell can be too quick and return before the table is altered (Revision 1309611)

     Result = FAILURE
nspiegelberg : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java

                
> Alter in the shell can be too quick and return before the table is altered
> --------------------------------------------------------------------------
>
>                 Key: HBASE-5359
>                 URL: https://issues.apache.org/jira/browse/HBASE-5359
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Jean-Daniel Cryans
>            Assignee: Nicolas Spiegelberg
>             Fix For: 0.96.0
>
>         Attachments: HBASE-5359.patch
>
>
> This seems to be a recent change in behavior but I'm still not sure where it's coming from.
> The shell is able to call HMaster.getAlterStatus before the TableEventHandler is able call AM.setRegionsToReopen so that the returned status shows no pending regions. It means that the alter seems "instantaneous" although it's far from completed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5359) Alter in the shell can be too quick and return before the table is altered

Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Spiegelberg updated HBASE-5359:
---------------------------------------

    Fix Version/s:     (was: 0.92.2)
                   0.96.0
           Status: Patch Available  (was: Open)

only tested on trunk, should be trivial to backport to 0.94
                
> Alter in the shell can be too quick and return before the table is altered
> --------------------------------------------------------------------------
>
>                 Key: HBASE-5359
>                 URL: https://issues.apache.org/jira/browse/HBASE-5359
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.96.0
>
>         Attachments: HBASE-5359.patch
>
>
> This seems to be a recent change in behavior but I'm still not sure where it's coming from.
> The shell is able to call HMaster.getAlterStatus before the TableEventHandler is able call AM.setRegionsToReopen so that the returned status shows no pending regions. It means that the alter seems "instantaneous" although it's far from completed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5359) Alter in the shell can be too quick and return before the table is altered

Posted by "Jean-Daniel Cryans (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246528#comment-13246528 ] 

Jean-Daniel Cryans commented on HBASE-5359:
-------------------------------------------

I'm giving this patch a spin on 0.94
                
> Alter in the shell can be too quick and return before the table is altered
> --------------------------------------------------------------------------
>
>                 Key: HBASE-5359
>                 URL: https://issues.apache.org/jira/browse/HBASE-5359
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.96.0
>
>         Attachments: HBASE-5359.patch
>
>
> This seems to be a recent change in behavior but I'm still not sure where it's coming from.
> The shell is able to call HMaster.getAlterStatus before the TableEventHandler is able call AM.setRegionsToReopen so that the returned status shows no pending regions. It means that the alter seems "instantaneous" although it's far from completed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5359) Alter in the shell can be too quick and return before the table is altered

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246800#comment-13246800 ] 

Hudson commented on HBASE-5359:
-------------------------------

Integrated in HBase-TRUNK #2710 (See [https://builds.apache.org/job/HBase-TRUNK/2710/])
    HBASE-5359 Alter in the shell can be too quick and return before the table is altered (Revision 1309611)

     Result = FAILURE
nspiegelberg : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java

                
> Alter in the shell can be too quick and return before the table is altered
> --------------------------------------------------------------------------
>
>                 Key: HBASE-5359
>                 URL: https://issues.apache.org/jira/browse/HBASE-5359
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.96.0
>
>         Attachments: HBASE-5359.patch
>
>
> This seems to be a recent change in behavior but I'm still not sure where it's coming from.
> The shell is able to call HMaster.getAlterStatus before the TableEventHandler is able call AM.setRegionsToReopen so that the returned status shows no pending regions. It means that the alter seems "instantaneous" although it's far from completed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira