You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/16 06:02:47 UTC

[GitHub] [spark] LinhongLiu opened a new pull request #26134: Calendarinterval

LinhongLiu opened a new pull request #26134: Calendarinterval
URL: https://github.com/apache/spark/pull/26134
 
 
   ### What changes were proposed in this pull request?
   Current CalendarInterval has 2 fields: months and microseconds. This PR try to change it
   to 3 fields: months, days and microseconds. This is because one logical day interval may
   have different number of microseconds (daylight saving).
   
   
   ### Why are the changes needed?
   One logical day interval may have different number of microseconds (daylight saving).
   For example, in PST timezone, there will be 25 hours from 2019-11-2 12:00:00 to
   2019-11-3 12:00:00
   
   
   ### Does this PR introduce any user-facing change?
   no
   
   ### How was this patch tested?
   unit test and new added test cases
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org