You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2019/06/14 16:14:58 UTC

[commons-csv] branch master updated: Document change to test behaviour

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-csv.git


The following commit(s) were added to refs/heads/master by this push:
     new 46c8434  Document change to test behaviour
46c8434 is described below

commit 46c84341e6316767ff375739bf53b7229c807632
Author: Sebb <se...@apache.org>
AuthorDate: Fri Jun 14 17:14:54 2019 +0100

    Document change to test behaviour
---
 src/test/java/org/apache/commons/csv/CSVFormatTest.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/test/java/org/apache/commons/csv/CSVFormatTest.java b/src/test/java/org/apache/commons/csv/CSVFormatTest.java
index c62cb58..1d5cf56 100644
--- a/src/test/java/org/apache/commons/csv/CSVFormatTest.java
+++ b/src/test/java/org/apache/commons/csv/CSVFormatTest.java
@@ -520,7 +520,7 @@ public class CSVFormatTest {
         assertTrue(cSVFormatTwo.getIgnoreHeaderCase());
         assertFalse(cSVFormatTwo.getTrailingDelimiter());
 
-        assertTrue(cSVFormatTwo.equals(cSVFormat));
+        assertTrue(cSVFormatTwo.equals(cSVFormat)); // TODO this fails since CSV-242 was applied. Why should they compare equal?
         assertFalse(cSVFormatTwo.getAllowMissingColumnNames());
 
         assertFalse(cSVFormatTwo.getTrim());
@@ -969,7 +969,7 @@ public class CSVFormatTest {
         assertNotSame(cSVFormat, cSVFormatTwo);
         assertNotSame(cSVFormatTwo, cSVFormat);
 
-        assertTrue(cSVFormatTwo.equals(cSVFormat));
+        assertTrue(cSVFormatTwo.equals(cSVFormat)); // TODO this fails since CSV-242 was applied. Why should the formats compare equal?
 
         final String string = cSVFormatTwo.format(objectArray);