You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "wperlichek (via GitHub)" <gi...@apache.org> on 2024/11/08 18:23:53 UTC
[PR] KAFKA-17779: Refactor Flaky RLM Test [kafka]
wperlichek opened a new pull request, #17724:
URL: https://github.com/apache/kafka/pull/17724
This test appears to be flaky because we mutated and reused the mocked log segments. Instead of using `thenReturn()` and changing return value of an existing mock, or mutating the log segments within an existing mock return value, we can establish states we will need for the test and then conditionally return them using `thenAnswer()` to ensure consistent/reliable mock behavior.
I ran the whole test class 100 times locally using below command and saw 100% success rate:
`N=100; I=0; while [ $I -lt $N ]; do ./gradlew core:test --tests "kafka.log.remote.RemoteLogManagerTest" --rerun --fail-fast; (( I=$I+1 )); echo "Completed run: $I"; sleep 1; done`
Resources for others interested in learning about tiered storage:
Deep dive: https://developers.redhat.com/articles/2024/03/13/kafka-tiered-storage-deep-dive
KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-405%3A+Kafka+Tiered+Storage
@kamalcph @chia7712 FYI
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17779: Refactor Flaky RLM Test [kafka]
Posted by "kamalcph (via GitHub)" <gi...@apache.org>.
kamalcph commented on PR #17724:
URL: https://github.com/apache/kafka/pull/17724#issuecomment-2466572792
The patch LGTM, will wait for the CI to complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17779: Refactor Flaky RLM Test [kafka]
Posted by "wperlichek (via GitHub)" <gi...@apache.org>.
wperlichek commented on PR #17724:
URL: https://github.com/apache/kafka/pull/17724#issuecomment-2466046733
@kamalcph Thanks for triggering the build, I had a formatting issue I fixed here c2297be7b479a93e348fab3469e5efe7917b1e7e, can we try the CI build again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17779: Refactor Flaky RLM Test [kafka]
Posted by "wperlichek (via GitHub)" <gi...@apache.org>.
wperlichek commented on PR #17724:
URL: https://github.com/apache/kafka/pull/17724#issuecomment-2466602270
> The patch LGTM, will wait for the CI to complete.
Thanks for the help. Looks like CI successfully completed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17779: Refactor Flaky RLM Test [kafka]
Posted by "kamalcph (via GitHub)" <gi...@apache.org>.
kamalcph merged PR #17724:
URL: https://github.com/apache/kafka/pull/17724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org