You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/08/06 09:20:58 UTC
[GitHub] [shardingsphere-elasticjob] codecov-commenter commented on pull request #1956: bugfix: getJobConfiguration return null instead of throw NullPointerException

codecov-commenter commented on pull request #1956:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1956#issuecomment-894128220


   # [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1956](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b00b3fe) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/1b2b15d7bf653b1fd6d455d940eabb13793347bb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1b2b15d) will **increase** coverage by `0.05%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/graphs/tree.svg?width=650&height=150&src=pr&token=8ZMVc4Yo4Z&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1956      +/-   ##
   ============================================
   + Coverage     85.56%   85.61%   +0.05%     
   - Complexity      113      137      +24     
   ============================================
     Files           276      277       +1     
     Lines          6026     6041      +15     
     Branches        922      918       -4     
   ============================================
   + Hits           5156     5172      +16     
   - Misses          530      531       +1     
   + Partials        340      338       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...cle/internal/settings/JobConfigurationAPIImpl.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1saWZlY3ljbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvbGl0ZS9saWZlY3ljbGUvaW50ZXJuYWwvc2V0dGluZ3MvSm9iQ29uZmlndXJhdGlvbkFQSUltcGwuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...ticjob/lite/internal/instance/InstanceService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvaW5zdGFuY2UvSW5zdGFuY2VTZXJ2aWNlLmphdmE=) | `95.23% <0.00%> (-4.77%)` | :arrow_down: |
   | [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `77.77% <0.00%> (-3.18%)` | :arrow_down: |
   | [.../lifecycle/internal/operate/JobOperateAPIImpl.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1saWZlY3ljbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvbGl0ZS9saWZlY3ljbGUvaW50ZXJuYWwvb3BlcmF0ZS9Kb2JPcGVyYXRlQVBJSW1wbC5qYXZh) | `91.78% <0.00%> (-0.33%)` | :arrow_down: |
   | [...rdingsphere/elasticjob/infra/json/GsonFactory.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9qc29uL0dzb25GYWN0b3J5LmphdmE=) | `100.00% <0.00%> (ø)` | |
   | [...asticjob/lite/internal/schedule/LiteJobFacade.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc2NoZWR1bGUvTGl0ZUpvYkZhY2FkZS5qYXZh) | `96.29% <0.00%> (ø)` | |
   | [...gsphere/elasticjob/tracing/JobTracingEventBus.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9Kb2JUcmFjaW5nRXZlbnRCdXMuamF2YQ==) | `95.65% <0.00%> (ø)` | |
   | [...mespace/setup/SpringProxyJobClassNameProvider.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1zcHJpbmcvZWxhc3RpY2pvYi1saXRlLXNwcmluZy1uYW1lc3BhY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvbGl0ZS9zcHJpbmcvbmFtZXNwYWNlL3NldHVwL1NwcmluZ1Byb3h5Sm9iQ2xhc3NOYW1lUHJvdmlkZXIuamF2YQ==) | | |
   | [...lite/spring/namespace/job/util/AopTargetUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1zcHJpbmcvZWxhc3RpY2pvYi1saXRlLXNwcmluZy1uYW1lc3BhY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvbGl0ZS9zcHJpbmcvbmFtZXNwYWNlL2pvYi91dGlsL0FvcFRhcmdldFV0aWxzLmphdmE=) | | |
   | [...ng/core/setup/SpringProxyJobClassNameProvider.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1zcHJpbmcvZWxhc3RpY2pvYi1saXRlLXNwcmluZy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvc3ByaW5nL2NvcmUvc2V0dXAvU3ByaW5nUHJveHlKb2JDbGFzc05hbWVQcm92aWRlci5qYXZh) | `80.00% <0.00%> (ø)` | |
   | ... and [6 more](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1b2b15d...b00b3fe](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1956?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org