You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2018/11/13 15:59:16 UTC

[GitHub] ocket8888 opened a new pull request #3023: WIP Supported routes fetch

ocket8888 opened a new pull request #3023: WIP Supported routes fetch
URL: https://github.com/apache/trafficcontrol/pull/3023
 
 
   ## What does this PR do?
   
   Fixes #2872 
   
   Adds two request methods to the Traffic Ops API path `/api/?$` - the `OPTIONS` method returns a list of supported API versions, and the `GET` method returns a list of all API paths that exist on the server. The latter does not evaluate regular expressions for existing objects, e.g. the path `api/1.2/servers/[0-9]+(\.json)$` will appear in the output, not the path `api/1.2/servers/1`.
   
   ### Why is this a WIP?
   Because, aside from the fact that it includes no documentation and hasn't been run through `go fmt` or `rat`, while the code appears to do what I want it to do, I'm not happy with the way I had to modify existing to code to accomplish it. I think at minimum a discussion about re-organizing parts of the `main` package needs to be had before this could be included.
   
   ## Which TC components are affected by this PR?
   
   - [ ] Documentation
   - [ ] Grove
   - [ ] Traffic Analytics
   - [ ] Traffic Monitor
   - [x] Traffic Ops
   - [ ] Traffic Ops ORT
   - [ ] Traffic Portal
   - [ ] Traffic Router
   - [ ] Traffic Stats
   - [ ] Traffic Vault
   - [x] Other - Potentially this could affect the Python/Go/Java clients (?)
   
   ## What is the best way to verify this PR?
   Build TO (Go) and run any/all tests. Ensure endpoints work, check the output of `OPTIONS`/`GET` requests against `/api/?$`.
   
   ## Check all that apply
   
   - [ ] This PR includes tests
   - [ ] This PR includes documentation updates
   - [ ] This PR includes an update to CHANGELOG.md
   - [x] This PR includes all required license headers
   - [ ] This PR includes a database migration (ensure that migration sequence is correct)
   - [ ] This PR fixes a serious security flaw. Read more: [www.apache.org/security](http://www.apache.org/security/)
   
   <!--
       Licensed to the Apache Software Foundation (ASF) under one
       or more contributor license agreements.  See the NOTICE file
       distributed with this work for additional information
       regarding copyright ownership.  The ASF licenses this file
       to you under the Apache License, Version 2.0 (the
       "License"); you may not use this file except in compliance
       with the License.  You may obtain a copy of the License at
   
         http://www.apache.org/licenses/LICENSE-2.0
   
       Unless required by applicable law or agreed to in writing,
       software distributed under the License is distributed on an
       "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
       KIND, either express or implied.  See the License for the
       specific language governing permissions and limitations
       under the License.
   -->
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services