You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/03/13 01:04:17 UTC
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #40387: [SPARK-42764][K8S] Parameterize the max number of attempts for driver props fetcher in KubernetesExecutorBackend
dongjoon-hyun commented on code in PR #40387:
URL: https://github.com/apache/spark/pull/40387#discussion_r1133357991
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesExecutorBackend.scala:
##########
@@ -82,7 +82,7 @@ private[spark] object KubernetesExecutorBackend extends Logging {
clientMode = true)
var driver: RpcEndpointRef = null
- val nTries = 3
+ val nTries = sys.env.getOrElse("EXECUTOR_DRIVER_PROPS_FETCHER_MAX_ATTEMPTS", 3)
Review Comment:
This name came from the name of this RPCEnv.
https://github.com/apache/spark/blob/71a54f0b4456028226d0867081e6becd4935d33f/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesExecutorBackend.scala#L75
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesExecutorBackend.scala:
##########
@@ -82,7 +82,7 @@ private[spark] object KubernetesExecutorBackend extends Logging {
clientMode = true)
var driver: RpcEndpointRef = null
- val nTries = 3
+ val nTries = sys.env.getOrElse("EXECUTOR_DRIVER_PROPS_FETCHER_MAX_ATTEMPTS", 3)
Review Comment:
This env name came from the name of this RPCEnv.
https://github.com/apache/spark/blob/71a54f0b4456028226d0867081e6becd4935d33f/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesExecutorBackend.scala#L75
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org