You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by syed <gi...@git.apache.org> on 2017/02/22 21:20:12 UTC
[GitHub] cloudstack pull request #1963: CLOUDSTACK-9799 - Unable to create volume fro...
GitHub user syed opened a pull request:
https://github.com/apache/cloudstack/pull/1963
CLOUDSTACK-9799 - Unable to create volume from snapshots with "_" in solidfire
Steps to reproduce:
1. Create a volume using the SolidFire plugin
2. Take a snpshot of the volume
3. Create volume from snapshot with "_" in the name
4. Error
@mike-tutkowski This as well :)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/syed/cloudstack sf_vol_from_snapshot_bug
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1963.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1963
----
commit d3d41335bc241a15a4c281cab6b7d2099f24f002
Author: Syed <sy...@gmail.com>
Date: 2017-02-22T21:16:44Z
Escape the volume name when creating volume from snapshot on SolidFire
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1963: CLOUDSTACK-9799 - Unable to create volume from snaps...
Posted by syed <gi...@git.apache.org>.
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1963
@mike-tutkowski If you already have this in your PR, I can close this. Let me know!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1963: CLOUDSTACK-9799 - Unable to create volume from snaps...
Posted by mike-tutkowski <gi...@git.apache.org>.
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1963
@syed Are you looking to get this into 4.10? If you are not, I have this corrected in a PR scheduled for 4.11. If you are, then I think you're missing a file (SolidFireUtil).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1963: CLOUDSTACK-9799 - Unable to create volume from snaps...
Posted by mike-tutkowski <gi...@git.apache.org>.
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1963
Yes, but the PR is scheduled for 4.11.
On Feb 23, 2017, at 10:58 AM, Syed Mushtaq Ahmed <no...@github.com>> wrote:
@mike-tutkowski<https://github.com/mike-tutkowski> If you already have this in your PR, I can close this. Let me know!
\u2014
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://github.com/apache/cloudstack/pull/1963#issuecomment-282069489>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AC4SH4VAr37y8mFqQw040R8XR0lg8fRBks5rfciLgaJpZM4MJM7O>.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1963: CLOUDSTACK-9799 - Unable to create volume fro...
Posted by syed <gi...@git.apache.org>.
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1963#discussion_r102798055
--- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java ---
@@ -711,6 +711,7 @@ private void handleCreateVolumeFromSnapshotBothOnStorageSystem(SnapshotInfo snap
}
catch (Exception ex) {
errMsg = ex.getMessage() != null ? ex.getMessage() : "Copy operation failed in 'StorageSystemDataMotionStrategy.handleCreateVolumeFromSnapshotBothOnStorageSystem'";
+ copyCmdAnswer = new CopyCmdAnswer(errMsg);
--- End diff --
That would be great @mike-tutkowski. That makes sure that the snapshot goes back to a good state if the storage driver operation fails. I will close this request then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1963: CLOUDSTACK-9799 - Unable to create volume fro...
Posted by mike-tutkowski <gi...@git.apache.org>.
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1963#discussion_r102793622
--- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java ---
@@ -711,6 +711,7 @@ private void handleCreateVolumeFromSnapshotBothOnStorageSystem(SnapshotInfo snap
}
catch (Exception ex) {
errMsg = ex.getMessage() != null ? ex.getMessage() : "Copy operation failed in 'StorageSystemDataMotionStrategy.handleCreateVolumeFromSnapshotBothOnStorageSystem'";
+ copyCmdAnswer = new CopyCmdAnswer(errMsg);
--- End diff --
@syed What I don't have in my version of this fix is this line of code. I can add it to mine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1963: CLOUDSTACK-9799 - Unable to create volume fro...
Posted by syed <gi...@git.apache.org>.
Github user syed closed the pull request at:
https://github.com/apache/cloudstack/pull/1963
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---